[image_picker_android] Modify FileUtils.getBaseName to return the whole filename when it contains no period #4237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…found, and add test
added 2 commits
June 16, 2023 13:50
gmackall
requested review from
tarrinneal,
camsim99,
reidbaker and
johnmccutchan
tarrinneal
approved these changes
Jun 20, 2023
gmackall
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 21, 2023
… the whole filename when it contains no period (flutter/packages#4237)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 21, 2023
flutter/packages@6e1918f...0fdf05f 2023-06-21 34871572+gmackall@users.noreply.github.com [image_picker_android] Modify FileUtils.getBaseName to return the whole filename when it contains no period (flutter/packages#4237) 2023-06-21 stuartmorgan@google.com [tools] Add mockito support to update-dependency (flutter/packages#4260) 2023-06-21 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.2 to 3.5.3 (flutter/packages#4185) 2023-06-21 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.21 to 1.8.22 in /packages/image_picker/image_picker_android/android (flutter/packages#4190) 2023-06-20 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.0.3 to 4.1.0 (flutter/packages#4145) 2023-06-20 stuartmorgan@google.com [ci] Add LUCI version of the analyze tasks (flutter/packages#4253) 2023-06-20 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.21 to 1.8.22 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#4193) 2023-06-20 stuartmorgan@google.com [ci] Switch Linux and web build-all to LUCI (flutter/packages#4252) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#124821
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.