Skip to content

bump mockito to version 5.4.1 #4085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2023
Merged

bump mockito to version 5.4.1 #4085

merged 2 commits into from
May 26, 2023

Conversation

christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented May 25, 2023 •
edited
Loading

Part of flutter/flutter#127226

Follow up to #3544. Version 5.4.0 from that PR is not new enough, see

Because mockito >=5.4.0 <5.4.1 depends on test_api >=0.2.1 <0.6.0 and every version of flutter_test from sdk depends on test_api 0.6.0, mockito >=5.4.0 <5.4.1 is incompatible with flutter_test from sdk.
So, because quick_actions_platform_interface depends on both flutter_test from sdk and mockito 5.4.0, version solving failed.

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8780090492483790881/+/u/run_test.dart_for_flutter_plugins_shard_and_subshard_analyze/test_stdout

@christopherfujino christopherfujino changed the title bump mockito to version 5.4.1 to unblock rolling test_core & test_api… bump mockito to version 5.4.1 May 25, 2023
@christopherfujino christopherfujino marked this pull request as ready for review May 25, 2023 21:57
tarrinneal
tarrinneal approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image_picker and pigeon lgtm

@christopherfujino christopherfujino mentioned this pull request May 25, 2023
Merged
stuartmorgan-g
stuartmorgan-g approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This reminds me, I still need need to add special mockito handling in the update-packages command.

@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels May 25, 2023
@stuartmorgan-g
Copy link
Contributor

Overrides: this is a dev only change, the scripts just don't look at the details of pubspecs.yaml changes yet, so can't tell.

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label May 25, 2023
@christopherfujino
Copy link
Contributor Author

LGTM

This reminds me, I still need need to add special mockito handling in the update-packages command.

thanks

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 25, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented May 25, 2023

auto label is removed for flutter/packages, pr: 4085, due to - The status or check suite downgraded_analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

ditman
ditman approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@ditman
Copy link
Member

ditman commented May 25, 2023

Clicking "update branch" to get this: #4086

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label May 26, 2023
@auto-submit auto-submit bot merged commit dd0d2bf into flutter:main May 26, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 29, 2023
@engine-flutter-autoroll
dd0d2bf bump mockito to version 5.4.1 (flutter/packages#4085)
5712eb6
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 29, 2023
@engine-flutter-autoroll
Roll Packages from 9f8dcc5 to 4a5cc3e (3 revisions) (#127801)
bd11ef0 
flutter/packages@9f8dcc5...4a5cc3e

2023-05-27 engine-flutter-autoroll@skia.org Roll Flutter (stable) from d3d8eff to 9cd3d0d (1 revision) (flutter/packages#4089)
2023-05-26 engine-flutter-autoroll@skia.org Roll Flutter from 216605b to ee162e4 (53 revisions) (flutter/packages#4090)
2023-05-26 christopherfujino@gmail.com bump mockito to version 5.4.1 (flutter/packages#4085)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@ditman ditman ditman approved these changes

@tarrinneal tarrinneal tarrinneal approved these changes

@cbracken cbracken Awaiting requested review from cbracken cbracken is a code owner

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@LouiseHsu LouiseHsu Awaiting requested review from LouiseHsu LouiseHsu is a code owner

@vashworth vashworth Awaiting requested review from vashworth vashworth is a code owner

@gmackall gmackall Awaiting requested review from gmackall gmackall is a code owner

@camsim99 camsim99 Awaiting requested review from camsim99 camsim99 is a code owner

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

@keyonghan keyonghan Awaiting requested review from keyonghan

@domesticmouse domesticmouse Awaiting requested review from domesticmouse

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: camera p: file_selector p: flutter_markdown p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: local_auth p: metrics_center p: path_provider p: pigeon p: plugin_platform_interface p: quick_actions p: url_launcher p: webview_flutter platform-android platform-ios platform-macos platform-web platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christopherfujino @stuartmorgan-g @ditman @tarrinneal