[local_auth_android] Fix Android lint warnings #3764

mgmix · 2023-04-20T09:10:01Z

Removed lint-baseline.xml and fixed all warnings.
The removal is mainly for unused resources that were identified by the ./gradlew lint check.

Part of flutter/flutter#88011

Pre-launch Checklist

making text value selectable

flutter-dashboard · 2023-04-20T09:10:04Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

camsim99 · 2023-04-24T16:19:42Z

packages/local_auth/local_auth_android/android/build.gradle

@@ -31,13 +31,13 @@ android {

    compileOptions {
        sourceCompatibility JavaVersion.VERSION_1_8
+        targetCompatibility JavaVersion.VERSION_1_8


Why this change?

I changed it because it was set in the build.gradle of other pacakges. Now that I think about it, it's an unrelated change, so I think I'll change it back.

Adding it is also a no-op (which is why I didn't add it when I added sourceCompatibility); the default value of targetCompatibility is sourceCompatibility's value.

Setting the record straight since I just learned that this is wrong: it's a no-op for some AGP (or maybe Gradle?) versions. For older versions leaving it out causes flutter/flutter#125482

But I'll be adding this (and enforcement that it's there) in a separate PR.

camsim99 · 2023-04-24T16:21:00Z

packages/local_auth/local_auth_android/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.0.25
+
+* Remove unused resourece by Android lint warnings.


Nit, maybe something linking the lint warnings and unused resources:

Suggested change

* Remove unused resourece by Android lint warnings.

* Removes unused resources as indicated by Android lint warnings.

camsim99 · 2023-04-24T16:25:16Z

Overall, this looks good -- thanks! Just left one main question about the build.gradle change.

resolve conflict

stuartmorgan-g · 2023-04-25T16:18:33Z

packages/local_auth/local_auth_android/android/src/main/res/layout/scan_fp.xml

For posterity, since I looked through commit history to figure out why these unused resources were here, these were part of the initial implementation, but became unused in flutter/plugins#1621.

packages/local_auth/local_auth_android/android/src/main/res/layout/go_to_setting.xml

set textIsSelectable to false

stuartmorgan-g

LGTM!

stuartmorgan-g · 2023-04-28T14:24:36Z

@camsim99 This is ready for final secondary review (and autosubmit if you are happy with it now).

camsim99

LGTM!

…ges#3764)

flutter/packages@f163786...407b7da 2023-05-03 vashworth@google.com Update Cirrus to Xcode 14.3 (flutter/packages#3890) 2023-05-03 stuartmorgan@google.com [file_selector] Deprecates `macUTIs` (flutter/packages#3888) 2023-05-03 41930132+hellohuanlin@users.noreply.github.com [pigeon]enable treat warning as errors for swift code in unit test (flutter/packages#3889) 2023-05-02 vashworth@google.com Update xcode to 14e222b (flutter/packages#3868) 2023-05-02 41930132+hellohuanlin@users.noreply.github.com [pigeon]fix "as Any" workaround due to nested optional (flutter/packages#3658) 2023-05-02 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Adds support to accept third party cookies (flutter/packages#3834) 2023-05-02 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes an exception caused by the `onUrlChange` callback returning a null url (flutter/packages#3848) 2023-05-02 pateltirth454@gmail.com [google_maps_flutter] [Docs] Note regarding usage within a bounded & an unbound widget (flutter/packages#3691) 2023-05-02 evace93@gmail.com [local_auth_android] Fix Android lint warnings (flutter/packages#3764) 2023-05-02 koji.wakamiya@gmail.com [go_router_builder] Support go_router v7 (flutter/packages#3858) 2023-05-02 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes internal enum type and adds unknown enum values (flutter/packages#3812) 2023-05-02 stuartmorgan@google.com [file_selector] Add MIME type support on macOS (flutter/packages#3862) 2023-05-02 engine-flutter-autoroll@skia.org Roll Flutter from 828a040 to db6074a (12 revisions) (flutter/packages#3881) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Removed lint-baseline.xml and fixed all warnings. The removal is mainly for unused resources that were identified by the `./gradlew lint` check. Part of flutter/flutter#88011

mgmix added 4 commits April 20, 2023 16:46

fix: remove baseline

e6666b6

fix: remove unused resource files by android gradle lint

2e85332

fix: lint warning

5f58348

making text value selectable

bump version

b52b4af

mgmix requested a review from camsim99 as a code owner April 20, 2023 09:10

flutter-dashboard bot added the needs tests label Apr 20, 2023

github-actions bot added p: local_auth platform-android labels Apr 20, 2023

mgmix added 2 commits April 22, 2023 18:18

Merge branch 'main' into local-auth-android-lint

ea9396a

bump version

700b774

camsim99 reviewed Apr 24, 2023

View reviewed changes

camsim99 requested a review from stuartmorgan-g April 24, 2023 16:23

mgmix added 4 commits April 25, 2023 01:50

fix: apply suggestions

3c52dc2

Merge branch 'main' into local-auth-android-lint

aeb5b16

Merge branch 'main' into local-auth-android-lint

9a6489a

bump version

f656c27

resolve conflict

stuartmorgan-g requested changes Apr 25, 2023

View reviewed changes

mgmix added 2 commits April 26, 2023 01:38

Merge branch 'main' into local-auth-android-lint

27431f1

fix: apply suggestion

38ded67

set textIsSelectable to false

This comment was marked as off-topic.

Sign in to view

stuartmorgan-g mentioned this pull request Apr 26, 2023

Remove Android lint-baseline.xml files from flutter/packages flutter/flutter#88011

Open

15 tasks

mgmix added 2 commits April 28, 2023 13:50

Merge branch 'main' into local-auth-android-lint

552e85a

bump version

cee993a

stuartmorgan-g approved these changes Apr 28, 2023

View reviewed changes

Merge branch 'main' into local-auth-android-lint

b67c8de

camsim99 approved these changes May 2, 2023

View reviewed changes

camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label May 2, 2023

auto-submit bot merged commit 5e9e211 into flutter:main May 2, 2023

engine-flutter-autoroll mentioned this pull request May 3, 2023

Roll Packages from f163786731b8 to 74991926ef67 (12 revisions) flutter/flutter#125977

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 3, 2023

5e9e211 [local_auth_android] Fix Android lint warnings (flutter/packa…

906e49b

…ges#3764)

engine-flutter-autoroll mentioned this pull request May 3, 2023

Roll Packages from f163786731b8 to 407b7da0079e (13 revisions) flutter/flutter#125988

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 3, 2023

5e9e211 [local_auth_android] Fix Android lint warnings (flutter/packa…

31b65f0

…ges#3764)

reidbaker mentioned this pull request May 12, 2023

[url_launcher] Set broadcast reciever visability as required by target api 34 #3973

Merged

11 tasks

This was referenced Jul 7, 2023

[Tool] New tool to download android dependencies #4408

Merged

[camera] tree fix format 2023 05 12 #4450

Closed

[tooling] mark infra steps as infra steps in yaml files #4473

Merged

reidbaker mentioned this pull request Jul 26, 2023

[Tooling] Add google owned cache for dependencies as an option in ci #4567

Merged

11 tasks

reidbaker mentioned this pull request Aug 4, 2023

[All] Expand artifact hub to all plugins #4645

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[local_auth_android] Fix Android lint warnings #3764

[local_auth_android] Fix Android lint warnings #3764

Uh oh!

mgmix commented Apr 20, 2023

Uh oh!

flutter-dashboard bot commented Apr 20, 2023

Uh oh!

camsim99 Apr 24, 2023

Uh oh!

mgmix Apr 24, 2023

Uh oh!

stuartmorgan-g Apr 24, 2023

Uh oh!

stuartmorgan-g Apr 25, 2023 •

edited

Loading

Uh oh!

camsim99 Apr 24, 2023

Uh oh!

camsim99 commented Apr 24, 2023

Uh oh!

stuartmorgan-g Apr 25, 2023

Uh oh!

Uh oh!

Uh oh!

This comment was marked as off-topic.

stuartmorgan-g left a comment

Uh oh!

stuartmorgan-g commented Apr 28, 2023

Uh oh!

camsim99 left a comment

Uh oh!

Uh oh!

		@@ -1,3 +1,7 @@
		## 1.0.25

		* Remove unused resourece by Android lint warnings.

	* Remove unused resourece by Android lint warnings.
	* Removes unused resources as indicated by Android lint warnings.

[local_auth_android] Fix Android lint warnings #3764

[local_auth_android] Fix Android lint warnings #3764

Uh oh!

Conversation

mgmix commented Apr 20, 2023

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Apr 20, 2023

Uh oh!

camsim99 Apr 24, 2023

Choose a reason for hiding this comment

Uh oh!

mgmix Apr 24, 2023

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Apr 24, 2023

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Apr 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camsim99 Apr 24, 2023

Choose a reason for hiding this comment

Uh oh!

camsim99 commented Apr 24, 2023

Uh oh!

stuartmorgan-g Apr 25, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment was marked as off-topic.

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Apr 28, 2023

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stuartmorgan-g Apr 25, 2023 •

edited

Loading