-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[webview_flutter] Adds support to receive permission requests #3543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
48d4c9d
make deps path based
bparrishMines 4ad0174
interface implementation
bparrishMines a51decc
support for permissionrequest
bparrishMines c6880bb
add method to webchromeclient
bparrishMines 896ce9b
android impl without tests
bparrishMines f2f6f2a
remove imports
bparrishMines d7a54d0
update platform interface
bparrishMines 38a727d
update interface again
bparrishMines 44a0c2e
finish android implementation
bparrishMines 8588900
change to platformwebviewpermissionrequest
bparrishMines 631cfb8
version bump formatting and app facing implementation
bparrishMines 4505f04
test constants
bparrishMines df40eca
redundant version checks
bparrishMines 83c428a
Merge branch 'main' of github.com:flutter/packages into webview_permi…
bparrishMines e58ea0d
undo ios mocks change
bparrishMines 07c3ac1
update webviewpermissionrequest
bparrishMines c8466f4
update app-facing package
bparrishMines e0801bc
add wkwebview method dart impl
bparrishMines da4a45f
finish dart ios code with failing tests
bparrishMines bfd6f27
formatting
bparrishMines e63f3e9
Merge branch 'main' of github.com:flutter/packages into webview_permi…
bparrishMines 09eea9a
fix tests
bparrishMines c7606bb
Merge branch 'main' of github.com:flutter/packages into webview_permi…
bparrishMines 10ef24c
controller test
bparrishMines d516b34
webview data converters
bparrishMines 85f2b56
implement callback
bparrishMines 5fbca14
update app-facing package
bparrishMines 482b7c1
Merge branch 'main' of github.com:flutter/packages into webview_permi…
bparrishMines a291c52
fix lint errors
bparrishMines fb2b779
Merge branch 'main' of github.com:flutter/packages into webview_permi…
bparrishMines eeff573
try fix test
bparrishMines 7a9a039
fix objc test
bparrishMines 356e8ad
prompt by default
bparrishMines 4800b3a
comment
bparrishMines fd3af75
test that ios works
bparrishMines 7570c5b
add permissions to debug camera access
bparrishMines 8946b87
reference permissions and version bump
bparrishMines 23121e5
Merge branch 'main' of github.com:flutter/packages into webview_permi…
bparrishMines 7d71719
undo webview_flutter change
bparrishMines 6717cf4
improve docs and fix tests
bparrishMines d566b5e
naming
bparrishMines 8e39a28
add version check
bparrishMines 922028e
fix integration test
bparrishMines e592ae1
Merge branch 'main' of github.com:flutter/packages into webview_permi…
bparrishMines adc7f3c
add baseline back
bparrishMines 9a57b03
fix lint
bparrishMines 96b1515
add call to observe URL back
bparrishMines bfe3d64
Merge branch 'main' of github.com:flutter/packages into webview_permi…
bparrishMines 44aaf7e
Merge branch 'main' of github.com:flutter/packages into webview_permi…
bparrishMines 4f4c253
some of the review comments
bparrishMines bef6efa
fix methods, docs and make template naming consistent
bparrishMines f155afb
update dataconverter class names
bparrishMines f8b2691
Merge branch 'main' of github.com:flutter/packages into webview_permi…
bparrishMines 68610f1
fix old method names
bparrishMines 07a074b
Merge branch 'main' of github.com:flutter/packages into webview_permi…
bparrishMines a33ea19
docs and added a test
bparrishMines 0638c30
Merge branch 'main' of github.com:flutter/packages into webview_permi…
bparrishMines d9c4a6e
add a comment about not recognizing permissions
bparrishMines a6496b8
Merge branch 'main' of github.com:flutter/packages into webview_permi…
bparrishMines fd13fce
Merge branch 'main' of github.com:flutter/packages into webview_permi…
bparrishMines ec80236
version bump
bparrishMines b065c45
move macro
bparrishMines 535374b
fix files
bparrishMines b8a409f
last file
bparrishMines ba07eb1
export main_file.PlatformWebViewPermissionRequest
bparrishMines 8715691
undo the export
bparrishMines 520bf59
add more documention
bparrishMines File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made the template naming more consistent by matching the class name