[go_router] Sets correct reverseTransitionDuration on NoTransitionPage (#123368) #3540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-burton
force-pushed
the
bug/no-transition-reverse-delay
branch
from
fc47574 to
d04b8e4
Compare
chunhtai
reviewed
Mar 24, 2023
josh-burton
force-pushed
the
bug/no-transition-reverse-delay
branch
from
d04b8e4 to
beb732a
Compare
|
there is a merge conflict |
josh-burton
force-pushed
the
bug/no-transition-reverse-delay
branch
from
beb732a to
d6ccf43
Compare
|
Rebased and bumped version to 6.5.2 |
|
@josh-burton can you fix the format? |
josh-burton
force-pushed
the
bug/no-transition-reverse-delay
branch
from
d6ccf43 to
ce91025
Compare
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 31, 2023
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
…e (#123368) (flutter#3540) [go_router] Sets correct reverseTransitionDuration on NoTransitionPage (#123368)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the reverseTransitionDuration of NoTransitionPage to 1 microsecond to match the transition duration (and to ensure there is an instant reverse transition).
fixes flutter/flutter#123368
List which issues are fixed by this PR. You must list at least one issue.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.