Skip to content

[webview_flutter_android] Fix the leak in the legacy implementation #3483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 21, 2023
Merged

[webview_flutter_android] Fix the leak in the legacy implementation #3483

merged 4 commits into from
Mar 21, 2023

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Mar 16, 2023 •
edited
Loading

Fixes same issue from: flutter/plugins#6996

No version bump since it only affects unused internal legacy code.

Part of the work to push the plugin internally.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Mar 21, 2023
stuartmorgan-g
stuartmorgan-g approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
@auto-submit auto-submit bot merged commit fe71a8c into flutter:main Mar 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
fe71a8c [webview_flutter_android] Fix the leak in the legacy implemen…
0f4e63b 
…tation (flutter/packages#3483)
@bparrishMines bparrishMines deleted the fix_legacy_gc branch June 15, 2023 17:26
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@bparrishMines @nploi
[webview_flutter_android] Fix the leak in the legacy implementation (f…
e08f948 
…lutter#3483)

[webview_flutter_android] Fix the leak in the legacy implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: webview_flutter platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bparrishMines @stuartmorgan-g