[camerax] Implement onCameraClosing #3419
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o/flutter/plugins/camerax/ImageCaptureHostApiImpl.java Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>
Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>
camsim99
requested review from
hellohuanlin,
vashworth,
tarrinneal,
stuartmorgan-g,
gspencergoog,
chunhtai,
domesticmouse,
ditman,
Piinks and
goderbauer
as code owners
camsim99
removed request for
domesticmouse,
stuartmorgan-g,
goderbauer,
ditman,
gspencergoog,
vashworth,
Piinks,
hellohuanlin,
chunhtai and
tarrinneal
|
Closing this PR to better keep track of feedback and because I made a git error that roped in a bunch of unintentional changes. |
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
May 9, 2023
### Overview Continuation of #3419. Implements onCameraClosing that will send an event anytime the camera closes, as detected by observing the LiveData of the CameraState of the current camera being used in the plugin. Fixes flutter/flutter#121162. ### Highlights of what has changed since the latest reviews of the [last PR](#3419): - Wrapped `LiveData#getValue` ([docs](https://developer.android.com/reference/androidx/lifecycle/LiveData#getValue())) for the purposes of retrieving current value `LiveData<ZoomState>` to properly implement retrieving zoom information - Modified Dart Host API and FlutterAPI implementations' documentation on their `binaryMessenger` and `instanceManager` documentation to be clearer as per suggestion from comments on the original PR - Changed `binaryMessenger` and `instanceManager` fields to be private in Flutter API implementations - Removed `cast` method and added enum `LiveDataSupportedType` to pigeon file to use for safely casting the `LiveData` generic when received on the Dart or native side. - Moved `CameraStateError` code decoding to Dart side as this was written by me and not directly provided by CameraX. - Added tests for the conversion of objects. - The following issues were filed to capture feedback given but not addressed in this PR: flutter/flutter#125926, flutter/flutter#125928.
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
### Overview Continuation of flutter#3419. Implements onCameraClosing that will send an event anytime the camera closes, as detected by observing the LiveData of the CameraState of the current camera being used in the plugin. Fixes flutter/flutter#121162. ### Highlights of what has changed since the latest reviews of the [last PR](flutter#3419): - Wrapped `LiveData#getValue` ([docs](https://developer.android.com/reference/androidx/lifecycle/LiveData#getValue())) for the purposes of retrieving current value `LiveData<ZoomState>` to properly implement retrieving zoom information - Modified Dart Host API and FlutterAPI implementations' documentation on their `binaryMessenger` and `instanceManager` documentation to be clearer as per suggestion from comments on the original PR - Changed `binaryMessenger` and `instanceManager` fields to be private in Flutter API implementations - Removed `cast` method and added enum `LiveDataSupportedType` to pigeon file to use for safely casting the `LiveData` generic when received on the Dart or native side. - Moved `CameraStateError` code decoding to Dart side as this was written by me and not directly provided by CameraX. - Added tests for the conversion of objects. - The following issues were filed to capture feedback given but not addressed in this PR: flutter/flutter#125926, flutter/flutter#125928.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
onCameraClosingthat will send an event anytime the camera closes, as detected by observing theLiveDataof theCameraStateof the current camera being used in the plugin.Fixes flutter/flutter#121162.
FYI, there's a fair amount of unrelated code cleanup in this PR, as well.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).