Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pigeon] updated readme wrt @async #3058

Merged
merged 3 commits into from
Jan 18, 2023
Merged

[pigeon] updated readme wrt @async #3058

merged 3 commits into from
Jan 18, 2023

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Jan 17, 2023 •
edited
Loading

alternative to #2722

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke changed the title updated readme [pigeon] updated readme wrt @async Jan 17, 2023
@gaaclarke gaaclarke marked this pull request as ready for review January 17, 2023 18:27
@gaaclarke gaaclarke requested a review from tarrinneal as a code owner January 17, 2023 18:27
@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 18, 2023
@auto-submit auto-submit bot merged commit c68bf70 into flutter:main Jan 18, 2023
@gaaclarke gaaclarke mentioned this pull request Jan 18, 2023
Closed
Maatteogekko pushed a commit to Maatteogekko/packages that referenced this pull request Feb 4, 2023
@gaaclarke @tarrinneal @Maatteogekko
[pigeon] updated readme wrt @async (flutter#3058)
895d9ba 
* updated readme

* updates version

Co-authored-by: tarrinneal <tarrinneal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrinneal tarrinneal tarrinneal approved these changes

@stuartmorgan stuartmorgan Awaiting requested review from stuartmorgan

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: pigeon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaaclarke @tarrinneal