Temporarily make 'publishable' failures non-fatal #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows publishing NNBD packages as stable previews rather than prereleases without CI being red. The step still runs, so it can be manually validated for other issues. Since this repository is low-traffic, and the cost of something slipping through here is minor (since it will be caught when actually trying to publish), it's not worth engineering a solution to ignore only the specific failure in this case. This should be reverted once NNBD support is on stable.
This was referenced Feb 16, 2021
mzdm
added a commit
to mzdm/packages
that referenced
this pull request
Feb 18, 2021
mzdm
added a commit
to mzdm/packages
that referenced
this pull request
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows publishing NNBD packages as stable previews rather than prereleases without CI being red. The step still runs, so it can be manually validated for other issues. Since this repository is low-traffic, and the cost of something slipping through here is minor (since it will be caught when actually trying to publish), it's not worth engineering a solution to ignore only the specific failure in this case.
This should be reverted once NNBD support is on stable.