[xdg_directories] Fix stdout encoding handling #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stdoutEncoding was originally specified as a by-name lookup of "utf8"; this was actually equivalent to 'null', since that's not the correct name. During the null safety migration, a fallback to systemEncoding was added, causing it to always have an encoding. This changed the type of result.stdout, so all calls gave a type error. This fixes the issue by using 'utf8', the singleton encoder object, rather than doing a name lookup, so the type will predicably be a string, and adjusting the code reading it to expect a string.
stuartmorgan
pushed a commit
to stuartmorgan/packages
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stdoutEncoding was originally specified as a by-name lookup of
"utf8"; this was actually equivalent to 'null', since that's not the
correct name. During the null safety migration, a fallback to
systemEncoding was added, causing it to always have an encoding. This
changed the type of result.stdout, so all calls gave a type error.
This fixes the issue by using 'utf8', the singleton encoder object,
rather than doing a name lookup, so the type will predicably be a
string, and adjusting the code reading it to expect a string.