Skip to content

Allow tests to override GCP project id. #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liyuqian merged 1 commit into from
Jan 28, 2021
Merged

Allow tests to override GCP project id. #276

liyuqian merged 1 commit into from
Jan 28, 2021

Conversation

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Jan 28, 2021 •
edited
Loading

This is needed by flutter/engine#24022

@liyuqian liyuqian requested a review from keyonghan January 28, 2021 19:12
@liyuqian liyuqian mentioned this pull request Jan 28, 2021
Merged
keyonghan
keyonghan reviewed Jan 28, 2021
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liyuqian liyuqian merged commit 0e3e175 into flutter:master Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@keyonghan keyonghan keyonghan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liyuqian @keyonghan