Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

Picks up the workaround for
dart-lang/pub#3618

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g
Copy link
Collaborator Author

Landing on red since the failure from the last pigeon commit was due to the thing this fixes.

@stuartmorgan-g stuartmorgan-g merged commit cd818ba into flutter:main Oct 31, 2022
@stuartmorgan-g stuartmorgan-g deleted the tool-roll-0-12-1 branch October 31, 2022 15:45
@ditman
Copy link
Member

ditman commented Oct 31, 2022

(ACK! Thanks for installing this in flutter/packages! I didn't do it because I hadn't seen the failure here yet, but I guess it was a matter of time)

@stuartmorgan-g
Copy link
Collaborator Author

I similarly thought about it and figured we'd get to it when it came up. In retrospect I should have realized it would almost certainly be quickly and done it preemptively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants