Skip to content

[pigeon] support directory generated and fix no call niladic functions #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

wittyneko
Copy link

No description provided.

@google-cla
Copy link

google-cla bot commented Jan 14, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@wittyneko wittyneko changed the title fix no call niladic functions [pigeon] support directory generated and fix no call niladic functions Jan 15, 2021
@wittyneko
Copy link
Author

@googlebot I signed it!

@goderbauer goderbauer requested a review from gaaclarke January 27, 2021 21:05
@gaaclarke
Copy link
Member

Hey, thanks for the PR. Supporting directories really isn't something that's needed. That's easily implemented with scripting and keeps the pigeon source code simple, ex find ./pigeons -exec flutter pub run pigeon ... {} \;

Do you want to split out your other change into its own PR and add a test?

@gaaclarke gaaclarke closed this Jan 27, 2021
stuartmorgan-g pushed a commit to stuartmorgan-g/packages that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants