Skip to content

Conversation

@johnpryan
Copy link
Contributor

@johnpryan johnpryan commented Jul 26, 2022

We can't change the name of this library since go_router_builder already has a published version that depends on it #2381 (comment)

Fixes flutter/flutter#108274

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@stuartmorgan-g
Copy link
Collaborator

Please add the tooling roll to this PR (as described in the other PR's comments) so that we get presubmit validation that this is sufficient to fix everything.

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Do you plan to change it back at some point? If so, you should add a todo and probably does that as part of the go_router v5 breaking change

@chunhtai
Copy link
Contributor

pinged Hixie on discord for NTE

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,3 +1,7 @@
## 4.2.2

- Fixes a bug where go_router_builder wasn't detecting annotations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Missing period (per style guide).

@Hixie
Copy link
Contributor

Hixie commented Jul 26, 2022

test-exempt: is tested: rolling flutter_plugin_tools will enable the test in ro_router_builder to use the tip of tree version of go_router which would have caught the error this is fixing.

@johnpryan johnpryan merged commit 08f8ac4 into flutter:main Jul 26, 2022
@johnpryan johnpryan deleted the rename-builder-lib branch August 11, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[go_router] go_router 4.2.1 breaks go_router_builder

6 participants