-
Couldn't load subscription status.
- Fork 3.5k
Change typed_routing.dart back to route_data.dart #2385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Please add the tooling roll to this PR (as described in the other PR's comments) so that we get presubmit validation that this is sufficient to fix everything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do you plan to change it back at some point? If so, you should add a todo and probably does that as part of the go_router v5 breaking change
|
pinged Hixie on discord for NTE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (with nit)
I've verified that this is running the tests with an override as expected:
https://cirrus-ci.com/task/6731406855372800?logs=pathified_unit_test#L3
https://cirrus-ci.com/task/6731406855372800?logs=pathified_unit_test#L256
packages/go_router/CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| ## 4.2.2 | |||
|
|
|||
| - Fixes a bug where go_router_builder wasn't detecting annotations | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Missing period (per style guide).
|
test-exempt: is tested: rolling flutter_plugin_tools will enable the test in ro_router_builder to use the tip of tree version of go_router which would have caught the error this is fixing. |
We can't change the name of this library since go_router_builder already has a published version that depends on it #2381 (comment)
Fixes flutter/flutter#108274