Skip to content

Conversation

@engine-flutter-autoroll
Copy link
Contributor

flutter/flutter@38dbbb1...fdcd144

2022-03-02 30870216+gaaclarke@users.noreply.github.com Starts using the --source flag to compile the dart registrant. (flutter/flutter#98046)
2022-03-01 egarciad@google.com Add Android lifecycles test (flutter/flutter#99319)
2022-03-01 47866232+chunhtai@users.noreply.github.com Revert "Clean up ClipboardStatusNotifier (#98951)" (flutter/flutter#99361)
2022-03-01 engine-flutter-autoroll@skia.org Roll Engine from dc1dba505c33 to a5718ab3c33b (9 revisions) (flutter/flutter#99346)
2022-03-01 godofredoc@google.com Update mac chrome and driver to 98. (flutter/flutter#99318)
2022-03-01 rmolivares@renzo-olivares.dev Remove redundant properties passed to _Editable (flutter/flutter#99192)
2022-03-01 campfish91@gmail.com [framework] improve Notification API performance by skipping full Element tree traversal (flutter/flutter#98451)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows local_tests master - packages has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows win32-platform_tests master - packages has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite format+analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite publishable has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-build+platform-tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-build+platform-tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@engine-flutter-autoroll
Copy link
Contributor Author

Commit queue failed; closing this roll.

@engine-flutter-autoroll engine-flutter-autoroll deleted the flutter-packages-4bfd4dda-dff2-46a5-8065-f8b6def066d2-1646180845 branch March 9, 2022 01:22
stuartmorgan-g pushed a commit that referenced this pull request Oct 31, 2024
…1000)

* Fixed the hashcode in SvgStringLoader and SvgBytesLoader.

It was accidently using the svg global object, instead of a local field. This caused caches (such as PaintingBinding.instance.imageCache) to misbehave.

* Add a test which ensures the embedded image in a SvgPicture is not incorrectly cached and carried over.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants