Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4926c0f8bd99
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7da2374fd818
Choose a head ref
  • 3 commits
  • 7 files changed
  • 3 contributors

Commits on Sep 24, 2024

  1. [go_router] Fixed TabView swiping in custom stateful shell route exam…

    …ple (#7583)
    
    Updated `custom_stateful_shell_route.dart` example to better support
    swiping in TabView. Also added code to demonstrate use of PageView
    instead of TabView. Note that to be fully effective from a usability
    perspective, the PR #6467 (branch preloading) need also
    be merged.
    
    This PR addresses: 
    * flutter/flutter#150837 
    * flutter/flutter#112267
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] page, which explains my
    responsibilities.
    - [x] I read and followed the [relevant style guides] and ran the
    auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
    repo does use `dart format`.)
    - [x] I signed the [CLA].
    - [x] The title of the PR starts with the name of the package surrounded
    by square brackets, e.g. `[shared_preferences]`
    - [x] I [linked to at least one issue that this PR fixes] in the
    description above.
    - [x] I updated `pubspec.yaml` with an appropriate new version according
    to the [pub versioning philosophy], or this PR is [exempt from version
    changes].
    - [x] I updated `CHANGELOG.md` to add a description of the change,
    [following repository CHANGELOG style], or this PR is [exempt from
    CHANGELOG changes].
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
    [relevant style guides]:
    https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
    [CLA]: https://cla.developers.google.com/
    [Discord]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
    [linked to at least one issue that this PR fixes]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
    [pub versioning philosophy]: https://dart.dev/tools/pub/versioning
    [exempt from version changes]:
    https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version
    [following repository CHANGELOG style]:
    https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
    [exempt from CHANGELOG changes]:
    https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog
    [test-exempt]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
    tolo authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    47795ab View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. [flutter_lints] remove prefer_const_constructors, prefer_const_declar…

    …ations, prefer_const_literals_to_create_immutables (#7688)
    
    This PR removes three const lints from package:flutter_lints:
    `prefer_const_constructors`, `prefer_const_declarations`, and
    `prefer_const_literals_to_create_immutables`.
    
    This PR does not rev the pubspec version. We want to stage this change
    out in coordination with package:lints; see
    https://github.com/dart-lang/lints/issues/209.
    
    - https://github.com/dart-lang/lints/issues/205
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] page, which explains my
    responsibilities.
    - [x] I read and followed the [relevant style guides] and ran the
    auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
    repo does use `dart format`.)
    - [x] I signed the [CLA].
    - [x] The title of the PR starts with the name of the package surrounded
    by square brackets, e.g. `[shared_preferences]`
    - [x] I [linked to at least one issue that this PR fixes] in the
    description above.
    - [x] I updated `pubspec.yaml` with an appropriate new version according
    to the [pub versioning philosophy], or this PR is [exempt from version
    changes].
    - [x] I updated `CHANGELOG.md` to add a description of the change,
    [following repository CHANGELOG style], or this PR is [exempt from
    CHANGELOG changes].
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
    [relevant style guides]:
    https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
    [CLA]: https://cla.developers.google.com/
    [Discord]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
    [linked to at least one issue that this PR fixes]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
    [pub versioning philosophy]: https://dart.dev/tools/pub/versioning
    [exempt from version changes]:
    https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version
    [following repository CHANGELOG style]:
    https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
    [exempt from CHANGELOG changes]:
    https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog
    [test-exempt]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
    devoncarew authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    54dd888 View commit details
    Browse the repository at this point in the history
  2. Update test to not depend on Color.toString() (#7701)

    In flutter/engine#55231, the implementation of `Color.toString()` has changed. Update the test to not depend on the exact implementation.
    chingjun authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7da2374 View commit details
    Browse the repository at this point in the history
Loading