Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2faf992a0589
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f751ffb7d3cf
Choose a head ref
  • 11 commits
  • 82 files changed
  • 7 contributors

Commits on Oct 24, 2023

  1. Update annotations deps to 1.7 (#4935)

    - Update annotation dependency
    - Add changelog for update
    reidbaker authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    264b2fc View commit details
    Browse the repository at this point in the history
  2. [ci] Fix legacy Android task names (#5191)

    Uses a capital for the first letter of the task names for consistency with the other tasks (which affects sorting in the GitHub PR UI).
    
    Part of flutter/flutter#130010
    stuartmorgan-g authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    e34ad30 View commit details
    Browse the repository at this point in the history
  3. [url_launcher] Add an inAppBrowserView mode in implementations (#5211)

    Implementation package portion of #5155
    
    This adds:
    - Android support for the new `inAppBrowserView` launch mode which is distinct from `inAppWebView`, so that use cases that require programatic close can specifically request `inAppWebView` instead.
      - The default for web links is the new `inAppBrowserView` since that gives better results in most cases.
      - `inAppBrowserView` will still automatically fall back to `inAppBrowserView` in cases where it's not supported. (In the future, we might want to tune that based on feedback. We could instead have three modes: the webview-only mode we now have, the dynamic mode we now have iff the user requested `platformDefault`, and a new Android Custom Tabs-only if it was explicitly requested which would fail if it doesn't work.)
    - iOS support for treating `inAppBrowserView` as identical to `inAppWebView`, since in practice that's what its `inAppWebView` mode has always been.
    - Support on all platforms for the new `supportsMode` and `supportsCloseForMode` support query methods.
    
    Fixes flutter/flutter#134208
    stuartmorgan-g authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    a0ed435 View commit details
    Browse the repository at this point in the history
  4. [Android] Introduces API 34 emulators for subset of tests (#5105)

    Introduces API 34 emulators for subset of tests not causing test failures in #4804. Also changes linux_android version to 34v1.
    
    Continuation of #4820.
    camsim99 authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    3cc6e26 View commit details
    Browse the repository at this point in the history
  5. [url_launcher] Add an inAppBrowserView mode (#5155)

    `url_launcher_android` recently switched from an in-app webview to an Android Custom Tab (when supported), which was intended to be an in-place upgrade. However, this broke `closeInAppWebView`, and that couldn't be fixed directly because Android Custom Tab has no mechanism for programatic close. To address the regression, this adds a new `inAppBrowserView` launch mode which is distinct from `inAppWebView`, so that use cases that require programatic close can specifically request `inAppWebView` instead. The default for web links is the new `inAppBrowserView` since that gives better results in most cases.
    
    Since whether `closeInAppWebView` will work in any given case is now non-trivial (on iOS, both in-app modes are supported, but on Android it's only the web view mode), this adds a new support API to query it, in keeping with the relatively new guidance of https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#api-support-queries. It also adds API to query for support for being able to use specific launch modes, since there wasn't a good way to understand which modes worked in general on different platforms.
    
    Since there are new APIs, this adds support for those APIs to all of our implementations to ensure that they give accurate responses.
    
    Fixes flutter/flutter#134208
    stuartmorgan-g authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    c6821f9 View commit details
    Browse the repository at this point in the history
  6. [webview_flutter_wkwebview] Only set `limitsNavigationsToAppBoundDoma…

    …ins` when it is set to true (#5137)
    
    This changes the flag to only flag to only call the method if it sets it to `true`.
    
    Fixes flutter/flutter#136449
    bparrishMines authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    f22ff36 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. [ci] Disable Windows Arm64 stable CI (#5217)

    The Windows Arm64 build-only stable test is currently failing as the necessary build layout migration hasn't landed on stable yet: flutter/flutter@792e26d
    
    This test can be re-added after the next Flutter stable release. This is tracked by flutter/flutter#129813
    loic-sharma authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    a927ade View commit details
    Browse the repository at this point in the history
  2. Update the ftl hardware version. (#5224)

    This is to unblock tests in packages timing out because of long queue times in ftl tests.
    godofredoc authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    afefb12 View commit details
    Browse the repository at this point in the history
  3. Replace gems dependency with ruby. (#5219)

    The new ruby packages are fully automated and already include cocoapods.
    
    Bug: flutter/flutter#136377
    godofredoc authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    58b61d4 View commit details
    Browse the repository at this point in the history
  4. Bump ossf/scorecard-action from 2.3.0 to 2.3.1 (#5209)

    Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.3.0 to 2.3.1.
    <details>
    <summary>Release notes</summary>
    <p><em>Sourced from <a href="https://github.com/ossf/scorecard-action/releases">ossf/scorecard-action's releases</a>.</em></p>
    <blockquote>
    <h2>v2.3.1</h2>
    <h2>What's Changed</h2>
    <ul>
    <li>:seedling: Bump github.com/ossf/scorecard/v4 from v4.13.0 to v4.13.1 by <a href="https://github.com/spencerschrock"><code>@�spencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1282">ossf/scorecard-action#1282</a>
    <ul>
    <li>Adds additional Fuzzing detection and fixes a SAST bug related to detecting CodeQL. For a full changelist of what this includes, see the  <a href="https://github.com/ossf/scorecard/releases/tag/v4.13.1">v4.13.1</a> release notes</li>
    </ul>
    </li>
    </ul>
    <p><strong>Full Changelog</strong>: <a href="https://github.com/ossf/scorecard-action/compare/v2.3.0...v2.3.1">https://github.com/ossf/scorecard-action/compare/v2.3.0...v2.3.1</a></p>
    </blockquote>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a href="https://github.com/ossf/scorecard-action/commit/0864cf19026789058feabb7e87baa5f140aac736"><code>0864cf1</code></a> 🌱 Bump docker tag to for v2.3.1 release (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1284">#1284</a>)</li>
    <li><a href="https://github.com/ossf/scorecard-action/commit/72df3bff668d052aaec251accaffec0b280410fb"><code>72df3bf</code></a> 🌱 Bump github.com/ossf/scorecard/v4 from v4.13.0 to v4.13.1 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1282">#1282</a>)</li>
    <li><a href="https://github.com/ossf/scorecard-action/commit/0ea411f94ac145b6fd793458b7f75ebbe7ae0a8f"><code>0ea411f</code></a> 🌱 Bump the docker-images group with 1 update (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1281">#1281</a>)</li>
    <li><a href="https://github.com/ossf/scorecard-action/commit/dbfd042453ccc43ade96943685dbece2dd86bbae"><code>dbfd042</code></a> 🌱 Bump the github-actions group with 1 update (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1280">#1280</a>)</li>
    <li><a href="https://github.com/ossf/scorecard-action/commit/2fa1e2fa153141e2950c7e1299ed05e2081ead0c"><code>2fa1e2f</code></a> 🌱 Bump golang.org/x/net from 0.16.0 to 0.17.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1278">#1278</a>)</li>
    <li><a href="https://github.com/ossf/scorecard-action/commit/652ddd06c802ac1ba4021a9f02978dc5150b223e"><code>652ddd0</code></a> 🌱 Bump github.com/google/go-cmp from 0.5.9 to 0.6.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1277">#1277</a>)</li>
    <li><a href="https://github.com/ossf/scorecard-action/commit/28d0c92b8bb9dd266a8cf4dde7bae71c06a0c62f"><code>28d0c92</code></a> 🌱 Group Dependabot updates for GitHub Actions and Dockerfiles (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1276">#1276</a>)</li>
    <li><a href="https://github.com/ossf/scorecard-action/commit/cb50491a46a858cb57669a16a720b7a00e1f9d29"><code>cb50491</code></a> 🌱 Bump distroless/base from <code>a35b652</code> to <code>b31a6e0</code> (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1275">#1275</a>)</li>
    <li><a href="https://github.com/ossf/scorecard-action/commit/87157ac77d7ec18a631049bc92fdac7ee63a471a"><code>87157ac</code></a> 🌱 Bump github/codeql-action from 2.21.9 to 2.22.1 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1274">#1274</a>)</li>
    <li><a href="https://github.com/ossf/scorecard-action/commit/7c1648b23e27a96acf7c3842fd1921d16bd8d4d2"><code>7c1648b</code></a> 🌱 Bump step-security/harden-runner from 2.5.1 to 2.6.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1273">#1273</a>)</li>
    <li>Additional commits viewable in <a href="https://github.com/ossf/scorecard-action/compare/483ef80eb98fb506c348f7d62e28055e49fe2398...0864cf19026789058feabb7e87baa5f140aac736">compare view</a></li>
    </ul>
    </details>
    <br />
    
    [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ossf/scorecard-action&package-manager=github_actions&previous-version=2.3.0&new-version=2.3.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
    - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    
    </details>
    dependabot[bot] authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    d20b7e8 View commit details
    Browse the repository at this point in the history
  5. [ci] Enable legacy Android emulator tests (#5190)

    Enables the new legacy emulator targets.
    
    Fixes flutter/flutter#130010
    stuartmorgan-g authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    f751ffb View commit details
    Browse the repository at this point in the history
Loading