-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Comparing changes
Open a pull request
base repository: flutter/packages
base: 05bf1d482dd9
head repository: flutter/packages
compare: bb00d34a4280
- 8 commits
- 132 files changed
- 4 contributors
Commits on Oct 4, 2024
-
[google_maps_flutter_platform_interface] Convert
PatternItem
and `C……ap` to typesafe structures. (#7703) Convert `PatternItem` and `Cap` from JSON wrappers to typesafe classes. flutter/flutter#155121 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [ ] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I [linked to at least one issue that this PR fixes] in the description above. - [x] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [x] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes]. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [CLA]: https://cla.developers.google.com/ [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md [linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [pub versioning philosophy]: https://dart.dev/tools/pub/versioning [exempt from version changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version [following repository CHANGELOG style]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style [exempt from CHANGELOG changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog [test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
Configuration menu - View commit details
-
Copy full SHA for 6ec1b43 - Browse repository at this point
Copy the full SHA 6ec1b43View commit details -
[google_maps_flutter_platform_interface] Convert
BitmapDescriptor
t……o typesafe subclasses (#7699) `BitmapDescriptor` is currently just a wrapper around JSON, with the exception of two of its subclasses. This converts all cases to typesafe structures without breaking the current API. Part of flutter/flutter#155122 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [ ] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I [linked to at least one issue that this PR fixes] in the description above. - [x] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [x] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes]. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [CLA]: https://cla.developers.google.com/ [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md [linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [pub versioning philosophy]: https://dart.dev/tools/pub/versioning [exempt from version changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version [following repository CHANGELOG style]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style [exempt from CHANGELOG changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog [test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
Configuration menu - View commit details
-
Copy full SHA for e28f004 - Browse repository at this point
Copy the full SHA e28f004View commit details -
[go_router] Added missing implementation for the routerNeglect parame…
…ter in GoRouter (#7752) The `GoRouter` constructor parameter `routerNeglect` currently has no effect. This PR provides an implementation for this parameter, in line with the original implementation, i.e. _"This will suppress history for all navigation made using go_router"_. *List which issues are fixed by this PR. You must list at least one issue.* * flutter/flutter#119398
Configuration menu - View commit details
-
Copy full SHA for f142461 - Browse repository at this point
Copy the full SHA f142461View commit details -
[video_player] Update Pigeon for non-nullable generics (#7790)
Updates the Pigeon definition to uses non-nullable generics now that it's possible. In practice for this plugin it's currently a no-op: the only affected collection is passed from Dart to native, on the Dart side the source was already a `Map<String, String>`, and on the native side we are using languages without nullability support in generics (Java and Obj-C). However, doing this now eliminates tech debt, and will avoid problems if/when the native side switches to Kotlin/Swift. On iOS, also removes a class that was accidentally left, unused, in the Pigeon definition file after an earlier update to that file. Current versions of Pigeon would generate that class even though it's not used, so removing it from the definition avoids changes to the generated code that would otherwise have been caused by the update. Part of flutter/flutter#155891
Configuration menu - View commit details
-
Copy full SHA for aa741d1 - Browse repository at this point
Copy the full SHA aa741d1View commit details
Commits on Oct 5, 2024
-
[various] Update Java compatibility version to 11 (#7795)
Now that `stable` requires AGP 7.0, which in turn requires Java 11+, we should be able to set our compatibility version to 11 (setting the min Flutter SDK version to current stable). Also removes the gradle conditionals for setting namespace (and the repo tool checks that it is present), as that was only needed for AGP 4.1 compatibility. Part of flutter/flutter#156111
Configuration menu - View commit details
-
Copy full SHA for 4afc383 - Browse repository at this point
Copy the full SHA 4afc383View commit details
Commits on Oct 7, 2024
-
[rfw] Increase tolerance for material widget tests (#7148)
This PR introduces a tolerance for rfw material widget tests to fix the golden test error in flutter/flutter#151611. Part of a fix for flutter/flutter#151659.
Configuration menu - View commit details
-
Copy full SHA for 3890cee - Browse repository at this point
Copy the full SHA 3890ceeView commit details -
[path_provider] Update Android Pigeon for non-nullable generics (#7783)
Removes workarounds for previous lack of non-nullable generics support. There are no native code changes because in practice we already didn't want nullable values in the collection, we just couldn't express it formally. Part of flutter/flutter#155891
Configuration menu - View commit details
-
Copy full SHA for e784c3e - Browse repository at this point
Copy the full SHA e784c3eView commit details -
[google_sign_in] Update Pigeon for non-nullable generics (#7785)
Updates the Pigeon definition to uses non-nullable generics now that it's possible. In practice for this plugin it's currently a no-op: the only affected collection is passed from Dart to native, on the Dart side the source was already a `List<String>`, and on the native side we are using languages without nullability support in generics (Java and Obj-C). However, to do this now eliminates tech debt, and will avoid problems if/when the native side switches to Kotlin/Swift. The Android implementation required some non-trivial changes to adapt to an earlier Pigeon change that we hadn't picked up yet, which was the change from `Result<Void>` (which turned out to be incompatible with Kotlin) to the separate `VoidResult` class. Part of flutter/flutter#155891
Configuration menu - View commit details
-
Copy full SHA for bb00d34 - Browse repository at this point
Copy the full SHA bb00d34View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 05bf1d482dd9...bb00d34a4280