You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We plan to export the `internal` attribute from `package:flutter/foundation.dart`.
Currently, `go_router` has files that import both `package:meta/meta.dart` and `package:flutter/foundation.dart`. This causes [lint failures](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8712222978061136193/+/u/run_test.dart_for_flutter_plugins_shard_and_subshard_analyze/stdout) when `foundation` exports `internal`:
```
info - lib/src/match.dart:12:8 - The import of 'package:meta/meta.dart' is unnecessary because all of the used elements are also provided by the import of 'package:flutter/foundation.dart'. Try removing the import directive. - unnecessary_import
info - lib/src/route.dart:10:8 - The import of 'package:meta/meta.dart' is unnecessary because all of the used elements are also provided by the import of 'package:flutter/foundation.dart'. Try removing the import directive. - unnecessary_import
```
This updates go_router to use a library prefix for `package:meta` in affected files to make the lints happy.
This change is a refactoring and does not affect semantics and is exempt from the test, version change, and CHANGELOG policies.
Part of flutter/flutter#167668
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
0 commit comments