Skip to content

Commit a4d8c39

Browse files
[pigeon] Split CI and developer test scripts (#3076)
* Split into two files with no changes * Adjust to fix compilation * Duplicate run_tests to test with no changes * Rework run_tests.dart * Extract sharable code * Make test.dart run every supported test * Update all docs * Update for changes in base PR * Analysis, missed tests * Move custom-test to heavy workload due to OOM * Re-merge Cirrus configuration Co-authored-by: Tarrin Neal <tarrinneal@gmail.com>
1 parent 14fc7a8 commit a4d8c39

File tree

9 files changed

+674
-547
lines changed

9 files changed

+674
-547
lines changed

.cirrus.yml

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -183,15 +183,6 @@ task:
183183
env:
184184
CIRRUS_CLONE_SUBMODULES: true
185185
script: ./script/tool_runner.sh update-excerpts --fail-on-change
186-
- name: linux-custom_package_tests
187-
env:
188-
PATH: $PATH:/usr/local/bin
189-
matrix:
190-
CHANNEL: "master"
191-
CHANNEL: "stable"
192-
<< : *INSTALL_CHROME_LINUX
193-
local_tests_script:
194-
- ./script/tool_runner.sh custom-test
195186
### Web tasks ###
196187
- name: web-build_all_packages
197188
env:
@@ -237,6 +228,16 @@ task:
237228
cpu: 4
238229
memory: 16G
239230
matrix:
231+
### Platform-agnostic tasks ###
232+
- name: linux-custom_package_tests
233+
env:
234+
PATH: $PATH:/usr/local/bin
235+
matrix:
236+
CHANNEL: "master"
237+
CHANNEL: "stable"
238+
<< : *INSTALL_CHROME_LINUX
239+
local_tests_script:
240+
- ./script/tool_runner.sh custom-test
240241
### Android tasks ###
241242
- name: android-platform_tests
242243
# Don't run full platform tests on both channels in pre-submit.

packages/pigeon/CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ generators with that AST.
3535
## Testing Overview
3636

3737
Pigeon has 3 types of tests, you'll find them all in
38-
[run_tests.dart](./tool/run_tests.dart).
38+
[test.dart](./tool/test.dart).
3939

4040
* Unit tests - These are the fastest tests that are just typical unit tests,
4141
they may be generating code and checking it against a regular expression to

packages/pigeon/platform_tests/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
# Native Pigeon Tests
22

33
This directory contains native test harnesses for native and end-to-end tests
4-
of Pigeon-generated code. The [test script](../tool/run_tests.dart) generates
4+
of Pigeon-generated code. The [test script](../tool/test.dart) generates
55
native code from [pigeons/](../pigeons/) into the native test scaffolding, and
66
then drives the tests there.
77

8-
To run these tests, use [`run_tests.dart`](../tool/run_tests.dart).
8+
To run these tests, use [`test.dart`](../tool/test.dart).
99

1010
Alternately, if you are running them directly (e.g., from within a platform
1111
IDE), you can use [`generate.dart`](../tool/generate.dart) to generate the

packages/pigeon/platform_tests/alternate_language_test_plugin/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@
33
Tests for languages not covered by `test_plugin`.
44
See [the `platform_tests` README](../README.md) for details.
55

6-
To run these tests, use [`run_tests.dart`](../tool/run_tests.dart)
6+
To run these tests, use [`test.dart`](../tool/test.dart)

packages/pigeon/platform_tests/flutter_null_safe_unit_tests/lib/.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# TODO(stuartmorgan) Remove this file when these are no longer generated;
2-
# see the TODO in _runFlutterUnitTests in run_tests.dart
2+
# see the TODO in _runFlutterUnitTests in test_suites.dart
33
async_handlers.gen.dart
44
host2flutter.gen.dart
55
list.gen.dart

0 commit comments

Comments
 (0)