From 4e796783a265491d1f3d575a3953f5bee043895a Mon Sep 17 00:00:00 2001 From: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com> Date: Wed, 8 May 2024 22:17:32 -0400 Subject: [PATCH] [pointer_interceptor] Remove `implements` from app-facing package (#6699) Dart unit tests started failing for `pointer_interceptor` due to the `implements` tag in the app facing package. This plugin is federated for ios and web, so it looks like the error message is valid. ``` Plugin pointer_interceptor:ios provides an implementation for pointer_interceptor_platform_interface and also references a default implementation for pointer_interceptor_ios, which is currently not supported. Ask the maintainers of pointer_interceptor to either remove the implementation via `implements: pointer_interceptor_platform_interface` or avoid referencing a default implementation via `platforms: ios: default_package: pointer_interceptor_ios`. 00:00 +0 -1: loading /b/s/w/ir/x/w/packages/packages/pointer_interceptor/pointer_interceptor/test/tests_exist_elsewhere_test.dart [E] Error: Please resolve the plugin pubspec errors package:flutter_tools/src/base/common.dart 10:3 throwToolExit package:flutter_tools/src/flutter_plugins.dart 1214:5 resolvePlatformImplementation package:flutter_tools/src/flutter_plugins.dart 1418:55 generateMainDartWithPluginRegistrant ===== asynchronous gap =========================== package:flutter_tools/src/test/test_compiler.dart 163:9 TestCompiler._onCompilationRequest TimeoutException after 0:12:00.000000: Test timed out after 12 minutes. package:test_api/src/backend/invoker.dart 338:28 Invoker._handleError. dart:async/zone.dart 1391:47 _rootRun dart:async/zone.dart 1301:19 _CustomZone.run package:test_api/src/backend/invoker.dart 336:10 Invoker._handleError package:test_api/src/backend/invoker.dart 291:9 Invoker.heartbeat.. dart:async/zone.dart 1399:13 _rootRun dart:async/zone.dart 1301:19 _CustomZone.run package:test_api/src/backend/invoker.dart 290:38 Invoker.heartbeat. dart:async-patch/timer_patch.dart 18:15 Timer._createTimer. dart:isolate-patch/timer_impl.dart 398:19 _Timer._runTimers dart:isolate-patch/timer_impl.dart 429:5 _Timer._handleMessage dart:isolate-patch/isolate_patch.dart 184:12 _RawReceivePort._handleMessage To run this test again: /b/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dart test ``` This removes the tag and does a manual roll. --- .ci/flutter_master.version | 2 +- packages/pointer_interceptor/pointer_interceptor/CHANGELOG.md | 3 ++- packages/pointer_interceptor/pointer_interceptor/pubspec.yaml | 3 +-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.ci/flutter_master.version b/.ci/flutter_master.version index c4d3ed6b11b3..2f394b7f2afa 100644 --- a/.ci/flutter_master.version +++ b/.ci/flutter_master.version @@ -1 +1 @@ -7920a52dd5680651118312f9be0600797ff2257e +00f40667c16ae3f7cf0c567fe4a43c0a59046951 diff --git a/packages/pointer_interceptor/pointer_interceptor/CHANGELOG.md b/packages/pointer_interceptor/pointer_interceptor/CHANGELOG.md index a822866f9105..cfc10d290ace 100644 --- a/packages/pointer_interceptor/pointer_interceptor/CHANGELOG.md +++ b/packages/pointer_interceptor/pointer_interceptor/CHANGELOG.md @@ -1,8 +1,9 @@ -## NEXT +## 0.10.1+1 * Updates support matrix in README to indicate that iOS 11 is no longer supported. * Clients on versions of Flutter that still support iOS 11 can continue to use this package with iOS 11, but will not receive any further updates to the iOS implementation. +* Removes invalid `implements` tag in pubspec. ## 0.10.1 diff --git a/packages/pointer_interceptor/pointer_interceptor/pubspec.yaml b/packages/pointer_interceptor/pointer_interceptor/pubspec.yaml index 5846d73014f3..e79d06108475 100644 --- a/packages/pointer_interceptor/pointer_interceptor/pubspec.yaml +++ b/packages/pointer_interceptor/pointer_interceptor/pubspec.yaml @@ -2,7 +2,7 @@ name: pointer_interceptor description: A widget to prevent clicks from being swallowed by underlying HtmlElementViews on the web. repository: https://github.com/flutter/packages/tree/main/packages/pointer_interceptor/pointer_interceptor issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+pointer_interceptor%22 -version: 0.10.1 +version: 0.10.1+1 environment: sdk: ">=3.1.0 <4.0.0" @@ -10,7 +10,6 @@ environment: flutter: plugin: - implements: pointer_interceptor_platform_interface platforms: web: default_package: pointer_interceptor_web