Skip to content

Commit 228a011

Browse files
authored
Delete some verbose vm service logging (#162709)
Deletes some logging that should no longer be needed. <details> <summary> Pre-launch checklist </summary> - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. </details> <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent cb40f1b commit 228a011

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

packages/flutter_tools/lib/src/vmservice.dart

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -562,21 +562,6 @@ class FlutterVmService {
562562
}
563563
}
564564

565-
// TODO(andrewkolos): this is to assist in troubleshooting
566-
// https://github.com/flutter/flutter/issues/152220 and should be reverted
567-
// once this issue is resolved.
568-
final StreamSubscription<String> onReceiveSubscription = service.onReceive.listen((
569-
String message,
570-
) {
571-
globals.logger.printTrace('runInView VM service onReceive listener received "$message"');
572-
final dynamic messageAsJson = jsonDecode(message);
573-
// ignore: avoid_dynamic_calls -- Temporary code.
574-
final dynamic messageKind = messageAsJson['params']?['event']?['kind'];
575-
if (messageKind == 'IsolateRunnable') {
576-
globals.logger.printTrace('Received IsolateRunnable event from onReceive.');
577-
}
578-
});
579-
580565
final Future<void> onRunnable = service.onIsolateEvent.firstWhere((vm_service.Event event) {
581566
return event.kind == vm_service.EventKind.kIsolateRunnable;
582567
});
@@ -589,7 +574,6 @@ class FlutterVmService {
589574
},
590575
);
591576
await onRunnable;
592-
await onReceiveSubscription.cancel();
593577
}
594578

595579
Future<String> flutterDebugDumpApp({required String isolateId}) async {

0 commit comments

Comments
 (0)