[camera_android_camerax] Modify plugin to assume mp4 format for captured videos (#10273)

Changes the plugin to assume that recorded videos come in the mp4 format instead of using .temp, which we originally set because we aren't 100% sure of the file format.

This is an executive decision I want to make because:

1. The CameraX team directly told me this is safe and they have not experienced any issues with this technique (see flutter/flutter#148335 (comment) for the details on our discussion).
2. If for some reason we do experience issues, we can build a case for getting the container format exposed via the CameraX library (the team suggested this, as well).

Fixes flutter/flutter#148335.

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

Author: camsim99

packages/camera/camera_android_camerax/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.6.24
+
+* Change plugin to assume mp4 format for capture videos.
+
 ## 0.6.23+5
 
 * Fixes `IllegalArgumentException` that could occur during image streaming when using NV21.

packages/camera/camera_android_camerax/lib/src/android_camera_camerax.dart

@@ -1181,7 +1181,7 @@ class AndroidCameraCameraX extends CameraPlatform {
 
     videoOutputPath = await systemServicesManager.getTempFilePath(
       videoPrefix,
-      '.temp',
+      '.mp4',
     );
     pendingRecording = await recorder!.prepareRecording(videoOutputPath!);
 

packages/camera/camera_android_camerax/pubspec.yaml

@@ -2,7 +2,7 @@ name: camera_android_camerax
 description: Android implementation of the camera plugin using the CameraX library.
 repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android_camerax
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
-version: 0.6.23+5
+version: 0.6.24
 
 environment:
   sdk: ^3.9.0

packages/camera/camera_android_camerax/test/android_camera_camerax_test.dart

@@ -3311,7 +3311,7 @@ void main() {
         camera.captureOrientationLocked = true;
 
         // Tell plugin to create detached Observer when camera info updated.
-        const String outputPath = '/temp/REC123.temp';
+        const String outputPath = '/temp/REC123.mp4';
         camera.proxy = CameraXProxy(
           newObserver:
               <T>({
@@ -3350,7 +3350,7 @@ void main() {
                 when(
                   mockSystemServicesManager.getTempFilePath(
                     camera.videoPrefix,
-                    '.temp',
+                    '.mp4',
                   ),
                 ).thenAnswer((_) async => outputPath);
                 return mockSystemServicesManager;
@@ -3480,7 +3480,7 @@ void main() {
         camera.captureOrientationLocked = true;
 
         // Tell plugin to create detached Observer when camera info updated.
-        const String outputPath = '/temp/REC123.temp';
+        const String outputPath = '/temp/REC123.mp4';
         camera.proxy = CameraXProxy(
           newObserver:
               <T>({
@@ -3519,7 +3519,7 @@ void main() {
                 when(
                   mockSystemServicesManager.getTempFilePath(
                     camera.videoPrefix,
-                    '.temp',
+                    '.mp4',
                   ),
                 ).thenAnswer((_) async => outputPath);
                 return mockSystemServicesManager;
@@ -3607,7 +3607,7 @@ void main() {
         verify(
           camera.systemServicesManager.getTempFilePath(
             camera.videoPrefix,
-            '.temp',
+            '.mp4',
           ),
         ).called(1);
         verifyNoMoreInteractions(camera.systemServicesManager);
@@ -3650,7 +3650,7 @@ void main() {
         camera.captureOrientationLocked = true;
 
         // Tell plugin to create detached Analyzer for testing.
-        const String outputPath = '/temp/REC123.temp';
+        const String outputPath = '/temp/REC123.mp4';
         camera.proxy = CameraXProxy(
           newObserver:
               <T>({
@@ -3689,7 +3689,7 @@ void main() {
                 when(
                   mockSystemServicesManager.getTempFilePath(
                     camera.videoPrefix,
-                    '.temp',
+                    '.mp4',
                   ),
                 ).thenAnswer((_) async => outputPath);
                 return mockSystemServicesManager;
@@ -3807,7 +3807,7 @@ void main() {
         camera.enableRecordingAudio = false;
 
         // Tell plugin to mock call to get current video orientation and mock Camera2CameraInfo retrieval.
-        const String outputPath = '/temp/REC123.temp';
+        const String outputPath = '/temp/REC123.mp4';
         camera.proxy = CameraXProxy(
           newObserver:
               <T>({
@@ -3848,7 +3848,7 @@ void main() {
                 when(
                   mockSystemServicesManager.getTempFilePath(
                     camera.videoPrefix,
-                    '.temp',
+                    '.mp4',
                   ),
                 ).thenAnswer((_) async => outputPath);
                 return mockSystemServicesManager;
@@ -4354,7 +4354,7 @@ void main() {
               when(
                 mockSystemServicesManager.getTempFilePath(
                   camera.videoPrefix,
-                  '.temp',
+                  '.mp4',
                 ),
               ).thenAnswer((_) async => outputPath);
               return mockSystemServicesManager;
@@ -4696,7 +4696,7 @@ void main() {
               when(
                 mockSystemServicesManager.getTempFilePath(
                   camera.videoPrefix,
-                  '.temp',
+                  '.mp4',
                 ),
               ).thenAnswer((_) async => outputPath);
               return mockSystemServicesManager;
@@ -7600,7 +7600,7 @@ void main() {
       camera.captureOrientationLocked = true;
 
       // Tell plugin to create detached Observer when camera info updated.
-      const String outputPath = '/temp/REC123.temp';
+      const String outputPath = '/temp/REC123.mp4';
       camera.proxy = CameraXProxy(
         newObserver:
             <T>({
@@ -7639,7 +7639,7 @@ void main() {
               when(
                 mockSystemServicesManager.getTempFilePath(
                   camera.videoPrefix,
-                  '.temp',
+                  '.mp4',
                 ),
               ).thenAnswer((_) async => outputPath);
               return mockSystemServicesManager;
@@ -7744,7 +7744,7 @@ void main() {
       camera.captureOrientationLocked = true;
 
       // Tell plugin to create detached Observer when camera info updated.
-      const String outputPath = '/temp/REC123.temp';
+      const String outputPath = '/temp/REC123.mp4';
       camera.proxy = CameraXProxy(
         newObserver:
             <T>({
@@ -7783,7 +7783,7 @@ void main() {
               when(
                 mockSystemServicesManager.getTempFilePath(
                   camera.videoPrefix,
-                  '.temp',
+                  '.mp4',
                 ),
               ).thenAnswer((_) async => outputPath);
               return mockSystemServicesManager;
@@ -7888,7 +7888,7 @@ void main() {
       camera.captureOrientationLocked = true;
 
       // Tell plugin to create detached Observer when camera info updated.
-      const String outputPath = '/temp/REC123.temp';
+      const String outputPath = '/temp/REC123.mp4';
       camera.proxy = CameraXProxy(
         newObserver:
             <T>({
@@ -7927,7 +7927,7 @@ void main() {
               when(
                 mockSystemServicesManager.getTempFilePath(
                   camera.videoPrefix,
-                  '.temp',
+                  '.mp4',
                 ),
               ).thenAnswer((_) async => outputPath);
               return mockSystemServicesManager;
@@ -8037,7 +8037,7 @@ void main() {
       camera.captureOrientationLocked = true;
 
       // Tell plugin to create detached Observer when camera info updated.
-      const String outputPath = '/temp/REC123.temp';
+      const String outputPath = '/temp/REC123.mp4';
       camera.proxy = CameraXProxy(
         newAnalyzer:
             ({
@@ -8091,7 +8091,7 @@ void main() {
               when(
                 mockSystemServicesManager.getTempFilePath(
                   camera.videoPrefix,
-                  '.temp',
+                  '.mp4',
                 ),
               ).thenAnswer((_) async => outputPath);
               return mockSystemServicesManager;
@@ -8205,7 +8205,7 @@ void main() {
       camera.captureOrientationLocked = true;
 
       // Tell plugin to create detached Observer when camera info updated.
-      const String outputPath = '/temp/REC123.temp';
+      const String outputPath = '/temp/REC123.mp4';
       camera.proxy = CameraXProxy(
         newAnalyzer:
             ({
@@ -8259,7 +8259,7 @@ void main() {
               when(
                 mockSystemServicesManager.getTempFilePath(
                   camera.videoPrefix,
-                  '.temp',
+                  '.mp4',
                 ),
               ).thenAnswer((_) async => outputPath);
               return mockSystemServicesManager;
@@ -8365,7 +8365,7 @@ void main() {
       camera.captureOrientationLocked = true;
 
       // Tell plugin to create detached Observer when camera info updated.
-      const String outputPath = '/temp/REC123.temp';
+      const String outputPath = '/temp/REC123.mp4';
       camera.proxy = CameraXProxy(
         newAnalyzer:
             ({
@@ -8419,7 +8419,7 @@ void main() {
               when(
                 mockSystemServicesManager.getTempFilePath(
                   camera.videoPrefix,
-                  '.temp',
+                  '.mp4',
                 ),
               ).thenAnswer((_) async => outputPath);
               return mockSystemServicesManager;