Skip to content

Add sweep gradient golden for CanvasKit #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2020
Merged

Add sweep gradient golden for CanvasKit #130

merged 1 commit into from
Dec 11, 2020

Conversation

@harryterkelsen
Copy link
Contributor

@harryterkelsen harryterkelsen commented Dec 11, 2020

Adds golden for test in this PR: flutter/engine#21677

yjbanov
yjbanov approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harryterkelsen harryterkelsen merged commit 5ae9ca5 into flutter:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harryterkelsen @yjbanov