Skip to content

Started generating the windows platform for macrobenchmarks - #190932

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
gaaclarke:shadow-text-benchmark-fix
Aug 12, 2026
Merged

Started generating the windows platform for macrobenchmarks#190932
auto-submit[bot] merged 1 commit into
flutter:masterfrom
gaaclarke:shadow-text-benchmark-fix

Conversation

@gaaclarke

@gaaclarke gaaclarke commented Aug 11, 2026

Copy link
Copy Markdown
Member

Fixes execution of the windows shadowed text benchmark.

Example failure: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8673758721855002449/+/u/run_windows_text_shadow_perf__timeline_summary/stdout

successful run: https://ci.chromium.org/ui/p/flutter/builders/staging.shadow/Windows%20windows_text_shadow_perf__timeline_summary/1/overview

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@github-actions github-actions Bot added the a: text input Entering text in a text field or keyboard related problems label Aug 11, 2026
@gaaclarke
gaaclarke marked this pull request as ready for review August 11, 2026 17:14
@gaaclarke
gaaclarke requested a review from b-luk August 11, 2026 17:14

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the createTextShadowPerfTest function in perf_tests.dart to accept an optional createPlatforms parameter, which is passed to the PerfTest constructor. Additionally, the Windows text shadow performance task is updated to pass ['windows'] as the createPlatforms argument. I have no feedback to provide.

@gaaclarke gaaclarke added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Aug 11, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Aug 11, 2026
Merged via the queue into flutter:master with commit 09e6c68 Aug 12, 2026
31 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: text input Entering text in a text field or keyboard related problems CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants