-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Remove an obsolete TODO in DataTable #180033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes an obsolete TODO comment from the DataTable widget. The TODO suggested conditionally wrapping a header cell label in an InkWell, but as the PR description explains, the InkWell is now always necessary for handling properties like overlayColor and mouseCursor, making the conditional wrapping logic unnecessary. The change is a straightforward code cleanup.
chunhtai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When the
InkWellwas added, it was used only for a gesture callback, and at that time the InkWell should only be added when the gesture callback was needed. Due to an issue, we couldn't swap out the child widget dynamically.Even though that the issue has been fixed, the
InkWellis considered mandatory since it is now used by two more properties. (Theoretically we can check if any of the 3 properties is needed to add thisInkWell, but I think that's too much.)Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.