Skip to content

Conversation

@shindonghwi
Copy link
Contributor

@shindonghwi shindonghwi commented Dec 15, 2025

Problem

When using platform views like Google Maps on Android, the console gets flooded with messages like:

E/FrameEvents(26685): updateAcquireFence: Did not find frame.
E/FrameEvents(26685): updateAcquireFence: Did not find frame.
E/FrameEvents(26685): updateAcquireFence: Did not find frame.
... (repeats many times)

This makes it hard to see actual errors and warnings in the console.

Cause

This is a HWUI bug in Android, not an actual error. The message doesn't indicate any problem with the application.

Fix

Add a regex filter to _filteredMessagees in AdbLogReader to suppress these messages, following the same pattern used for similar spam messages like SurfaceSyncer and ViewPostIme pointer.

Fixes

#104268

Pre-launch Checklist

When using platform views like Google Maps on Android, the console gets
flooded with "E/FrameEvents: updateAcquireFence: Did not find frame."
messages. This is a HWUI bug that doesn't indicate any actual problem
with the application.

This change adds a filter to suppress these messages, improving the
developer experience by keeping the console output clean and readable.

Fixes flutter#104268
@shindonghwi shindonghwi requested a review from a team as a code owner December 15, 2025 14:49
@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. team-android Owned by Android platform team labels Dec 15, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request filters out spammy FrameEvents/updateAcquireFence logs from adb logcat by adding a new regular expression to the AdbLogReader. This is a good fix for a known Android HWUI bug that clutters the console. The change is accompanied by a new test case to verify the filtering works as expected. I have one suggestion to make the regular expression more precise.

@reidbaker reidbaker requested a review from a team December 15, 2025 15:02
@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 16, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Dec 16, 2025
Merged via the queue into flutter:master with commit 2b61b85 Dec 16, 2025
141 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 16, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-android Owned by Android platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants