-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Filter out FrameEvents/updateAcquireFence log spam from adb logcat #179884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out FrameEvents/updateAcquireFence log spam from adb logcat #179884
Conversation
When using platform views like Google Maps on Android, the console gets flooded with "E/FrameEvents: updateAcquireFence: Did not find frame." messages. This is a HWUI bug that doesn't indicate any actual problem with the application. This change adds a filter to suppress these messages, improving the developer experience by keeping the console output clean and readable. Fixes flutter#104268
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request filters out spammy FrameEvents/updateAcquireFence logs from adb logcat by adding a new regular expression to the AdbLogReader. This is a good fix for a known Android HWUI bug that clutters the console. The change is accompanied by a new test case to verify the filtering works as expected. I have one suggestion to make the regular expression more precise.
Problem
When using platform views like Google Maps on Android, the console gets flooded with messages like:
This makes it hard to see actual errors and warnings in the console.
Cause
This is a HWUI bug in Android, not an actual error. The message doesn't indicate any problem with the application.
Fix
Add a regex filter to
_filteredMessageesinAdbLogReaderto suppress these messages, following the same pattern used for similar spam messages likeSurfaceSyncerandViewPostIme pointer.Fixes
#104268
Pre-launch Checklist
///).