ListTile fix MinIntrinsicHeight calculation

[RamonFarizel]

computeMinIntrinsicHeight was not taking into consideration the vertical padding.

Fix: #179377

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
• I signed the CLA.
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• I followed the breaking change policy and added Data Driven Fixes where supported.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[gemini-code-assist]

Code Review

This pull request fixes an issue in ListTile where computeMinIntrinsicHeight did not account for vertical padding. The change correctly adds this padding. A regression test is also included to prevent this issue from recurring. My review includes suggestions to simplify the implementation in list_tile.dart for better readability and to clean up unused parameters in the new test file.

[Piinks]

This LGTM! Thank you for contributing! 💙

[victorsanni]

Nit: I don't know that this variable needs to be defined, it seems obvious to me that padding will need to be applied both above and below the title + subtitle block.

[victorsanni]

Took a look at the google testing failures, there were two failures. One seemed trivial to me, just a slight leading icon vertical position change. The other one was a little less so, it wrapped a ListTile inside a SingleChildScrollView inside an IntrinsicHeight. Before this PR the ListTile scrolled but with this PR it is fully extended. Both changes LGTM.

[RamonFarizel]

I just wanted to confirm, but does it require any action on my side?

Took a look at the google testing failures, there were two failures. One seemed trivial to me, just a slight leading icon vertical position change. The other one was a little less so, it wrapped a ListTile inside a SingleChildScrollView inside an IntrinsicHeight. Before this PR the ListTile scrolled but with this PR it is fully extended. Both changes LGTM.