Skip to content

Prefer .of over .from #170750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

Prefer .of over .from #170750

merged 1 commit into from
Jun 17, 2025

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Jun 17, 2025 •
edited
Loading

Often faster in cases where the types match

There SHOULD be a lint: dart-lang/sdk#58359

@kevmoo
Prefer .of over .from
6cd1fd5 
Often faster in cases where the types match
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository f: routes Navigator, Router, and related APIs. labels Jun 17, 2025
@kevmoo kevmoo requested a review from chunhtai June 17, 2025 17:22
chunhtai
chunhtai approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is there a lint for this?

@kevmoo
Copy link
Contributor Author

kevmoo commented Jun 17, 2025

LGTM, is there a lint for this?

I wish! I swear I've been in threads about it. Let me dig...

@kevmoo
Copy link
Contributor Author

kevmoo commented Jun 17, 2025

dart-lang/sdk#58359 is pending

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 17, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 17, 2025
Merged via the queue into flutter:master with commit 55f5aed Jun 17, 2025
70 of 71 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 17, 2025
@kevmoo kevmoo deleted the of_over_from branch June 17, 2025 19:19
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
55f5aed6e Prefer .of over .from (flutter/flutter#170750)
ce9f857
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
55f5aed6e Prefer .of over .from (flutter/flutter#170750)
53f0e7f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
55f5aed6e Prefer .of over .from (flutter/flutter#170750)
eb21f80
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
55f5aed6e Prefer .of over .from (flutter/flutter#170750)
8acea45
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
55f5aed6e Prefer .of over .from (flutter/flutter#170750)
e3920ff
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
55f5aed6e Prefer .of over .from (flutter/flutter#170750)
2631710
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
55f5aed6e Prefer .of over .from (flutter/flutter#170750)
2ccd0cd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
55f5aed6e Prefer .of over .from (flutter/flutter#170750)
70f6cf2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
55f5aed6e Prefer .of over .from (flutter/flutter#170750)
70b59d2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 19, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
55f5aed6e Prefer .of over .from (flutter/flutter#170750)
ad48ab1
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
Roll Flutter from 8303a96a0a99 to 85a9b4f38906 (93 revisions) (#9457)
0ec4053 
Roll Flutter from 8303a96a0a99 to 85a9b4f38906 (93 revisions)

flutter/flutter@8303a96...85a9b4f

2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from af242598f14d to 794936b23812 (2 revisions) (flutter/flutter#170875)
2025-06-19 gourabkumarsi@google.com Drop support for 21/22 Lollipop (flutter/flutter#170748)
2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from 6020126c10e8 to bce9abe03175 (1 revision) (flutter/flutter#170872)
2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from df97f7f407db to af242598f14d (4 revisions) (flutter/flutter#170867)
2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from 1d8f7ebd23cc to df97f7f407db (5 revisions) (flutter/flutter#170864)
2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from 4ab716b09e9d to 6020126c10e8 (1 revision) (flutter/flutter#170862)
2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from 291d41414fa7 to 1d8f7ebd23cc (2 revisions) (flutter/flutter#170857)
2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from b32559bca3cc to 4ab716b09e9d (9 revisions) (flutter/flutter#170855)
2025-06-19 jessy.yameogo@gmail.com remove --start-paused flag by default and set useDwdsWebSocketConnect… (flutter/flutter#170612)
2025-06-18 matanlurey@users.noreply.github.com Engine builders no longer require `is_fusion` (flutter/flutter#170849)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 5f110d5f48a3 to 291d41414fa7 (2 revisions) (flutter/flutter#170836)
2025-06-18 robert.ancell@canonical.com Use a shared vertex buffer for rendering layers. (flutter/flutter#170717)
2025-06-18 30870216+gaaclarke@users.noreply.github.com fixes deeplinking in uiscenedelegate migrated projects (flutter/flutter#170452)
2025-06-18 jonahwilliams@google.com [Impeller] fix array uniforms on GLES backend. (flutter/flutter#170710)
2025-06-18 chinmaygarde@google.com [Impeller] Update README to add section about custom embedders. (flutter/flutter#170077)
2025-06-18 jason-simmons@users.noreply.github.com Escape the forbidden strings in the regex used to check test command output (flutter/flutter#170702)
2025-06-18 30870216+gaaclarke@users.noreply.github.com License cpp jun16 (flutter/flutter#170716)
2025-06-18 chinmaygarde@google.com Work around newer compilers requiring the satisfaction of three-way comparison of EncodableValue. (flutter/flutter#170822)
2025-06-18 45459898+RamonFarizel@users.noreply.github.com Update didUnmountRenderObject text description (flutter/flutter#169628)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 297dbc32a6c7 to 5f110d5f48a3 (2 revisions) (flutter/flutter#170821)
2025-06-18 matanlurey@users.noreply.github.com Add an initial "Using feature flags" doc for the team. (flutter/flutter#170767)
2025-06-18 34465683+rkishan516@users.noreply.github.com Feat: Add mouse cursor for CupertinoDialogAction (flutter/flutter#169051)
2025-06-18 matanlurey@users.noreply.github.com Update `Engine-artifacts.md` to reflect flutter/cocoon/4785 (flutter/flutter#170751)
2025-06-18 alex.medinsh@gmail.com `CupertinoPicker` new onChanged behaviour (flutter/flutter#170202)
2025-06-18 pateltirth454@gmail.com Rename `entryPointBaseUrl` to `entrypointBaseUrl` (flutter/flutter#170166)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 1cb13a21b547 to 297dbc32a6c7 (4 revisions) (flutter/flutter#170809)
2025-06-18 engine-flutter-autoroll@skia.org Roll Packages from 25d4fa4 to 715a0a5 (2 revisions) (flutter/flutter#170808)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 0a106c038cd0 to 1cb13a21b547 (1 revision) (flutter/flutter#170801)
2025-06-18 derekx@google.com Add `--profile-microtasks` switch (flutter/flutter#170690)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from ff7fffa5dac5 to 0a106c038cd0 (3 revisions) (flutter/flutter#170795)
2025-06-18 87239766+thakaredipali@users.noreply.github.com Add example for CupertinoExpansionTile transition modes (flutter/flutter#170335)
2025-06-18 stanleycocoa@gmail.com feat: Add radius to DividerThemeData. (flutter/flutter#169739)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 75af9450b121 to ff7fffa5dac5 (3 revisions) (flutter/flutter#170772)
2025-06-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "add run_gradle_lock_files_check.dart for new PR's that modify gradle files (#169245)" (flutter/flutter#170770)
2025-06-17 30870216+gaaclarke@users.noreply.github.com Started bridging the scene delegate to the lifecycle delegate for shortcuts (flutter/flutter#170180)
2025-06-17 jonahwilliams@google.com [ui] npot display_list allocation. (flutter/flutter#170447)
2025-06-17 kevmoo@users.noreply.github.com Prefer .of over .from (flutter/flutter#170750)
2025-06-17 47866232+chunhtai@users.noreply.github.com Fix RawGestureDetector semantics (flutter/flutter#170549)
2025-06-17 runar@socialscreen.no Use correct type for filterIdentifier (flutter/flutter#170343)
2025-06-17 matanlurey@users.noreply.github.com Remove and inline `license_header.txt` (flutter/flutter#170475)
2025-06-17 muhatashim@google.com add run_gradle_lock_files_check.dart for new PR's that modify gradle files (flutter/flutter#169245)
2025-06-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 4fad61257b29 to b32559bca3cc (3 revisions) (flutter/flutter#170746)
2025-06-17 kevinjchisholm@google.com [release] Sync stable changelog to master (flutter/flutter#170691)
2025-06-17 engine-flutter-autoroll@skia.org Roll Packages from 03a6abb to 25d4fa4 (5 revisions) (flutter/flutter#170743)
2025-06-17 bkonyi@google.com [ Widget Preview ] Remove support for synthetic package:flutter_gen (flutter/flutter#170602)
2025-06-17 engine-flutter-autoroll@skia.org Roll Skia from 8879db3b3319 to 75af9450b121 (4 revisions) (flutter/flutter#170739)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevmoo @chunhtai