Fix default minimumSize in dropdownMenu when maximumSize is null #169438

EdwynZN · 2025-05-25T18:22:05Z

Previous change in DropDownMenu #162380 forced the menu width to be constrained between the width or anchorWidth and the maximumSize width menuStyle, but giving a minimum of zero when maximumSize was not enforced or null. This prevents width or anchorWidth to be used at all as the minimum will be zero always if maximumSize is null

Now this sets the default value back to width or anchorWidth if maximumSize is null, keeping consistency of the previous configuration while using the fix of maximumSize when provided.

Fixes #170970

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

QuncCccccc

Thanks for your contribution. Are there any issue that this PR is fixing? Attaching an issue link would be very helpful to track why we created this PR. Could you also help fix the failed linux_analyzer test?

QuncCccccc · 2025-06-19T00:49:53Z

packages/flutter/lib/src/material/dropdown_menu.dart

+          final double effectiveWidth = effectiveMaximumWidth == null
+            ? widget.width!
+            : math.min(widget.width!, effectiveMaximumWidth);
+          return Size(effectiveWidth, 0.0);


Seems this is same as Size(math.min(widget.width!, effectiveMaximumWidth ?? widget.width), 0.0);?

Yeah I think it can be reduced to one line

QuncCccccc · 2025-06-19T00:50:48Z

packages/flutter/lib/src/material/dropdown_menu.dart

+          final double effectiveWidth = effectiveMaximumWidth == null
+            ? anchorWidth
+            : math.min(anchorWidth, effectiveMaximumWidth);
+          return Size(effectiveWidth, 0.0);


And this is the same as Size(math.min(anchorWidth, effectiveMaximumWidth ?? anchorWidth), 0.0);

EdwynZN

I have created an issue for this: #170970

EdwynZN · 2025-06-21T18:30:25Z

packages/flutter/lib/src/material/dropdown_menu.dart

+          final double effectiveWidth = effectiveMaximumWidth == null
+            ? widget.width!
+            : math.min(widget.width!, effectiveMaximumWidth);
+          return Size(effectiveWidth, 0.0);


Yeah I think it can be reduced to one line

QuncCccccc

LGTM! Thanks for your contribution! After fixing the comments below, I'll ask for a second review:)!

packages/flutter/lib/src/material/dropdown_menu.dart

QuncCccccc · 2025-06-24T21:52:46Z

packages/flutter/test/material/dropdown_menu_test.dart

+
+    expect(tester.takeException(), isNull);
+    expect(tester.getSize(findMenuItemButton(menuChildren.first.label)).width, 200.0);
+


Linux also shows a format error, removing this empty line should fix it.

Suggested change

I tried this test locally and looks like it can pass without the PR change. It is because it's updating the existing test and previously, the menu hasn't been closed so the width is probably still the value from the code above. Can we create a new test for this part of testing?

Any updates here:)?

Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>

packages/flutter/test/material/dropdown_menu_test.dart

…f DropdownMenu (width or anchor) when no maximumSize

QuncCccccc

Thank you for your contribution! Sorry I missed your update. Seems the linux_analyzer shows up some format issues:)

packages/flutter/test/material/dropdown_menu_test.dart

QuncCccccc · 2025-07-23T22:57:50Z

packages/flutter/test/material/dropdown_menu_test.dart

+    tester.view.physicalSize = const Size(390, 810);
+    tester.view.devicePixelRatio = 1.0;


just nit: No need to specify this. The default width should be 800.0

packages/flutter/test/material/dropdown_menu_test.dart

Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>

QuncCccccc · 2025-07-28T18:05:32Z

There are some format errors in Linux analyze. We also need to fix it.

EdwynZN · 2025-08-10T18:19:46Z

@QuncCccccc All format errors has been fixed, only waiting for approve and tree fix

QuncCccccc

LGTM. Just gave 2 more nits to make the test comments more accurate.

packages/flutter/test/material/dropdown_menu_test.dart

justinmc

LGTM 👍

justinmc · 2025-08-11T19:14:48Z

packages/flutter/test/material/dropdown_menu_test.dart

+    await tester.tap(find.byType(TextField));
+    await tester.pumpAndSettle();
+
+    expect(tester.takeException(), isNull);


Did this used to fail before this PR? If so maybe add a comment saying that this is a regression test for #170970.

Not failing as this case was not properly tested

Oh I think we can remove this block of test because the test below is just testing same thing.

This previous test is different from the one below in that the menu items here are long text whereas the one below use a small label (to show how both try to expand/constraint to the defined size of 200)

Seems menuChildren only contain entries like "item 0", "item 1" and etc. They seem to have similar width as the shortLabel below.

Ok so should we delete this or the new test (below)?

I think we can remove this here:)

justinmc · 2025-08-11T19:15:02Z

packages/flutter/test/material/dropdown_menu_test.dart

+      await tester.tap(find.byType(TextField));
+      await tester.pumpAndSettle();
+
+      expect(tester.takeException(), isNull);


Same question here.

I think we can remove this line as well since even without this PR, the test will not throw exception.

Also this line, then we are ready to move on landing it!

Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>

…tter#169438)  Previous change in `DropDownMenu` flutter#162380 forced the menu width to be constrained between the width or anchorWidth and the maximumSize width menuStyle, but giving a minimum of zero when maximumSize was not enforced or null. This prevents width or anchorWidth to be used at all as the minimum will be zero always if maximumSize is null Now this sets the default value back to width or anchorWidth if maximumSize is null, keeping consistency of the previous configuration while using the fix of maximumSize when provided. Fixes flutter#170970 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>

… null (flutter/flutter#169438)

flutter/flutter@f4334d2...52af7a5 2025-08-15 engine-flutter-autoroll@skia.org Roll Packages from 09533b7 to 5c52c55 (6 revisions) (flutter/flutter#173854) 2025-08-15 engine-flutter-autoroll@skia.org Roll Skia from 46ec77ae3954 to 5654ac32ede0 (1 revision) (flutter/flutter#173848) 2025-08-15 engine-flutter-autoroll@skia.org Roll Skia from 162f47d6b6bd to 46ec77ae3954 (2 revisions) (flutter/flutter#173833) 2025-08-15 engine-flutter-autoroll@skia.org Roll Dart SDK from c7faab270f27 to cc008dc8e7aa (2 revisions) (flutter/flutter#173826) 2025-08-15 engine-flutter-autoroll@skia.org Roll Skia from ad5d04000101 to 162f47d6b6bd (5 revisions) (flutter/flutter#173822) 2025-08-15 jason-simmons@users.noreply.github.com Update the RBE configuration for the recent Clang update (flutter/flutter#173803) 2025-08-15 matanlurey@users.noreply.github.com Stop writing legacy `FLUTTER_ROOT/version` file (by default?) (flutter/flutter#172793) 2025-08-15 matanlurey@users.noreply.github.com Remove `luci_flags.parallel_download_builds` and friends (flutter/flutter#173799) 2025-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Predictive back route transitions by default (#165832)" (flutter/flutter#173809) 2025-08-14 engine-flutter-autoroll@skia.org Roll Skia from dca5f05fee87 to ad5d04000101 (8 revisions) (flutter/flutter#173798) 2025-08-14 mdebbar@google.com [web] Cleanup usages of deprecated `routeUpdated` message (flutter/flutter#173782) 2025-08-14 ahmedsameha1@gmail.com Make sure that DataTable, DataColumn, DataRow, and DataCell don't crash in 0x0 environment (flutter/flutter#173515) 2025-08-14 ahmedsameha1@gmail.com Make sure that a TableRowInkWell doesn't crash in 0x0 environment (flutter/flutter#173627) 2025-08-14 ahmedsameha1@gmail.com Make sure that a DatePickerDialog doesn't crash in 0x0 environment (flutter/flutter#173677) 2025-08-14 robert.ancell@canonical.com Return result of setting OpenGL contexts back to Flutter (flutter/flutter#173757) 2025-08-14 matanlurey@users.noreply.github.com Read `bin/cache/flutter.version.json` instead of `version` for `flutter_gallery` (flutter/flutter#173797) 2025-08-14 jmccandless@google.com Predictive back route transitions by default (flutter/flutter#165832) 2025-08-14 houssemeddinefadhli81@gmail.com feat: add onLongPressUp callback to InkWell widget (flutter/flutter#173221) 2025-08-14 engine-flutter-autoroll@skia.org Roll Dart SDK from 214a7f829913 to c7faab270f27 (1 revision) (flutter/flutter#173792) 2025-08-14 31859944+LongCatIsLooong@users.noreply.github.com Add error handling for `Element` lifecycle user callbacks (flutter/flutter#173148) 2025-08-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from I1TfNmsqTp7t3rO8e... to zWRpLglb48zC1vZLv... (flutter/flutter#173784) 2025-08-14 jhy03261997@gmail.com [Range slider] Tap on active range, the thumb closest to the mouse cursor should move to the cursor position. (flutter/flutter#173725) 2025-08-14 engine-flutter-autoroll@skia.org Roll Packages from 6cb9113 to 09533b7 (4 revisions) (flutter/flutter#173789) 2025-08-14 ttankkeo112@gmail.com Implements the Android native stretch effect as a fragment shader (Impeller-only). (flutter/flutter#169293) 2025-08-14 matanlurey@users.noreply.github.com Sync `CHANGELOG.md` (3.35 -> `master`) (flutter/flutter#173790) 2025-08-14 victorsanniay@gmail.com [VPAT][A11y] Announce Autocomplete search results status (flutter/flutter#173480) 2025-08-14 bruno.leroux@gmail.com Fix InputDecorator label padding (flutter/flutter#173344) 2025-08-14 edwinzn9@gmail.com Fix default minimumSize in dropdownMenu when maximumSize is null (flutter/flutter#169438) 2025-08-14 matanlurey@users.noreply.github.com Thread sub-builders for every engine-uploading builder (flutter/flutter#173742) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…tter#169438)  Previous change in `DropDownMenu` flutter#162380 forced the menu width to be constrained between the width or anchorWidth and the maximumSize width menuStyle, but giving a minimum of zero when maximumSize was not enforced or null. This prevents width or anchorWidth to be used at all as the minimum will be zero always if maximumSize is null Now this sets the default value back to width or anchorWidth if maximumSize is null, keeping consistency of the previous configuration while using the fix of maximumSize when provided. Fixes flutter#170970 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>

…r#9832) flutter/flutter@f4334d2...52af7a5 2025-08-15 engine-flutter-autoroll@skia.org Roll Packages from 09533b7 to 5c52c55 (6 revisions) (flutter/flutter#173854) 2025-08-15 engine-flutter-autoroll@skia.org Roll Skia from 46ec77ae3954 to 5654ac32ede0 (1 revision) (flutter/flutter#173848) 2025-08-15 engine-flutter-autoroll@skia.org Roll Skia from 162f47d6b6bd to 46ec77ae3954 (2 revisions) (flutter/flutter#173833) 2025-08-15 engine-flutter-autoroll@skia.org Roll Dart SDK from c7faab270f27 to cc008dc8e7aa (2 revisions) (flutter/flutter#173826) 2025-08-15 engine-flutter-autoroll@skia.org Roll Skia from ad5d04000101 to 162f47d6b6bd (5 revisions) (flutter/flutter#173822) 2025-08-15 jason-simmons@users.noreply.github.com Update the RBE configuration for the recent Clang update (flutter/flutter#173803) 2025-08-15 matanlurey@users.noreply.github.com Stop writing legacy `FLUTTER_ROOT/version` file (by default?) (flutter/flutter#172793) 2025-08-15 matanlurey@users.noreply.github.com Remove `luci_flags.parallel_download_builds` and friends (flutter/flutter#173799) 2025-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Predictive back route transitions by default (#165832)" (flutter/flutter#173809) 2025-08-14 engine-flutter-autoroll@skia.org Roll Skia from dca5f05fee87 to ad5d04000101 (8 revisions) (flutter/flutter#173798) 2025-08-14 mdebbar@google.com [web] Cleanup usages of deprecated `routeUpdated` message (flutter/flutter#173782) 2025-08-14 ahmedsameha1@gmail.com Make sure that DataTable, DataColumn, DataRow, and DataCell don't crash in 0x0 environment (flutter/flutter#173515) 2025-08-14 ahmedsameha1@gmail.com Make sure that a TableRowInkWell doesn't crash in 0x0 environment (flutter/flutter#173627) 2025-08-14 ahmedsameha1@gmail.com Make sure that a DatePickerDialog doesn't crash in 0x0 environment (flutter/flutter#173677) 2025-08-14 robert.ancell@canonical.com Return result of setting OpenGL contexts back to Flutter (flutter/flutter#173757) 2025-08-14 matanlurey@users.noreply.github.com Read `bin/cache/flutter.version.json` instead of `version` for `flutter_gallery` (flutter/flutter#173797) 2025-08-14 jmccandless@google.com Predictive back route transitions by default (flutter/flutter#165832) 2025-08-14 houssemeddinefadhli81@gmail.com feat: add onLongPressUp callback to InkWell widget (flutter/flutter#173221) 2025-08-14 engine-flutter-autoroll@skia.org Roll Dart SDK from 214a7f829913 to c7faab270f27 (1 revision) (flutter/flutter#173792) 2025-08-14 31859944+LongCatIsLooong@users.noreply.github.com Add error handling for `Element` lifecycle user callbacks (flutter/flutter#173148) 2025-08-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from I1TfNmsqTp7t3rO8e... to zWRpLglb48zC1vZLv... (flutter/flutter#173784) 2025-08-14 jhy03261997@gmail.com [Range slider] Tap on active range, the thumb closest to the mouse cursor should move to the cursor position. (flutter/flutter#173725) 2025-08-14 engine-flutter-autoroll@skia.org Roll Packages from 6cb9113 to 09533b7 (4 revisions) (flutter/flutter#173789) 2025-08-14 ttankkeo112@gmail.com Implements the Android native stretch effect as a fragment shader (Impeller-only). (flutter/flutter#169293) 2025-08-14 matanlurey@users.noreply.github.com Sync `CHANGELOG.md` (3.35 -> `master`) (flutter/flutter#173790) 2025-08-14 victorsanniay@gmail.com [VPAT][A11y] Announce Autocomplete search results status (flutter/flutter#173480) 2025-08-14 bruno.leroux@gmail.com Fix InputDecorator label padding (flutter/flutter#173344) 2025-08-14 edwinzn9@gmail.com Fix default minimumSize in dropdownMenu when maximumSize is null (flutter/flutter#169438) 2025-08-14 matanlurey@users.noreply.github.com Thread sub-builders for every engine-uploading builder (flutter/flutter#173742) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…tter#169438)  Previous change in `DropDownMenu` flutter#162380 forced the menu width to be constrained between the width or anchorWidth and the maximumSize width menuStyle, but giving a minimum of zero when maximumSize was not enforced or null. This prevents width or anchorWidth to be used at all as the minimum will be zero always if maximumSize is null Now this sets the default value back to width or anchorWidth if maximumSize is null, keeping consistency of the previous configuration while using the fix of maximumSize when provided. Fixes flutter#170970 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>

… null (flutter/flutter#169438)

…tter#169438)  Previous change in `DropDownMenu` flutter#162380 forced the menu width to be constrained between the width or anchorWidth and the maximumSize width menuStyle, but giving a minimum of zero when maximumSize was not enforced or null. This prevents width or anchorWidth to be used at all as the minimum will be zero always if maximumSize is null Now this sets the default value back to width or anchorWidth if maximumSize is null, keeping consistency of the previous configuration while using the fix of maximumSize when provided. Fixes flutter#170970 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>

EdwynZN added 2 commits May 25, 2025 12:05

fix default minimumSize in dropdownMenu

5c7cf5e

test when no MaximumSize is enforced

a263749

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels May 25, 2025

EdwynZN added 2 commits May 25, 2025 12:40

specify type

9721959

Merge branch 'master' into dropdown_max_menu_width

43d68d6

dkwingsmt requested a review from QuncCccccc June 4, 2025 18:30

QuncCccccc reviewed Jun 19, 2025

View reviewed changes

EdwynZN commented Jun 21, 2025

View reviewed changes

EdwynZN added 3 commits June 21, 2025 12:51

Merge branch 'flutter:master' into dropdown_max_menu_width

2b26fc0

simplify width calculation

d22d928

fix possible null analyzer

bc5dc8d

QuncCccccc reviewed Jun 24, 2025

View reviewed changes

EdwynZN and others added 3 commits June 24, 2025 16:09

Update packages/flutter/lib/src/material/dropdown_menu.dart

30fbc85

Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>

Update packages/flutter/test/material/dropdown_menu_test.dart

8753c47

Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>

Merge branch 'master' into dropdown_max_menu_width

c41907c

dkwingsmt requested a review from QuncCccccc July 2, 2025 18:21

QuncCccccc reviewed Jul 8, 2025

View reviewed changes

packages/flutter/test/material/dropdown_menu_test.dart Show resolved Hide resolved

EdwynZN added 2 commits July 12, 2025 23:01

Merge branch 'master' into dropdown_max_menu_width

5d30459

dropdown test added: ensure items are constrained to intrinsic size o…

ba38fa9

…f DropdownMenu (width or anchor) when no maximumSize

dkwingsmt requested a review from QuncCccccc July 23, 2025 18:15

QuncCccccc approved these changes Jul 23, 2025

View reviewed changes

QuncCccccc reviewed Jul 24, 2025

View reviewed changes

packages/flutter/test/material/dropdown_menu_test.dart Outdated Show resolved Hide resolved

EdwynZN and others added 3 commits July 24, 2025 10:24

Update packages/flutter/test/material/dropdown_menu_test.dart

955dd08

Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>

Update packages/flutter/test/material/dropdown_menu_test.dart

39072fd

Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>

Merge branch 'master' into dropdown_max_menu_width

6a5599a

EdwynZN added 3 commits July 28, 2025 13:06

use default physicalSize (800 width)

ed7ea63

dart fix

1a25fdc

Merge branch 'master' into dropdown_max_menu_width

20ea2db

rydmike mentioned this pull request Aug 3, 2025

DropdownMenu is different between checked-out code and website rydmike/flex_color_scheme#286

Closed

Merge branch 'master' into dropdown_max_menu_width

2646982

QuncCccccc approved these changes Aug 11, 2025

View reviewed changes

packages/flutter/test/material/dropdown_menu_test.dart Outdated Show resolved Hide resolved

packages/flutter/test/material/dropdown_menu_test.dart Show resolved Hide resolved

justinmc approved these changes Aug 11, 2025

View reviewed changes

EdwynZN and others added 3 commits August 11, 2025 15:17

Update packages/flutter/test/material/dropdown_menu_test.dart

310166f

Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>

Update packages/flutter/test/material/dropdown_menu_test.dart

b115911

Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>

Remove takeException() test

c65f1c1

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 14, 2025

auto-submit bot added this pull request to the merge queue Aug 14, 2025

Merged via the queue into flutter:master with commit e2c7311 Aug 14, 2025
74 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 14, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

e2c731195 Fix default minimumSize in dropdownMenu when maximumSize is…

034843e

… null (flutter/flutter#169438)

engine-flutter-autoroll mentioned this pull request Aug 15, 2025

Roll Flutter from f4334d27934b to 3bf280c86fb9 (27 revisions) flutter/packages#9823

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

e2c731195 Fix default minimumSize in dropdownMenu when maximumSize is…

3d60027

… null (flutter/flutter#169438)

engine-flutter-autoroll mentioned this pull request Aug 15, 2025

Roll Flutter from f4334d27934b to da5c047a13d7 (28 revisions) flutter/packages#9827

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

e2c731195 Fix default minimumSize in dropdownMenu when maximumSize is…

c4f81f9

… null (flutter/flutter#169438)

engine-flutter-autoroll mentioned this pull request Aug 15, 2025

Roll Flutter from f4334d27934b to 52af7a504025 (29 revisions) flutter/packages#9832

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

e2c731195 Fix default minimumSize in dropdownMenu when maximumSize is…

7c55773

… null (flutter/flutter#169438)


		expect(tester.takeException(), isNull);
		expect(tester.getSize(findMenuItemButton(menuChildren.first.label)).width, 200.0);

		tester.view.physicalSize = const Size(390, 810);
		tester.view.devicePixelRatio = 1.0;

Fix default minimumSize in dropdownMenu when maximumSize is null #169438

Fix default minimumSize in dropdownMenu when maximumSize is null #169438

Conversation

EdwynZN commented May 25, 2025 • edited by QuncCccccc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EdwynZN left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

QuncCccccc commented Jul 28, 2025

Uh oh!

EdwynZN commented Aug 10, 2025

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

justinmc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EdwynZN Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

EdwynZN commented May 25, 2025 •

edited by QuncCccccc

Loading

EdwynZN left a comment •

edited

Loading

justinmc left a comment •

edited

Loading

EdwynZN Aug 14, 2025 •

edited

Loading