fixed impeller golden content scale #167308

gaaclarke · 2025-04-16T21:37:25Z

fixes #162036

This fixes the problem my scaling the render texture by the content scalar. This means locally you'll probably be generating 2048x1536 images. This matches the rendering that is happening in playgrounds. On CI the content scalar should be one so there is no change there.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This reverts commit 1299fe4.

flar

LGTM

flutter/flutter@ecabb1a...3ed38e2 2025-04-18 louisehsu@google.com Update `led` docs (flutter/flutter#167380) 2025-04-18 jason-simmons@users.noreply.github.com Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948) 2025-04-18 1063596+reidbaker@users.noreply.github.com Add kotlin compatability to build file validation (flutter/flutter#167143) 2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400) 2025-04-18 bruno.leroux@gmail.com Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271) 2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396) 2025-04-18 bruno.leroux@gmail.com Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834) 2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389) 2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388) 2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387) 2025-04-18 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385) 2025-04-17 engine-flutter-autoroll@skia.org Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347) 2025-04-17 jason-simmons@users.noreply.github.com Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918) 2025-04-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361) 2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226) 2025-04-17 30870216+gaaclarke@users.noreply.github.com adds Entity docstrings (flutter/flutter#167228) 2025-04-17 30870216+gaaclarke@users.noreply.github.com fixed impeller golden content scale (flutter/flutter#167308) 2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterContents::RenderFilter (flutter/flutter#167227) 2025-04-17 34465683+rkishan516@users.noreply.github.com Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655) 2025-04-17 linxunfeng@yeah.net Fix link to engine docs (flutter/flutter#167346) 2025-04-17 matej.knopp@gmail.com [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536) 2025-04-17 matej.knopp@gmail.com [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726) 2025-04-17 matanlurey@users.noreply.github.com Update `CHANGELOG.md` (flutter/flutter#167225) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#9114) flutter/flutter@ecabb1a...3ed38e2 2025-04-18 louisehsu@google.com Update `led` docs (flutter/flutter#167380) 2025-04-18 jason-simmons@users.noreply.github.com Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948) 2025-04-18 1063596+reidbaker@users.noreply.github.com Add kotlin compatability to build file validation (flutter/flutter#167143) 2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400) 2025-04-18 bruno.leroux@gmail.com Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271) 2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396) 2025-04-18 bruno.leroux@gmail.com Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834) 2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389) 2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388) 2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387) 2025-04-18 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385) 2025-04-17 engine-flutter-autoroll@skia.org Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347) 2025-04-17 jason-simmons@users.noreply.github.com Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918) 2025-04-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361) 2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226) 2025-04-17 30870216+gaaclarke@users.noreply.github.com adds Entity docstrings (flutter/flutter#167228) 2025-04-17 30870216+gaaclarke@users.noreply.github.com fixed impeller golden content scale (flutter/flutter#167308) 2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterContents::RenderFilter (flutter/flutter#167227) 2025-04-17 34465683+rkishan516@users.noreply.github.com Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655) 2025-04-17 linxunfeng@yeah.net Fix link to engine docs (flutter/flutter#167346) 2025-04-17 matej.knopp@gmail.com [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536) 2025-04-17 matej.knopp@gmail.com [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726) 2025-04-17 matanlurey@users.noreply.github.com Update `CHANGELOG.md` (flutter/flutter#167225) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

gaaclarke added 4 commits April 16, 2025 14:36

fixed render content scalar for golden tests

809fc51

fixed opengl and vulkan

bbdf7d3

removed scalar to image

acbb82b

removed GetContentScale

1299fe4

github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine repository. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Apr 16, 2025

gaaclarke changed the title ~~Golden content scale~~ fixed impeller golden content scale Apr 16, 2025

Revert "removed GetContentScale"

838c562

This reverts commit 1299fe4.

github-actions bot removed the a: text input Entering text in a text field or keyboard related problems label Apr 16, 2025

gaaclarke requested review from flar and jonahwilliams April 16, 2025 22:16

flar approved these changes Apr 17, 2025

View reviewed changes

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2025

auto-submit bot added this pull request to the merge queue Apr 17, 2025

Merged via the queue into flutter:master with commit a23e4ca Apr 17, 2025
179 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2025

a23e4ca19 fixed impeller golden content scale (flutter/flutter#167308)

6971b2c

engine-flutter-autoroll mentioned this pull request Apr 18, 2025

Roll Flutter from ecabb1a05212 to d20300874123 (20 revisions) flutter/packages#9111

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2025

a23e4ca19 fixed impeller golden content scale (flutter/flutter#167308)

586ecd0

engine-flutter-autoroll mentioned this pull request Apr 18, 2025

Roll Flutter from ecabb1a05212 to f20bc39cc005 (21 revisions) flutter/packages#9113

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2025

a23e4ca19 fixed impeller golden content scale (flutter/flutter#167308)

c951ee7

engine-flutter-autoroll mentioned this pull request Apr 18, 2025

Roll Flutter from ecabb1a05212 to 3ed38e24528a (23 revisions) flutter/packages#9114

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fixed impeller golden content scale #167308

fixed impeller golden content scale #167308

Uh oh!

gaaclarke commented Apr 16, 2025 •

edited

Loading

Uh oh!

flar left a comment

Uh oh!

Uh oh!

Uh oh!

fixed impeller golden content scale #167308

fixed impeller golden content scale #167308

Uh oh!

Conversation

gaaclarke commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gaaclarke commented Apr 16, 2025 •

edited

Loading