-
Notifications
You must be signed in to change notification settings - Fork 28.8k
Update the Dart package creation script to copy source files instead of creating symlinks to the source tree #165242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Dart package creation script to copy source files instead of creating symlinks to the source tree #165242
Conversation
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So GN doesn't follow symlinks for modification times? Dang.
…of creating symlinks to the source tree The use of symlinks and the use of a directory as a GN output path may cause unnecessary rebuilds when Ninja checks file modification times to determine whether build outputs are up to date. Also remove various other unused featues that were copied from the original version of the script in the Mojo project.
7a279e4
to
60a741c
Compare
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…instead of creating symlinks to the source tree (flutter/flutter#165242)
…of creating symlinks to the source tree (flutter#165242) The use of symlinks and the use of a directory as a GN output path may cause unnecessary rebuilds when Ninja checks file modification times to determine whether build outputs are up to date. Also remove various other unused featues that were copied from the original version of the script in the Mojo project.
The use of symlinks and the use of a directory as a GN output path may cause unnecessary rebuilds when Ninja checks file modification times to determine whether build outputs are up to date.
Also remove various other unused featues that were copied from the original version of the script in the Mojo project.