-
Notifications
You must be signed in to change notification settings - Fork 28.8k
[Windows] Enable merged platform and UI thread by default #163726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Enable merged platform and UI thread by default #163726
Conversation
f83e711
to
4e8b9af
Compare
Hey there, could we wait 1 stable release before turning this on by default? Merged threads is a risky change that might regress apps. Waiting 1 stable release will give us the chance to ask Windows customers to opt-in to merged threads and give us feedback if they run into any problems. |
I think on iOS and Android this got enabled pretty quickly on main. Could we maybe enable this on main after next beta is branched? |
We have much stronger confidence in iOS and Android changes since we have Google apps that we can test on to find regression. Also, Flutter's iOS and Android teams are significantly larger and have capacity to hotfix regressions. Sadly desktop isn't as well staffed, so I'd like to minimize our chance for regressions if possible. Unfortunately, the beta branch has very low usage. We haven't had much success getting customers to dogfood changes on beta branches. |
Not sure that answers my question? What's wrong with enabling it on main after the next beta branches from main, so that it is disabled by default in the next stable, but enabled in main (after the beta branch, which I'd assume would happen sometimes next week)? |
Sorry, I misread your question. That sounds good to me 👍 |
engine/src/flutter/shell/platform/windows/flutter_windows_engine.cc
Outdated
Show resolved
Hide resolved
engine/src/flutter/shell/platform/windows/flutter_windows_unittests.cc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! :)
155ef7a
to
8f18c1b
Compare
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Not sure where the goldens change is coming from? |
…ne.cc Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
5ad4c87
to
7223b45
Compare
@knopp Man, flutter still alive because of people like you. Highly respecting you! |
flutter/flutter@ecabb1a...3ed38e2 2025-04-18 louisehsu@google.com Update `led` docs (flutter/flutter#167380) 2025-04-18 jason-simmons@users.noreply.github.com Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948) 2025-04-18 1063596+reidbaker@users.noreply.github.com Add kotlin compatability to build file validation (flutter/flutter#167143) 2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400) 2025-04-18 bruno.leroux@gmail.com Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271) 2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396) 2025-04-18 bruno.leroux@gmail.com Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834) 2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389) 2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388) 2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387) 2025-04-18 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385) 2025-04-17 engine-flutter-autoroll@skia.org Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347) 2025-04-17 jason-simmons@users.noreply.github.com Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918) 2025-04-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361) 2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226) 2025-04-17 30870216+gaaclarke@users.noreply.github.com adds Entity docstrings (flutter/flutter#167228) 2025-04-17 30870216+gaaclarke@users.noreply.github.com fixed impeller golden content scale (flutter/flutter#167308) 2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterContents::RenderFilter (flutter/flutter#167227) 2025-04-17 34465683+rkishan516@users.noreply.github.com Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655) 2025-04-17 linxunfeng@yeah.net Fix link to engine docs (flutter/flutter#167346) 2025-04-17 matej.knopp@gmail.com [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536) 2025-04-17 matej.knopp@gmail.com [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726) 2025-04-17 matanlurey@users.noreply.github.com Update `CHANGELOG.md` (flutter/flutter#167225) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Reason for revert: #167418 |
Time to revert pull request flutter/flutter/163726 has elapsed. |
…utter#163726)" This reverts commit afdc861.
…3726) This enables running UI isolate on platform thread by default. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
…167472) This relands #163726 without changes. The likely reason for flakiness was #166918 (#167418 (comment)). <!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
flutter/flutter@ecabb1a...3ed38e2 2025-04-18 louisehsu@google.com Update `led` docs (flutter/flutter#167380) 2025-04-18 jason-simmons@users.noreply.github.com Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948) 2025-04-18 1063596+reidbaker@users.noreply.github.com Add kotlin compatability to build file validation (flutter/flutter#167143) 2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400) 2025-04-18 bruno.leroux@gmail.com Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271) 2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396) 2025-04-18 bruno.leroux@gmail.com Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834) 2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389) 2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388) 2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387) 2025-04-18 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385) 2025-04-17 engine-flutter-autoroll@skia.org Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347) 2025-04-17 jason-simmons@users.noreply.github.com Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918) 2025-04-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361) 2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226) 2025-04-17 30870216+gaaclarke@users.noreply.github.com adds Entity docstrings (flutter/flutter#167228) 2025-04-17 30870216+gaaclarke@users.noreply.github.com fixed impeller golden content scale (flutter/flutter#167308) 2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterContents::RenderFilter (flutter/flutter#167227) 2025-04-17 34465683+rkishan516@users.noreply.github.com Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655) 2025-04-17 linxunfeng@yeah.net Fix link to engine docs (flutter/flutter#167346) 2025-04-17 matej.knopp@gmail.com [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536) 2025-04-17 matej.knopp@gmail.com [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726) 2025-04-17 matanlurey@users.noreply.github.com Update `CHANGELOG.md` (flutter/flutter#167225) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#9114) flutter/flutter@ecabb1a...3ed38e2 2025-04-18 louisehsu@google.com Update `led` docs (flutter/flutter#167380) 2025-04-18 jason-simmons@users.noreply.github.com Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948) 2025-04-18 1063596+reidbaker@users.noreply.github.com Add kotlin compatability to build file validation (flutter/flutter#167143) 2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400) 2025-04-18 bruno.leroux@gmail.com Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271) 2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396) 2025-04-18 bruno.leroux@gmail.com Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834) 2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389) 2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388) 2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387) 2025-04-18 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385) 2025-04-17 engine-flutter-autoroll@skia.org Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347) 2025-04-17 jason-simmons@users.noreply.github.com Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918) 2025-04-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361) 2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226) 2025-04-17 30870216+gaaclarke@users.noreply.github.com adds Entity docstrings (flutter/flutter#167228) 2025-04-17 30870216+gaaclarke@users.noreply.github.com fixed impeller golden content scale (flutter/flutter#167308) 2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterContents::RenderFilter (flutter/flutter#167227) 2025-04-17 34465683+rkishan516@users.noreply.github.com Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655) 2025-04-17 linxunfeng@yeah.net Fix link to engine docs (flutter/flutter#167346) 2025-04-17 matej.knopp@gmail.com [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536) 2025-04-17 matej.knopp@gmail.com [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726) 2025-04-17 matanlurey@users.noreply.github.com Update `CHANGELOG.md` (flutter/flutter#167225) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#9114) flutter/flutter@ecabb1a...3ed38e2 2025-04-18 louisehsu@google.com Update `led` docs (flutter/flutter#167380) 2025-04-18 jason-simmons@users.noreply.github.com Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948) 2025-04-18 1063596+reidbaker@users.noreply.github.com Add kotlin compatability to build file validation (flutter/flutter#167143) 2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400) 2025-04-18 bruno.leroux@gmail.com Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271) 2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396) 2025-04-18 bruno.leroux@gmail.com Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834) 2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389) 2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388) 2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387) 2025-04-18 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385) 2025-04-17 engine-flutter-autoroll@skia.org Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347) 2025-04-17 jason-simmons@users.noreply.github.com Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918) 2025-04-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361) 2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226) 2025-04-17 30870216+gaaclarke@users.noreply.github.com adds Entity docstrings (flutter/flutter#167228) 2025-04-17 30870216+gaaclarke@users.noreply.github.com fixed impeller golden content scale (flutter/flutter#167308) 2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterContents::RenderFilter (flutter/flutter#167227) 2025-04-17 34465683+rkishan516@users.noreply.github.com Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655) 2025-04-17 linxunfeng@yeah.net Fix link to engine docs (flutter/flutter#167346) 2025-04-17 matej.knopp@gmail.com [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536) 2025-04-17 matej.knopp@gmail.com [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726) 2025-04-17 matanlurey@users.noreply.github.com Update `CHANGELOG.md` (flutter/flutter#167225) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#9114) flutter/flutter@ecabb1a...3ed38e2 2025-04-18 louisehsu@google.com Update `led` docs (flutter/flutter#167380) 2025-04-18 jason-simmons@users.noreply.github.com Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948) 2025-04-18 1063596+reidbaker@users.noreply.github.com Add kotlin compatability to build file validation (flutter/flutter#167143) 2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400) 2025-04-18 bruno.leroux@gmail.com Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271) 2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396) 2025-04-18 bruno.leroux@gmail.com Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834) 2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389) 2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388) 2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387) 2025-04-18 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385) 2025-04-17 engine-flutter-autoroll@skia.org Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347) 2025-04-17 jason-simmons@users.noreply.github.com Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918) 2025-04-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361) 2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226) 2025-04-17 30870216+gaaclarke@users.noreply.github.com adds Entity docstrings (flutter/flutter#167228) 2025-04-17 30870216+gaaclarke@users.noreply.github.com fixed impeller golden content scale (flutter/flutter#167308) 2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterContents::RenderFilter (flutter/flutter#167227) 2025-04-17 34465683+rkishan516@users.noreply.github.com Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655) 2025-04-17 linxunfeng@yeah.net Fix link to engine docs (flutter/flutter#167346) 2025-04-17 matej.knopp@gmail.com [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536) 2025-04-17 matej.knopp@gmail.com [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726) 2025-04-17 matanlurey@users.noreply.github.com Update `CHANGELOG.md` (flutter/flutter#167225) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This enables running UI isolate on platform thread by default.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.