Skip to content

[web] Cleanup everything HTML from the flutter tool and test harness #162836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 13, 2025
Merged

[web] Cleanup everything HTML from the flutter tool and test harness #162836

merged 5 commits into from
Feb 13, 2025

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Feb 6, 2025

  • Delete code paths that handle screenshots for the HTML renderer
  • Delete artifact enums for the HTML/AUTO renderers (and all their usages).
  • Remove HTML/AUTO renderers warnings.
  • Delete the HTML/AUTO renderer enums (and all their usages).
  • Delete tests for all the above.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. labels Feb 6, 2025
harryterkelsen
harryterkelsen approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 13, 2025
Merged via the queue into flutter:master with commit 5fa05ab Feb 13, 2025
140 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
4b3e77e 
…harness (flutter/flutter#162836)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
7bfc298 
…harness (flutter/flutter#162836)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
db69d61 
…harness (flutter/flutter#162836)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
b9def4f 
…harness (flutter/flutter#162836)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
9367ed3 
…harness (flutter/flutter#162836)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
45abccc 
…harness (flutter/flutter#162836)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
cf90291 
…harness (flutter/flutter#162836)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
30a7ce7 
…harness (flutter/flutter#162836)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
6bada51 
…harness (flutter/flutter#162836)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
19e25d9 
…harness (flutter/flutter#162836)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
700b8c0 
…harness (flutter/flutter#162836)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
a79c49d 
…harness (flutter/flutter#162836)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
bfa8967 
…harness (flutter/flutter#162836)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
ccc7010 
…harness (flutter/flutter#162836)
@mdebbar mdebbar deleted the flutter_tools_html branch February 18, 2025 17:29
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
f42f0fe 
…harness (flutter/flutter#162836)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
86ff728 
…harness (flutter/flutter#162836)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
a410e26 
…harness (flutter/flutter#162836)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
f8dd164 
…harness (flutter/flutter#162836)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
3761053 
…harness (flutter/flutter#162836)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
2cb23ad 
…harness (flutter/flutter#162836)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
9ec29ad 
…harness (flutter/flutter#162836)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
59eb379 
…harness (flutter/flutter#162836)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
adf325d 
…harness (flutter/flutter#162836)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
ac0b00b 
…harness (flutter/flutter#162836)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
5fa05ab [web] Cleanup everything HTML from the flutter tool and test …
f8b83dc 
…harness (flutter/flutter#162836)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harryterkelsen harryterkelsen harryterkelsen approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdebbar @harryterkelsen