Skip to content

Consider changes to DEPS and engine/** to impact most runIf-guarded builds #160706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2024
Merged

Consider changes to DEPS and engine/** to impact most runIf-guarded builds #160706

merged 2 commits into from
Dec 21, 2024

Conversation

matanlurey
Copy link
Contributor

This was done with sed and some manual massaging.

Closes #160703.

/cc @aam, after this lands we can resume Dart SDK rolls.

@matanlurey matanlurey requested a review from jtmcdole December 21, 2024 01:11
@matanlurey matanlurey mentioned this pull request Dec 21, 2024
Closed
@jtmcdole
Copy link
Member

So we just searched for - .ci/yaml and added the engine and deps? That should trigger all the presubmits.

jtmcdole
jtmcdole approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@jtmcdole jtmcdole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matanlurey matanlurey enabled auto-merge December 21, 2024 01:20
@matanlurey matanlurey added this pull request to the merge queue Dec 21, 2024
Merged via the queue into flutter:master with commit fe4c672 Dec 21, 2024
167 of 174 checks passed
@matanlurey matanlurey deleted the ci-yaml-enforce-engine-and-deps branch December 21, 2024 02:31
@mdebbar mdebbar mentioned this pull request Dec 27, 2024
Merged
@matanlurey matanlurey mentioned this pull request Dec 27, 2024
Closed
github-merge-queue bot pushed a commit that referenced this pull request Dec 27, 2024
@mdebbar
Add missing DEPS to runIf (#160913)
7a50802 
Few entries were missed in
#160706 and caused
[failures](https://github.com/flutter/flutter/pull/160191/checks?check_run_id=34920131317)
when [this](flutter/cocoon#4137) landed.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
fe4c672 Consider changes to DEPS and engine/** to impact most run…
4ac303b 
…If-guarded builds (flutter/flutter#160706)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
fe4c672 Consider changes to DEPS and engine/** to impact most run…
a0268d2 
…If-guarded builds (flutter/flutter#160706)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
fe4c672 Consider changes to DEPS and engine/** to impact most run…
b405e0f 
…If-guarded builds (flutter/flutter#160706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
fe4c672 Consider changes to DEPS and engine/** to impact most run…
cf8e967 
…If-guarded builds (flutter/flutter#160706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
fe4c672 Consider changes to DEPS and engine/** to impact most run…
5998b51 
…If-guarded builds (flutter/flutter#160706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
fe4c672 Consider changes to DEPS and engine/** to impact most run…
cc171e2 
…If-guarded builds (flutter/flutter#160706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
fe4c672 Consider changes to DEPS and engine/** to impact most run…
610017d 
…If-guarded builds (flutter/flutter#160706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
fe4c672 Consider changes to DEPS and engine/** to impact most run…
6b8e1eb 
…If-guarded builds (flutter/flutter#160706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
fe4c672 Consider changes to DEPS and engine/** to impact most run…
ef33aff 
…If-guarded builds (flutter/flutter#160706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
fe4c672 Consider changes to DEPS and engine/** to impact most run…
259bc06 
…If-guarded builds (flutter/flutter#160706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
fe4c672 Consider changes to DEPS and engine/** to impact most run…
fee708e 
…If-guarded builds (flutter/flutter#160706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
fe4c672 Consider changes to DEPS and engine/** to impact most run…
adc7298 
…If-guarded builds (flutter/flutter#160706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
fe4c672 Consider changes to DEPS and engine/** to impact most run…
862beea 
…If-guarded builds (flutter/flutter#160706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
fe4c672 Consider changes to DEPS and engine/** to impact most run…
aa008ae 
…If-guarded builds (flutter/flutter#160706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
fe4c672 Consider changes to DEPS and engine/** to impact most run…
7e87904 
…If-guarded builds (flutter/flutter#160706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
fe4c672 Consider changes to DEPS and engine/** to impact most run…
5874aeb 
…If-guarded builds (flutter/flutter#160706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
fe4c672 Consider changes to DEPS and engine/** to impact most run…
1c710bb 
…If-guarded builds (flutter/flutter#160706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
fe4c672 Consider changes to DEPS and engine/** to impact most run…
f3f8b72 
…If-guarded builds (flutter/flutter#160706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
fe4c672 Consider changes to DEPS and engine/** to impact most run…
e94e042 
…If-guarded builds (flutter/flutter#160706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
fe4c672 Consider changes to DEPS and engine/** to impact most run…
a1f3a3f 
…If-guarded builds (flutter/flutter#160706)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtmcdole jtmcdole jtmcdole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rolling Dart SDK should run all tests (not skip framework tests)
2 participants
@matanlurey @jtmcdole