Re-enable dds for flutter drive tests that use DevTools #153129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
approved these changes
Aug 8, 2024
jmagman
reviewed
Aug 8, 2024
| // See https://github.com/flutter/flutter/issues/152684. | ||
| if (command == 'drive') '--no-dds', | ||
| if (command == 'drive' && !driveWithDds) '--no-dds', |
There was a problem hiding this comment.
Need to pipe driveWithDds into this method though.
There was a problem hiding this comment.
I think the only spot it needs to go is where it's added in perf_tests.dart below.
zanderso
force-pushed
the
drive-devtools-dds
branch
from
1ef160c to
8ddd8ae
Compare
chinmaygarde
approved these changes
Aug 8, 2024
zanderso
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 9, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 9, 2024
Manual roll requested by tarrinneal@google.com flutter/flutter@b6cd31e...76107bd 2024-08-08 zanderso@users.noreply.github.com Re-enable dds for flutter drive tests that use DevTools (flutter/flutter#153129) 2024-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from ef820aa74f7a to 05208896830a (5 revisions) (flutter/flutter#153132) 2024-08-08 jonahwilliams@google.com [devicelab] opt all impeller tests to GPU tracing, opt some Android tests into merged thread mode. (flutter/flutter#153121) 2024-08-08 737941+loic-sharma@users.noreply.github.com Clean up .gitignore files (flutter/flutter#153060) 2024-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 387f6f3c5fdb to ef820aa74f7a (4 revisions) (flutter/flutter#153124) 2024-08-08 zanderso@users.noreply.github.com Shift Linux_android_emu tests from staging to prod (flutter/flutter#153110) 2024-08-08 zanderso@users.noreply.github.com Move Android tests with macOS host from staging to prod (flutter/flutter#153113) 2024-08-08 magder@google.com Remove -sdk for watchOS simulator in tool (flutter/flutter#152992) 2024-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3978ddd8d7a7 to 387f6f3c5fdb (3 revisions) (flutter/flutter#153111) 2024-08-08 engine-flutter-autoroll@skia.org Roll Packages from 5cc0a01 to bb797b9 (5 revisions) (flutter/flutter#153107) 2024-08-08 kevmoo@users.noreply.github.com Roll pub packages [manual] (flutter/flutter#153066) 2024-08-08 jason-simmons@users.noreply.github.com [web] Fix reading of the --local-web-sdk flag and remove the copy of useLocalWebSdk in DebuggingOptions (flutter/flutter#152642) 2024-08-08 ybz975218925@gmail.com The `PopupMenuButton` should not steal focus from the TextField when it appears. (flutter/flutter#150568) 2024-08-08 louisehsu@google.com Fix `flutter build ipa --export-method` not accepting `enterprise` flag (flutter/flutter#153047) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #153057