Skip to content

Support clearing selection programmatically through SelectableRegionState #152882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2024
Merged

Support clearing selection programmatically through SelectableRegionState #152882

merged 1 commit into from
Aug 6, 2024

Conversation

Renzo-Olivares
Copy link
Contributor

This change exposes:

  • SelectableRegionState.clearSelection() to allow a user to programmatically clear the selection.
  • SelectionAreaState/SelectionAreaState.selectableRegion to allow a user to access public API in SelectableRegion from SelectionArea.

Fixes #126980

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Aug 5, 2024
@Renzo-Olivares Renzo-Olivares requested a review from chunhtai August 5, 2024 18:58
chunhtai
chunhtai approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Renzo-Olivares Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024
@auto-submit auto-submit bot merged commit 0a7f8af into flutter:master Aug 6, 2024
70 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 7, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 7, 2024
@engine-flutter-autoroll
0a7f8af Support clearing selection programmatically through Selectabl…
4752ed4 
…eRegionState (flutter/flutter#152882)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 7, 2024
@engine-flutter-autoroll
Manual roll Flutter from 1dd7141 to 0a7f8af (23 revisions) (#7328)
22a784c 
Manual roll requested by tarrinneal@google.com

flutter/flutter@1dd7141...0a7f8af

2024-08-06 rmolivares@renzo-olivares.dev Support clearing selection programmatically through SelectableRegionState (flutter/flutter#152882)
2024-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from aabd582e9c7e to 206e86ee8a40 (4 revisions) (flutter/flutter#152962)
2024-08-06 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.4 to 4.3.6 (flutter/flutter#152964)
2024-08-06 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.15 to 3.26.0 (flutter/flutter#152965)
2024-08-06 andrewrkolos@gmail.com [tool] Guard process writes to frontend server in `ResidentCompiler` (flutter/flutter#152358)
2024-08-06 zanderso@users.noreply.github.com Fix Linux_android_emu tests late initialization errors (flutter/flutter#152932)
2024-08-06 fluttergithubbot@gmail.com Marks Mac integration_ui_test_test_macos to be flaky (flutter/flutter#152213)
2024-08-06 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#152956)
2024-08-06 pateltirth454@gmail.com [API Examples] `scroll_direction.0_test.dart` & `growth_direction.0_test.dart` (flutter/flutter#152941)
2024-08-06 jonahwilliams@google.com [devicelab] opt gallery benchmarks and platform view test into merged thread mode. (flutter/flutter#152940)
2024-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from e97955bf12ac to aabd582e9c7e (1 revision) (flutter/flutter#152948)
2024-08-06 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#152945)
2024-08-06 59215665+davidhicks980@users.noreply.github.com [material/menu_anchor.dart] MenuAnchor focus refactoring for RawMenuAnchor (flutter/flutter#150950)
2024-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 99da2cab3f6d to e97955bf12ac (2 revisions) (flutter/flutter#152944)
2024-08-06 gazal.gafoor.k@gmail.com fix: add parameter to maintainState of SearchDelegate (flutter/flutter#152444)
2024-08-06 34465683+rkishan516@users.noreply.github.com Feat: Add fillColor property for cupertinoCheckbox (flutter/flutter#151761)
2024-08-06 42016383+DBowen33@users.noreply.github.com Slider does not show changed label value for keyboard users fix (flutter/flutter#152886)
2024-08-06 nate.w5687@gmail.com Add Nate Wilson to authors (flutter/flutter#152907)
2024-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7fc38bef4775 to 99da2cab3f6d (1 revision) (flutter/flutter#152934)
2024-08-06 engine-flutter-autoroll@skia.org Roll Packages from 82e8d1e to 551bde5 (12 revisions) (flutter/flutter#152930)
2024-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 84116159ebfc to 7fc38bef4775 (1 revision) (flutter/flutter#152924)
2024-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from f75ffb65cfe3 to 84116159ebfc (1 revision) (flutter/flutter#152917)
2024-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from f5f6e966e7e7 to f75ffb65cfe3 (2 revisions) (flutter/flutter#152915)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
@Renzo-Olivares @TytaniumDev
Support clearing selection programmatically through SelectableRegionS…
fe35193 
…tate (flutter#152882)

This change exposes:
* `SelectableRegionState.clearSelection()` to allow a user to programmatically clear the selection.
* `SelectionAreaState`/`SelectionAreaState.selectableRegion` to allow a user to access public API in `SelectableRegion` from `SelectionArea`.

Fixes flutter#126980
@Piinks Piinks mentioned this pull request Aug 9, 2024
Closed
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@Renzo-Olivares @Buchimi
Support clearing selection programmatically through SelectableRegionS…
1e7ee05 
…tate (flutter#152882)

This change exposes:
* `SelectableRegionState.clearSelection()` to allow a user to programmatically clear the selection.
* `SelectionAreaState`/`SelectionAreaState.selectableRegion` to allow a user to access public API in `SelectableRegion` from `SelectionArea`.

Fixes flutter#126980
@Renzo-Olivares Renzo-Olivares mentioned this pull request Sep 25, 2024
Closed
2 tasks
@vergaraSC
Copy link

@Renzo-Olivares the controller for the SelectionArea, will be available soon? it is necessary for several cases that cannot be done today when you have a custom context builder.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
0a7f8af Support clearing selection programmatically through Selectabl…
e044dd0 
…eRegionState (flutter/flutter#152882)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
0a7f8af Support clearing selection programmatically through Selectabl…
e3cf530 
…eRegionState (flutter/flutter#152882)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SelectableRegionState public _selectable and _clearSelection
3 participants
@Renzo-Olivares @vergaraSC @chunhtai