InputDecorator M3 tests migration - Step5 - Helper/Counter/Error #144932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
|
@justinmc I added some TODO for values that are not compliant with the M3 spec. I will focus on fixing those values for my next PRs (these might be breaking changes so I did not bundle those changes with this test only PR). |
bleroux
force-pushed
the
M3_tests_migration_input_decorator_helper_counter_error
branch
3 times, most recently
from
244b367 to
fcdcb59
Compare
justinmc
approved these changes
Mar 11, 2024
Comment on lines
+1520
to
+1521
| // TODO(bleroux): make the InputDecorator implementation compliant with M3 spec by changing | ||
| // the helperGap to 4.0 instead of 8.0. |
There was a problem hiding this comment.
Nit: Is there an issue you could link for this?
There was a problem hiding this comment.
Added a link to #144984, and currently working on a PR for it.
| }); | ||
| }); | ||
|
|
||
| group('Multilines error/helper', () { |
There was a problem hiding this comment.
Super nit: I would just say "Multiline" with no "s".
bleroux
force-pushed
the
M3_tests_migration_input_decorator_helper_counter_error
branch
2 times, most recently
from
c8763f4 to
18a8cce
Compare
bleroux
force-pushed
the
M3_tests_migration_input_decorator_helper_counter_error
branch
from
18a8cce to
9ac7472
Compare
bleroux
added
the
autosubmit
bleroux
deleted the
M3_tests_migration_input_decorator_helper_counter_error
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2024
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
## Description This PR migrates `InputDecorator.constraints` related tests to M3 and also various regression tests. It is the fifth step for the M3 test migration for `InputDecorator`. Step 1: #142981 Step 2: #143369 Step 3: #143520 Step 4: #144169 Step 5: #144932 ## Related Issue Related to #139076 @justinmc A somewhat small PR, I wanted to migrate the small group related to 'InputDecoration.constraints' (starting at line 2801), it adds a test checking min interactive height and two others that shows one way to bypass the standard min interactive height.
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 29, 2024
## Description This PRs adds a test group for the input decorator container, this group is organised similarly to the M3 spec, see https://m3.material.io/components/text-fields/specs. It is step 7 for the M3 test migration for `InputDecorator`. Step 1: #142981 Step 2: #143369 Step 3: #143520 Step 4: #144169 Step 5: #144932 Step 6: #145213 ## Related Issue Related to #139076 @justinmc The diff is not very readable. The tests added by this PR are from line 298 to line 975. Other changes are due to moving some existing tests to this new 'container' group.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates
InputDecoratorhelper/counter/error related tests to M3 and adds some missing tests.It is the fifth step for the M3 test migration for
InputDecorator.Step 1: #142981
Step 2: #143369
Step 3: #143520
Step 4: #144169
Related Issue
Related to #139076
fixes #138213