Write Tests for API Example of `form.0.dart` #142635

piedcipher · 2024-01-31T20:03:15Z

Write Tests for API Example of form.0.dart.

Part of #130459

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

piedcipher · 2024-02-01T15:11:05Z

removed my version of text_button_0_test.dart as it is already added in #141818

Renzo-Olivares

LGTM, you should probably rebase to fix the failing tests, they seem unrelated. Thanks for the contribution!

piedcipher · 2024-02-01T20:32:54Z

LGTM, you should probably rebase to fix the failing tests, they seem unrelated. Thanks for the contribution!

sure, done. seems flaky, same checks are failing in my other pr.

MitchellGoodwin

LGTM! Thank you for putting this together.

piedcipher · 2024-02-01T21:16:15Z

LGTM! Thank you for putting this together.

LGTM, you should probably rebase to fix the failing tests, they seem unrelated. Thanks for the contribution!

thanks a lot for the review!

i'll raise a single pr with a bunch of tests in future for this particular issue, was running short on time yesterday hence smol PR

…#142635)

Manual roll Flutter from e02e207 to 0b5cd50 (46 revisions) Manual roll requested by tarrinneal@google.com flutter/flutter@e02e207...0b5cd50 2024-02-05 124896814+BiskupMaik@users.noreply.github.com fix AppBar docs for backgroundColor & foregroundColor (flutter/flutter#142430) 2024-02-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Update gradle lockfiles template" (flutter/flutter#142889) 2024-02-04 barpac02@gmail.com Update gradle lockfiles template (flutter/flutter#140115) 2024-02-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 20742e37e54e to f34c658b9600 (1 revision) (flutter/flutter#142876) 2024-02-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 23763db72272 to 20742e37e54e (1 revision) (flutter/flutter#142850) 2024-02-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from fee02145da8c to 23763db72272 (3 revisions) (flutter/flutter#142848) 2024-02-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9869d47a2736 to fee02145da8c (2 revisions) (flutter/flutter#142847) 2024-02-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 78c63d3c2c68 to 9869d47a2736 (1 revision) (flutter/flutter#142842) 2024-02-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 266d5d0b5588 to 78c63d3c2c68 (1 revision) (flutter/flutter#142836) 2024-02-02 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.2 to 3.24.0 (flutter/flutter#142839) 2024-02-02 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 3.1.6 to 4.0.1 (flutter/flutter#142838) 2024-02-02 jmccandless@google.com Update TextSelectionOverlay (flutter/flutter#142463) 2024-02-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from e29263212bfd to 266d5d0b5588 (5 revisions) (flutter/flutter#142832) 2024-02-02 luccas.clezar@gmail.com Fix CupertinoTextSelectionToolbar clipping (flutter/flutter#138195) 2024-02-02 barpac02@gmail.com Reland "Add support for Gradle Kotlin DSL (#140744)" (flutter/flutter#142752) 2024-02-02 jmccandless@google.com Support navigation during a Cupertino back gesture (flutter/flutter#142248) 2024-02-02 chingjun@google.com Avoid depending on files from build_system/targets other than from top level entrypoints in flutter_tools. (flutter/flutter#142760) 2024-02-02 engine-flutter-autoroll@skia.org Roll Packages from 5b48c44 to d37fb0a (14 revisions) (flutter/flutter#142812) 2024-02-02 32242716+ricardoamador@users.noreply.github.com Add a link the different possible Android virtual device configs (flutter/flutter#142765) 2024-02-02 15619084+vashworth@users.noreply.github.com Allow all iOS tests to use either iOS 16 or 17 (flutter/flutter#142714) 2024-02-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from b35153d00b2e to e29263212bfd (2 revisions) (flutter/flutter#142799) 2024-02-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from dd4c79a6c864 to b35153d00b2e (10 revisions) (flutter/flutter#142783) 2024-02-02 jacksongardner@google.com Wasm/JS Dual Compile with the flutter tool (flutter/flutter#141396) 2024-02-02 hans.muller@gmail.com Reland: Added ButtonStyle.foregroundBuilder and ButtonStyle.backgroundBuilder (flutter/flutter#142762) 2024-02-01 32242716+ricardoamador@users.noreply.github.com Use proto name for emulator version and show cipd package version (flutter/flutter#142262) 2024-02-01 xilaizhang@google.com [github actions] ping actor of workflow on cherry pick pr creation (flutter/flutter#142676) 2024-02-01 fluttergithubbot@gmail.com Marks Linux_android_emu android views to be unflaky (flutter/flutter#142590) 2024-02-01 nathan.wilson1232@gmail.com Implement `switch` expressions in `lib/src/material/` (flutter/flutter#142634) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9beb7e82e081 to dd4c79a6c864 (1 revision) (flutter/flutter#142749) 2024-02-01 pateltirth454@gmail.com Write Tests for API Example of `form.0.dart` (flutter/flutter#142635) 2024-02-01 polinach@google.com Make leak_tracking bots sticked to the left even if bot thinks they are non-flacky. (flutter/flutter#142744) 2024-02-01 15619084+vashworth@users.noreply.github.com Upload DerivedData logs in CI (flutter/flutter#142643) 2024-02-01 magder@google.com Test codesigning xcframeworks in artifacts (flutter/flutter#142666) 2024-02-01 davidmartos96@gmail.com Fix gen_defaults test randomness (flutter/flutter#142743) 2024-02-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Added ButtonStyle.foregroundBuilder and ButtonStyle.backgroundBuilder" (flutter/flutter#142748) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39415c3eed42 to 9beb7e82e081 (5 revisions) (flutter/flutter#142745) 2024-02-01 magder@google.com Remove unused deprecated autoroll mirror-remote flag (flutter/flutter#142738) 2024-02-01 polinach@google.com Fix leaks in tests. (flutter/flutter#142677) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8c43332c6ffc to 39415c3eed42 (1 revision) (flutter/flutter#142740) 2024-02-01 magder@google.com Remove verbose-system-logs on iOS perf tests (flutter/flutter#142739) 2024-02-01 magder@google.com Remove outdated arm64_armv7 check (flutter/flutter#142737) 2024-02-01 62812903+sstasi95@users.noreply.github.com fix CupertinoTabView's Android back button handling with PopScope (flutter/flutter#141604) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 68943afd62d1 to 8c43332c6ffc (8 revisions) (flutter/flutter#142726) 2024-02-01 christopherfujino@gmail.com Unpin test (flutter/flutter#141427) ...

…#142635)

piedcipher added 3 commits February 1, 2024 01:29

Create form.0_test.dart

67682cf

Create text_button.0_test.dart

a634733

Update check_code_samples.dart

7a01801

github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Jan 31, 2024

piedcipher changed the title ~~Write Tests for API Examples of text_button.0.dart & form.0.dart~~ Write Tests for API Example of form.0.dart Feb 1, 2024

Delete examples/api/test/material/text_button/text_button.0_test.dart

082520b

github-actions bot removed the a: text input Entering text in a text field or keyboard related problems label Feb 1, 2024

piedcipher added 2 commits February 1, 2024 20:12

Update check_code_samples.dart

b94183e

Merge branch 'master' into example_missing_test

555df06

Renzo-Olivares approved these changes Feb 1, 2024

View reviewed changes

Merge branch 'master' into example_missing_test

1622bcd

MitchellGoodwin approved these changes Feb 1, 2024

View reviewed changes

Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 1, 2024

auto-submit bot merged commit 10e4f26 into flutter:master Feb 1, 2024

piedcipher deleted the example_missing_test branch February 1, 2024 22:05

engine-flutter-autoroll mentioned this pull request Feb 2, 2024

Roll Flutter from e02e2079bea7 to 6cc4edb96f4e (25 revisions) flutter/packages#6036

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024

10e4f26 Write Tests for API Example of form.0.dart (flutter/flutter…

f038efe

…#142635)

engine-flutter-autoroll mentioned this pull request Feb 2, 2024

Roll Flutter from e02e2079bea7 to 10e6f4bd6077 (26 revisions) flutter/packages#6037

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024

10e4f26 Write Tests for API Example of form.0.dart (flutter/flutter…

dd167c3

…#142635)

engine-flutter-autoroll mentioned this pull request Feb 2, 2024

Roll Flutter from e02e2079bea7 to 3f30dc2e0a39 (28 revisions) flutter/packages#6039

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024

10e4f26 Write Tests for API Example of form.0.dart (flutter/flutter…

53d8a0a

…#142635)

engine-flutter-autoroll mentioned this pull request Feb 2, 2024

Roll Flutter from e02e2079bea7 to b209125d11af (29 revisions) flutter/packages#6040

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024

10e4f26 Write Tests for API Example of form.0.dart (flutter/flutter…

a3ed9a0

…#142635)

engine-flutter-autoroll mentioned this pull request Feb 2, 2024

Roll Flutter from e02e2079bea7 to ac7879e2aa6d (30 revisions) flutter/packages#6041

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024

10e4f26 Write Tests for API Example of form.0.dart (flutter/flutter…

507fbdb

…#142635)

engine-flutter-autoroll mentioned this pull request Feb 2, 2024

Manual roll Flutter from e02e2079bea7 to ac7879e2aa6d (30 revisions) flutter/packages#6042

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024

10e4f26 Write Tests for API Example of form.0.dart (flutter/flutter…

ee07dc9

…#142635)

engine-flutter-autoroll mentioned this pull request Feb 3, 2024

Roll Flutter from e02e2079bea7 to f6fb563b15be (42 revisions) flutter/packages#6045

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2024

10e4f26 Write Tests for API Example of form.0.dart (flutter/flutter…

ff4f615

…#142635)

engine-flutter-autoroll mentioned this pull request Feb 3, 2024

Roll Flutter from e02e2079bea7 to f6fb563b15be (42 revisions) flutter/packages#6046

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2024

10e4f26 Write Tests for API Example of form.0.dart (flutter/flutter…

c4ef4ba

…#142635)

engine-flutter-autoroll mentioned this pull request Feb 4, 2024

Roll Flutter from e02e2079bea7 to f8a77225f360 (45 revisions) flutter/packages#6047

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2024

10e4f26 Write Tests for API Example of form.0.dart (flutter/flutter…

79a7928

…#142635)

engine-flutter-autoroll mentioned this pull request Feb 4, 2024

Roll Flutter from e02e2079bea7 to f8a77225f360 (45 revisions) flutter/packages#6048

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2024

10e4f26 Write Tests for API Example of form.0.dart (flutter/flutter…

4416972

…#142635)

engine-flutter-autoroll mentioned this pull request Feb 5, 2024

Roll Flutter from e02e2079bea7 to 0b5cd5073a3b (46 revisions) flutter/packages#6052

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2024

10e4f26 Write Tests for API Example of form.0.dart (flutter/flutter…

07ceda1

…#142635)

engine-flutter-autoroll mentioned this pull request Feb 5, 2024

Manual roll Flutter from e02e2079bea7 to 0b5cd5073a3b (46 revisions) flutter/packages#6053

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2024

10e4f26 Write Tests for API Example of form.0.dart (flutter/flutter…

4f9f4cf

…#142635)

engine-flutter-autoroll mentioned this pull request Feb 5, 2024

Roll Flutter from e02e2079bea7 to 0b5cd5073a3b (46 revisions) flutter/packages#6054

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2024

10e4f26 Write Tests for API Example of form.0.dart (flutter/flutter…

9153c37

…#142635)

engine-flutter-autoroll mentioned this pull request Feb 5, 2024

Roll Flutter from e02e2079bea7 to cbc18b2c51ca (47 revisions) flutter/packages#6055

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2024

10e4f26 Write Tests for API Example of form.0.dart (flutter/flutter…

56cc374

…#142635)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

10e4f26 Write Tests for API Example of form.0.dart (flutter/flutter…

431248f

…#142635)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Write Tests for API Example of `form.0.dart` #142635

Write Tests for API Example of `form.0.dart` #142635

Uh oh!

piedcipher commented Jan 31, 2024 •

edited

Loading

Uh oh!

piedcipher commented Feb 1, 2024 •

edited

Loading

Uh oh!

Renzo-Olivares left a comment •

edited

Loading

Uh oh!

piedcipher commented Feb 1, 2024

Uh oh!

MitchellGoodwin left a comment

Uh oh!

piedcipher commented Feb 1, 2024

Uh oh!

Uh oh!

Write Tests for API Example of form.0.dart #142635

Write Tests for API Example of form.0.dart #142635

Uh oh!

Conversation

piedcipher commented Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

piedcipher commented Feb 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Renzo-Olivares left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

piedcipher commented Feb 1, 2024

Uh oh!

MitchellGoodwin left a comment

Choose a reason for hiding this comment

Uh oh!

piedcipher commented Feb 1, 2024

Uh oh!

Uh oh!

Write Tests for API Example of `form.0.dart` #142635

Write Tests for API Example of `form.0.dart` #142635

piedcipher commented Jan 31, 2024 •

edited

Loading

piedcipher commented Feb 1, 2024 •

edited

Loading

Renzo-Olivares left a comment •

edited

Loading