Add check for Bank of Brazil security module to Windows Flutter Doctor validators #141135

yaakovschectman · 2024-01-08T21:23:03Z

Add a warning to Flutter Doctor if Topaz OFD is found as a process on the system.
The protection module used by the Bank of Brazil has been identified as causing build failures when using VS with CMake for Windows (see #121366 (comment)). Disabling the software allows the build to succeed again.

If a running process is found by flutter doctor whose path contains Topaz OFD\Warsaw\core.exe, a warning message is generated to convey this.

Addresses #121366

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gspencergoog

zanderso · 2024-01-08T22:38:04Z

packages/flutter_tools/lib/src/windows/topaz_ofd_validator.dart

+class ProcessLister {
+  Future<String> getProcessesWithPath(String? filter) async {
+    final String argument = filter == null ? 'Get-Process $filter | Format-List Path' : 'Get-Process | Format-List Path';
+    final ProcessResult taskResult = await Process.run('powershell', <String>['-command', argument]);


Could the subprocess fail with an error code? How should that be handled?

What are your thoughts on returning partial with a message indicating that the check failed when the exit code is non-zero?

Looking at some of the other examples, I think missing might make more sense? Wondering if @christopherfujino has an opinion.

Yeah, I think missing, because we'd want to investigate further and see if this approach is not robust for all windows setups.

So missing when the exit code is nonzero, but is partial still desired for when Topaz is found?

I think missing in both cases. In my mind, partial is just if a validator has sub-validators, with mixed results.

packages/flutter_tools/lib/src/windows/topaz_ofd_validator.dart

christopherfujino · 2024-01-09T18:34:03Z

packages/flutter_tools/lib/src/windows/topaz_ofd_validator.dart

+class ProcessLister {
+  Future<String> getProcessesWithPath(String? filter) async {
+    final String argument = filter != null ? 'Get-Process $filter | Format-List Path' : 'Get-Process | Format-List Path';
+    final ProcessResult taskResult = await Process.run('powershell', <String>['-command', argument]);


Also, please use the ProcessManager class, and not directly invoking the static Process.run method

christopherfujino · 2024-01-09T18:35:05Z

packages/flutter_tools/lib/src/windows/topaz_ofd_validator.dart

+import '../base/io.dart';
+import '../doctor_validator.dart';
+
+const String kCoreProcessPattern = r'Topaz OFD\\Warsaw\\core.exe';


if this is a regex, you need to escape the . too

packages/flutter_tools/lib/src/windows/topaz_ofd_validator.dart

…or.dart Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

eliasyishak

LGTM after @loic-sharma's comments are finished! Thank you for refactoring

yaakovschectman · 2024-01-17T19:17:04Z

@christopherfujino With Elias' approval submitted, do you have any remaining concerns or requests blocking this merge?

christopherfujino

LGTM

packages/flutter_tools/lib/src/windows/windows_version_validator.dart

loic-sharma

LGTM, thanks!

…or.dart Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

…er Doctor validators (flutter/flutter#141135)

Manual roll Flutter from f77f824 to 684247a (39 revisions) Manual roll requested by dit@google.com flutter/flutter@f77f824...684247a 2024-01-19 reidbaker@google.com Use Integer instead of int in map in flutter.groovy (flutter/flutter#141895) 2024-01-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from c953c83112ba to f2b441a26416 (4 revisions) (flutter/flutter#141894) 2024-01-19 dacoharkes@google.com Native assets: package in framework on iOS and MacOS (flutter/flutter#140907) 2024-01-19 ian@hixie.ch Revert "Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal (#140101)" (flutter/flutter#141814) 2024-01-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 538975f2511b to c953c83112ba (3 revisions) (flutter/flutter#141886) 2024-01-19 36861262+QuncCccccc@users.noreply.github.com Add `showDragHandle` to `showBottomSheet` (flutter/flutter#141754) 2024-01-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9a6c64de8a46 to 538975f2511b (8 revisions) (flutter/flutter#141881) 2024-01-19 goderbauer@google.com Make pumpWidget's arguments named (flutter/flutter#141728) 2024-01-19 5236035+fzyzcjy@users.noreply.github.com Tiny fix inaccurate documentations about bindings (flutter/flutter#140282) 2024-01-19 zanderso@users.noreply.github.com Roll engine to 9a6c64de8a4694cef59a338cd33ac1a9e7d23d9d (flutter/flutter#141870) 2024-01-19 engine-flutter-autoroll@skia.org Roll Packages from 83c2c4d to 129e08c (13 revisions) (flutter/flutter#141865) 2024-01-19 godofredoc@google.com Add mac_x64_ios configuration. (flutter/flutter#141828) 2024-01-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 90be25d8aac3 to d1afda52d254 (1 revision) (flutter/flutter#141825) 2024-01-19 ian@hixie.ch Move the requestKeyboard up to the widgets layer (flutter/flutter#141655) 2024-01-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from dde3ebf6551a to 90be25d8aac3 (1 revision) (flutter/flutter#141817) 2024-01-18 yjbanov@google.com enable more tests in web mode (flutter/flutter#141791) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9dded186bcff to dde3ebf6551a (2 revisions) (flutter/flutter#141811) 2024-01-18 davidmartos96@gmail.com Update margin between label and icon in Tab to better reflect Material specs (flutter/flutter#140698) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3106e08e1219 to 9dded186bcff (2 revisions) (flutter/flutter#141807) 2024-01-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Enable native compilation for windows-arm64 " (flutter/flutter#141809) 2024-01-18 godofredoc@google.com Run framework_tests_misc in arm64 and x64. (flutter/flutter#141797) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from f4a4f046b173 to 3106e08e1219 (1 revision) (flutter/flutter#141802) 2024-01-18 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.1.0 to 4.2.0 (flutter/flutter#141803) 2024-01-18 goderbauer@google.com Update labeler.yml (flutter/flutter#141697) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 75400c49fa0b to f4a4f046b173 (2 revisions) (flutter/flutter#141800) 2024-01-18 polinach@google.com Reland "Remove hack from PageView." (flutter/flutter#141533) 2024-01-18 smartercallum@gmail.com ScaleGestureRecognizer pointerCount=2 for trackpad gestures (flutter/flutter#140745) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from de68e7612948 to 75400c49fa0b (2 revisions) (flutter/flutter#141796) 2024-01-18 15619084+vashworth@users.noreply.github.com Run `flutter_gallery_ios__start_up` test on Mac-14 in staging (flutter/flutter#141795) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from d80fe1cb5854 to de68e7612948 (1 revision) (flutter/flutter#141789) 2024-01-18 101587250+pbo-linaro@users.noreply.github.com Enable native compilation for windows-arm64 (flutter/flutter#137618) 2024-01-18 xilaizhang@google.com [github actions] Fix token issue on actions/checkout package (flutter/flutter#141652) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from b75d6d80d813 to d80fe1cb5854 (2 revisions) (flutter/flutter#141785) 2024-01-18 jesus_sguerrero@hotmail.com Revert "Native assets: roll deps" (flutter/flutter#141748) 2024-01-18 6655696+guidezpl@users.noreply.github.com Deprecate M2 curves (flutter/flutter#134417) 2024-01-18 rmolivares@renzo-olivares.dev Fix: TextField can inherit `errorStyle` from `InputDecorationTheme`. (flutter/flutter#141227) 2024-01-18 109111084+yaakovschectman@users.noreply.github.com Add check for Bank of Brazil security module to Windows Flutter Doctor validators (flutter/flutter#141135) 2024-01-18 reidbaker@google.com Fix gradle lints No semantic change should be present. (flutter/flutter#141692) 2024-01-18 engine-flutter-autoroll@skia.org Roll Packages from 1a2b780 to 83c2c4d (5 revisions) (flutter/flutter#141778) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human ...

yaakovschectman added 3 commits January 8, 2024 13:19

Add OFD val

9f2fd72

Test validator

9fac040

Licenses

27ac390

yaakovschectman self-assigned this Jan 8, 2024

github-actions bot removed the a: internationalization Supporting other languages or locales. (aka i18n) label Jan 8, 2024

Formatting

398cf37

yaakovschectman requested review from vashworth, eliasyishak, cbracken, loic-sharma, zanderso and gspencergoog January 8, 2024 21:59

gspencergoog approved these changes Jan 8, 2024

View reviewed changes

zanderso reviewed Jan 8, 2024

View reviewed changes

eliasyishak reviewed Jan 9, 2024

View reviewed changes

packages/flutter_tools/lib/src/windows/topaz_ofd_validator.dart Outdated Show resolved Hide resolved

yaakovschectman and others added 2 commits January 9, 2024 08:26

Feedback

815f733

Merge branch 'master' into topaz_validator

d28683e

yaakovschectman marked this pull request as ready for review January 9, 2024 15:06

christopherfujino reviewed Jan 9, 2024

View reviewed changes

christopherfujino suggested changes Jan 9, 2024

View reviewed changes

packages/flutter_tools/lib/src/windows/topaz_ofd_validator.dart Outdated Show resolved Hide resolved

PR Feedback

ec27c0c

christopherfujino reviewed Jan 9, 2024

View reviewed changes

packages/flutter_tools/lib/src/windows/topaz_ofd_validator.dart Outdated Show resolved Hide resolved

Inject ProcessManager

fc865a7

Update packages/flutter_tools/lib/src/windows/windows_version_validat…

6066d88

…or.dart Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

eliasyishak approved these changes Jan 16, 2024

View reviewed changes

Merge branch 'master' into topaz_validator

a974782

christopherfujino approved these changes Jan 17, 2024

View reviewed changes

Update regex

bca7d6a

loic-sharma reviewed Jan 17, 2024

View reviewed changes

packages/flutter_tools/lib/src/windows/windows_version_validator.dart Outdated Show resolved Hide resolved

loic-sharma approved these changes Jan 17, 2024

View reviewed changes

yaakovschectman and others added 3 commits January 18, 2024 10:21

Update packages/flutter_tools/lib/src/windows/windows_version_validat…

4a68cbf

…or.dart Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

Merge branch 'master' into topaz_validator

ffcb32d

Update test to message

ee9ae5d

yaakovschectman merged commit 3123d98 into flutter:master Jan 18, 2024

engine-flutter-autoroll mentioned this pull request Jan 19, 2024

Roll Flutter from f77f82435a97 to c95bb6fbb33a (28 revisions) flutter/packages#5939

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2024

3123d98 Add check for Bank of Brazil security module to Windows Flutt…

2ea9d4b

…er Doctor validators (flutter/flutter#141135)

engine-flutter-autoroll mentioned this pull request Jan 19, 2024

Roll Flutter from f77f82435a97 to 0487931ac208 (29 revisions) flutter/packages#5940

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2024

3123d98 Add check for Bank of Brazil security module to Windows Flutt…

f4dc3fa

…er Doctor validators (flutter/flutter#141135)

engine-flutter-autoroll mentioned this pull request Jan 19, 2024

Roll Flutter from f77f82435a97 to d4707d12d5b6 (30 revisions) flutter/packages#5942

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2024

3123d98 Add check for Bank of Brazil security module to Windows Flutt…

9fb164d

…er Doctor validators (flutter/flutter#141135)

engine-flutter-autoroll mentioned this pull request Jan 19, 2024

Roll Flutter from f77f82435a97 to 9e024fdf3122 (31 revisions) flutter/packages#5943

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2024

3123d98 Add check for Bank of Brazil security module to Windows Flutt…

2e04895

…er Doctor validators (flutter/flutter#141135)

engine-flutter-autoroll mentioned this pull request Jan 19, 2024

Roll Flutter from f77f82435a97 to cc544169be01 (32 revisions) flutter/packages#5945

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2024

3123d98 Add check for Bank of Brazil security module to Windows Flutt…

eaacaa5

…er Doctor validators (flutter/flutter#141135)

engine-flutter-autoroll mentioned this pull request Jan 19, 2024

Roll Flutter from f77f82435a97 to 3563372f0670 (33 revisions) flutter/packages#5946

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2024

3123d98 Add check for Bank of Brazil security module to Windows Flutt…

0090caa

…er Doctor validators (flutter/flutter#141135)

HansMuller mentioned this pull request Jan 19, 2024

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll mentioned this pull request Jan 19, 2024

Manual roll Flutter from f77f82435a97 to 684247a3c78a (39 revisions) flutter/packages#5948

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2024

3123d98 Add check for Bank of Brazil security module to Windows Flutt…

04fe30b

…er Doctor validators (flutter/flutter#141135)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add check for Bank of Brazil security module to Windows Flutter Doctor validators #141135

Add check for Bank of Brazil security module to Windows Flutter Doctor validators #141135

Uh oh!

yaakovschectman commented Jan 8, 2024

Uh oh!

gspencergoog left a comment

Uh oh!

zanderso Jan 8, 2024

Uh oh!

yaakovschectman Jan 9, 2024

Uh oh!

zanderso Jan 9, 2024

Uh oh!

christopherfujino Jan 9, 2024

Uh oh!

yaakovschectman Jan 9, 2024

Uh oh!

christopherfujino Jan 9, 2024

Uh oh!

Uh oh!

christopherfujino Jan 9, 2024

Uh oh!

christopherfujino Jan 9, 2024

Uh oh!

Uh oh!

Uh oh!

eliasyishak left a comment

Uh oh!

yaakovschectman commented Jan 17, 2024

Uh oh!

christopherfujino left a comment

Uh oh!

Uh oh!

loic-sharma left a comment

Uh oh!

Uh oh!

Add check for Bank of Brazil security module to Windows Flutter Doctor validators #141135

Add check for Bank of Brazil security module to Windows Flutter Doctor validators #141135

Uh oh!

Conversation

yaakovschectman commented Jan 8, 2024

Pre-launch Checklist

Uh oh!

gspencergoog left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

eliasyishak left a comment

Choose a reason for hiding this comment

Uh oh!

yaakovschectman commented Jan 17, 2024

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

loic-sharma left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!