Skip to content

Move mock canvas to flutter_test #131631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 7, 2023
Merged

Move mock canvas to flutter_test #131631

merged 3 commits into from
Aug 7, 2023

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Jul 31, 2023

Fixes #59413

This relocates mock_canvas.dart and recording_canvas.dart from flutter/test/rendering to flutter_test.

The testing functionality afforded by mock_canvas should be available to everyone, not just the framework. :)

mock_canvas.dart needed a bit of cleanup - things like formatting and super parameters.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests c: new feature Nothing broken; request for a new capability framework flutter/packages/flutter repository. See also f: labels. a: quality A truly polished experience labels Jul 31, 2023
@Piinks Piinks requested a review from pdblasi-google July 31, 2023 20:57
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository f: routes Navigator, Router, and related APIs. labels Jul 31, 2023
@Piinks Piinks mentioned this pull request Jul 31, 2023
Merged
4 tasks
@Piinks
Copy link
Contributor Author

Piinks commented Jul 31, 2023

macosui/macos_ui#467 is out to resolve the customer failure here.

Piinks added a commit to flutter/tests that referenced this pull request Jul 31, 2023
@Piinks
Update macos_ui.test
edbaba5 
Updates commit for macosui/macos_ui#467 which unblocks flutter/flutter#131631
@Piinks Piinks mentioned this pull request Jul 31, 2023
Merged
8 tasks
pdblasi-google
pdblasi-google reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@pdblasi-google pdblasi-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Added a couple suggestions for awkwardly worded messages, and had one question.

@Piinks
Copy link
Contributor Author

Piinks commented Aug 2, 2023

Customer failure should be resolved now. 👍

@Piinks Piinks requested a review from pdblasi-google August 2, 2023 19:37
pdblasi-google
pdblasi-google approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@pdblasi-google pdblasi-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI passing.

@Piinks
Copy link
Contributor Author

Piinks commented Aug 2, 2023

Ah, it looks like I resolved an analysis error in customer testing, and now that analysis is passing I have a compilation error. One sec. 😉

@Piinks Piinks mentioned this pull request Aug 2, 2023
Merged
4 tasks
@Piinks
Copy link
Contributor Author

Piinks commented Aug 2, 2023

Pending macosui/macos_ui#468 and an update in flutter/tests

@Piinks Piinks mentioned this pull request Aug 2, 2023
Open
Piinks added a commit to flutter/tests that referenced this pull request Aug 7, 2023
@Piinks
Update macos_ui.test
3955ece 
Updates to include macosui/macos_ui#468 in order to unblock flutter/flutter#131631
@Piinks Piinks mentioned this pull request Aug 7, 2023
Merged
8 tasks
auto-submit bot pushed a commit to flutter/tests that referenced this pull request Aug 7, 2023
@Piinks
Update macos_ui.test (#284)
7ac5a66 
Updates to include macosui/macos_ui#468 in order to unblock flutter/flutter#131631

FYI @GroovinChip
Piinks and others added 3 commits August 7, 2023 13:52
@Piinks
MMove mock canvas to flutter_test
28a4d1d
@Piinks
Fix analyzer
845b609
@Piinks @pdblasi-google
Apply suggestions from code review
73c5ff2 
Co-authored-by: pdblasi-google <109253501+pdblasi-google@users.noreply.github.com>
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2023
@auto-submit auto-submit bot merged commit f054f5a into flutter:master Aug 7, 2023
@TahaTesser
Copy link
Member

The testing functionality afforded by mock_canvas should be available to everyone, not just the framework. :)

Thank you so much! I totally agree.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 8, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2023
@engine-flutter-autoroll
f054f5a Move mock canvas to flutter_test (flutter/flutter#131631)
309a067
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 8, 2023
@engine-flutter-autoroll
Roll Flutter from ad0aa8d to 436df69 (17 revisions) (#4663)
ac41376 
flutter/flutter@ad0aa8d...436df69

2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9c83d90b01bd to 146c4c9487fc (6 revisions) (flutter/flutter#132112)
2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from c27109291e22 to 9c83d90b01bd (5 revisions) (flutter/flutter#132108)
2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from be085f6699b6 to c27109291e22 (3 revisions) (flutter/flutter#132086)
2023-08-08 jesus_sguerrero@hotmail.com Revert "Replace TextField.canRequestFocus with TextField.focusNode.canRequestFocus" (flutter/flutter#132104)
2023-08-08 jonahwilliams@google.com [Impeller] add drawVertices and drawAtlas benchmarks. (flutter/flutter#132080)
2023-08-07 47866232+chunhtai@users.noreply.github.com Adds more documentations around ignoreSemantics deprecations. (flutter/flutter#131287)
2023-08-07 mdebbar@google.com [web] New HtmlElementView.fromTagName constructor (flutter/flutter#130513)
2023-08-07 katelovett@google.com Move mock canvas to flutter_test (flutter/flutter#131631)
2023-08-07 matej.knopp@gmail.com Add static_path_tessellation macrobenchmark (flutter/flutter#131837)
2023-08-07 mdebbar@google.com [web] Remove usage of `ui.webOnlyInitializePlatform()` (flutter/flutter#131344)
2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39a575f65d50 to be085f6699b6 (1 revision) (flutter/flutter#132069)
2023-08-07 jmccandless@google.com Android context menu theming and visual update (flutter/flutter#131816)
2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39ce1c097bce to 39a575f65d50 (2 revisions) (flutter/flutter#132064)
2023-08-07 xhzq233@qq.com CupertinoContextMenu improvement (flutter/flutter#131030)
2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5b47c0577060 to 39ce1c097bce (3 revisions) (flutter/flutter#132057)
2023-08-07 xming@google.com Slider should check `mounted` before start interaction (flutter/flutter#132010)
2023-08-07 engine-flutter-autoroll@skia.org Roll Packages from ce53da1 to d7ee75a (7 revisions) (flutter/flutter#132058)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@HansMuller HansMuller mentioned this pull request Aug 11, 2023
Closed
@Piinks Piinks mentioned this pull request Aug 17, 2023
Closed
@Piinks Piinks mentioned this pull request Oct 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
f054f5a Move mock canvas to flutter_test (flutter/flutter#131631)
4ce956f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdblasi-google pdblasi-google pdblasi-google approved these changes

Assignees
No one assigned
Labels
a: quality A truly polished experience a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App c: new feature Nothing broken; request for a new capability f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move mock_canvas to flutter_test package
3 participants
@Piinks @TahaTesser @pdblasi-google