fixed PreferredSize constuctor invocations #128181

yeasin50 · 2023-06-03T19:54:20Z

This PR changes the PreferredSize constructor parameter positioning to cover the constructor invocations. It helps on auto-complete and suggestion.

List which issues are fixed by this PR. You must list at least one issue.
Fixes #128178

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2023-06-03T19:54:22Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

google-cla · 2023-06-03T19:54:23Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

TahaTesser

LGTM

TahaTesser · 2023-06-05T07:35:56Z

@yeasin50

— ❌ Missing CLA from one or more contributors

Can you sign CLA? This is required to land this PR.

This will also need a test-exemption from @Hixie

TahaTesser · 2023-06-05T10:26:17Z

@yeasin50
If you've signed CLA, please rebase this PR with the master branch. CLA check needs to pass.

yeasin50 · 2023-06-05T16:02:07Z

@TahaTesser Thanks for the guidance.

Hixie · 2023-06-05T18:03:40Z

test-exempt: code refactor with no semantic change

goderbauer · 2023-06-06T22:26:16Z

I wonder why this wasn't caught by the sort_child_properties_last lint...

goderbauer

LGTM

TahaTesser · 2023-06-14T08:44:38Z

@yeasin50
Can you please rebase the PR? It looks like this has some new conflicts.

auto-submit · 2023-06-14T17:11:09Z

auto label is removed for flutter/flutter, pr: 128181, due to - The status or check suite Windows framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux web_canvaskit_tests_1 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux web_tests_7_last has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

TahaTesser · 2023-06-14T17:50:20Z

@yeasin50
Looks like you've made unintended changes. Please revert to those changes and rebase the branch.

yeasin50 · 2023-06-21T01:52:06Z

Thank you, @TahaTesser, for all the instruction.

…28181)

Manual version of #4269 ---- Roll Flutter from fc8856e to c40baf4 (57 revisions) flutter/flutter@fc8856e...c40baf4 2023-06-21 engine-flutter-autoroll@skia.org Roll Packages from 6e1918f to 0fdf05f (8 revisions) (flutter/flutter#129286) 2023-06-21 christopherfujino@gmail.com move test ownership from zanderso -> tools team (flutter/flutter#129199) 2023-06-21 42216813+eliasyishak@users.noreply.github.com Refactor `Analytics` global getter to point to context only (flutter/flutter#129196) 2023-06-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from cfbd3652532d to f973fb4636d3 (1 revision) (flutter/flutter#129253) 2023-06-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 059643dcc8e3 to cfbd3652532d (1 revision) (flutter/flutter#129243) 2023-06-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5313ca367549 to 059643dcc8e3 (1 revision) (flutter/flutter#129240) 2023-06-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 946f523859fe to 5313ca367549 (2 revisions) (flutter/flutter#129234) 2023-06-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from e5a860c5479c to 946f523859fe (2 revisions) (flutter/flutter#129232) 2023-06-21 31859944+LongCatIsLooong@users.noreply.github.com Relax `OverlayPortal` asserts (flutter/flutter#129053) 2023-06-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from adfc3af300a9 to e5a860c5479c (3 revisions) (flutter/flutter#129228) 2023-06-21 godofredoc@google.com Move all the firebase lab device configs to .ci.yaml. (flutter/flutter#129219) 2023-06-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7d4abb81ccd1 to adfc3af300a9 (2 revisions) (flutter/flutter#129225) 2023-06-20 andrewrkolos@gmail.com update resolution-aware asset docs links (flutter/flutter#128769) 2023-06-20 jmccandless@google.com Fix: Magnifier appears and won't dismiss (flutter/flutter#128545) 2023-06-20 thkim1011@users.noreply.github.com DecoratedSliver (flutter/flutter#127823) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 666244148e89 to 7d4abb81ccd1 (1 revision) (flutter/flutter#129217) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 06d0c08460e5 to 666244148e89 (2 revisions) (flutter/flutter#129208) 2023-06-20 yeasinsheikh50@gmail.com fixed PreferredSize constuctor invocations (flutter/flutter#128181) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1c16af76ca26 to 06d0c08460e5 (3 revisions) (flutter/flutter#129200) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from ec64672afd91 to 1c16af76ca26 (1 revision) (flutter/flutter#129197) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4444ede34a9c to ec64672afd91 (3 revisions) (flutter/flutter#129194) 2023-06-20 15619084+vashworth@users.noreply.github.com Fix duplicate devices from xcdevice with iOS 17 (flutter/flutter#128802) 2023-06-20 ychris@google.com iOS info.plist template: make UIViewControllerBasedStatusBar to be true (flutter/flutter#128970) 2023-06-20 whesse@google.com Fix detection that tests are running on monorepo bots (flutter/flutter#129173) 2023-06-20 chingjun@google.com Use the new `getIsolatePauseEvent` method from VM service to check for pause event. (flutter/flutter#128834) 2023-06-20 31922733+SwaroopSambhayya@users.noreply.github.com Adding ScrollController support for Stepper widget (flutter/flutter#128814) 2023-06-20 engine-flutter-autoroll@skia.org Roll Packages from 59d93d6 to 6e1918f (6 revisions) (flutter/flutter#129176) 2023-06-20 thkim1011@users.noreply.github.com Refactor generate_localizations_test.dart (flutter/flutter#128974) 2023-06-20 kevinjchisholm@google.com [process] Add a design doc issue template. (flutter/flutter#128361) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from bd6d3fc90462 to 4444ede34a9c (1 revision) (flutter/flutter#129169) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 73c4ba4240cc to bd6d3fc90462 (1 revision) (flutter/flutter#129168) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7ee874792067 to 73c4ba4240cc (1 revision) (flutter/flutter#129162) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6a6c8fb591f5 to 7ee874792067 (1 revision) (flutter/flutter#129160) 2023-06-20 leigha.jarett@gmail.com Add to API docs to explain what Assist and Suggestion chips are (flutter/flutter#129034) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from a91bb3f566b9 to 6a6c8fb591f5 (1 revision) (flutter/flutter#129158) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from e0d456d9251b to a91bb3f566b9 (1 revision) (flutter/flutter#129148) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 55418e648958 to e0d456d9251b (1 revision) (flutter/flutter#129146) 2023-06-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 84ecaa053ec6 to 55418e648958 (1 revision) (flutter/flutter#129145) 2023-06-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 23a2c246600f to 84ecaa053ec6 (2 revisions) (flutter/flutter#129142) 2023-06-19 tessertaha@gmail.com Introduce MaterialState `color` property for chips (flutter/flutter#128584) 2023-06-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 280491d4cc21 to 23a2c246600f (8 revisions) (flutter/flutter#129140) 2023-06-19 jason-simmons@users.noreply.github.com Fix an ordering dependency in the flutter_tools upgrade test (flutter/flutter#129131) 2023-06-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 164c6b49dfb5 to 280491d4cc21 (1 revision) (flutter/flutter#129102) 2023-06-19 tessertaha@gmail.com Fix `InputDecoration.applyDefaults` ignoring some properties (flutter/flutter#129010) 2023-06-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from d298f0bf720c to 164c6b49dfb5 (1 revision) (flutter/flutter#129100) 2023-06-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7ffa1355f718 to d298f0bf720c (24 revisions) (flutter/flutter#129092) ... ----

…28181)

flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jun 3, 2023

TahaTesser approved these changes Jun 5, 2023

View reviewed changes

TahaTesser requested a review from Hixie June 5, 2023 07:36

goderbauer approved these changes Jun 6, 2023

View reviewed changes

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2023

ricardoamador added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Jun 13, 2023

github-actions bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) engine flutter/engine repository. See also e: labels. f: material design flutter/packages/flutter/material repository. labels Jun 14, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 14, 2023

yeasin50 force-pushed the fix128178 branch from f1c3c07 to 279c4df Compare June 14, 2023 17:51

github-actions bot removed f: material design flutter/packages/flutter/material repository. engine flutter/engine repository. See also e: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Jun 14, 2023

yeasin50 force-pushed the fix128178 branch from 279c4df to fb6c67d Compare June 14, 2023 17:52

fixed PreferredSize constuctor invocations

da8cd13

yeasin50 force-pushed the fix128178 branch from fb6c67d to da8cd13 Compare June 14, 2023 21:42

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 20, 2023

auto-submit bot merged commit b733901 into flutter:master Jun 20, 2023

engine-flutter-autoroll mentioned this pull request Jun 21, 2023

Roll Flutter from fc8856eb80d3 to c40baf47c5c8 (57 revisions) flutter/packages#4269

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 21, 2023

b733901 fixed PreferredSize constuctor invocations (flutter/flutter#1…

7ede929

…28181)

ditman mentioned this pull request Jun 21, 2023

Roll Flutter from fc8856eb80d3 to c40baf47c5c8 (57 revisions) flutter/packages#4270

Merged

11 tasks

HansMuller mentioned this pull request Jun 30, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

b733901 fixed PreferredSize constuctor invocations (flutter/flutter#1…

55a15e7

…28181)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

b733901 fixed PreferredSize constuctor invocations (flutter/flutter#1…

1d8d1f3

…28181)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

b733901 fixed PreferredSize constuctor invocations (flutter/flutter#1…

4257a4e

…28181)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

b733901 fixed PreferredSize constuctor invocations (flutter/flutter#1…

183f48b

…28181)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fixed PreferredSize constuctor invocations #128181

fixed PreferredSize constuctor invocations #128181

Uh oh!

yeasin50 commented Jun 3, 2023 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Jun 3, 2023

Uh oh!

google-cla bot commented Jun 3, 2023

Uh oh!

TahaTesser left a comment

Uh oh!

TahaTesser commented Jun 5, 2023 •

edited

Loading

Uh oh!

TahaTesser commented Jun 5, 2023 •

edited

Loading

Uh oh!

yeasin50 commented Jun 5, 2023

Uh oh!

Hixie commented Jun 5, 2023

Uh oh!

goderbauer commented Jun 6, 2023

Uh oh!

goderbauer left a comment

Uh oh!

TahaTesser commented Jun 14, 2023

Uh oh!

auto-submit bot commented Jun 14, 2023

Uh oh!

TahaTesser commented Jun 14, 2023

Uh oh!

yeasin50 commented Jun 21, 2023

Uh oh!

Uh oh!

fixed PreferredSize constuctor invocations #128181

fixed PreferredSize constuctor invocations #128181

Uh oh!

Conversation

yeasin50 commented Jun 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Jun 3, 2023

Uh oh!

google-cla bot commented Jun 3, 2023

Uh oh!

TahaTesser left a comment

Choose a reason for hiding this comment

Uh oh!

TahaTesser commented Jun 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TahaTesser commented Jun 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yeasin50 commented Jun 5, 2023

Uh oh!

Hixie commented Jun 5, 2023

Uh oh!

goderbauer commented Jun 6, 2023

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

TahaTesser commented Jun 14, 2023

Uh oh!

auto-submit bot commented Jun 14, 2023

Uh oh!

TahaTesser commented Jun 14, 2023

Uh oh!

yeasin50 commented Jun 21, 2023

Uh oh!

Uh oh!

yeasin50 commented Jun 3, 2023 •

edited

Loading

TahaTesser commented Jun 5, 2023 •

edited

Loading

TahaTesser commented Jun 5, 2023 •

edited

Loading