Skip to content

MinimumTapTargetGuideline skips nodes at scrollable boundaries #124615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 20, 2023
Merged

MinimumTapTargetGuideline skips nodes at scrollable boundaries #124615

merged 3 commits into from
Apr 20, 2023

Conversation

chunhtai
Copy link
Contributor

fixes #107615

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Apr 11, 2023
@chunhtai chunhtai requested a review from pdblasi-google April 11, 2023 19:11
chunhtai
chunhtai commented Apr 17, 2023
View reviewed changes
pdblasi-google
pdblasi-google approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@pdblasi-google pdblasi-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 18, 2023

auto label is removed for flutter/flutter, pr: 124615, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chunhtai
Copy link
Contributor Author

g3fix
cl/525216354

@chunhtai chunhtai merged commit 8ac94c1 into flutter:master Apr 20, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
8ac94c1 MinimumTapTargetGuideline skips nodes at scrollable boundaries (
428e47b 
flutter/flutter#124615)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
8ac94c1 MinimumTapTargetGuideline skips nodes at scrollable boundaries (
38d8d51 
flutter/flutter#124615)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
8ac94c1 MinimumTapTargetGuideline skips nodes at scrollable boundaries (
d132c2b 
flutter/flutter#124615)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
8ac94c1 MinimumTapTargetGuideline skips nodes at scrollable boundaries (
cfc0a4c 
flutter/flutter#124615)
This was referenced Apr 20, 2023
Closed
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
8ac94c1 MinimumTapTargetGuideline skips nodes at scrollable boundaries (
c87ab33 
flutter/flutter#124615)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
8ac94c1 MinimumTapTargetGuideline skips nodes at scrollable boundaries (
8ec3e59 
flutter/flutter#124615)
@reidbaker reidbaker mentioned this pull request Apr 21, 2023
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
8ac94c1 MinimumTapTargetGuideline skips nodes at scrollable boundaries (
e7ad740 
flutter/flutter#124615)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
8ac94c1 MinimumTapTargetGuideline skips nodes at scrollable boundaries (
38ca06a 
flutter/flutter#124615)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
8ac94c1 MinimumTapTargetGuideline skips nodes at scrollable boundaries (
19fedeb 
flutter/flutter#124615)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
8ac94c1 MinimumTapTargetGuideline skips nodes at scrollable boundaries (
083a67c 
flutter/flutter#124615)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
8ac94c1 MinimumTapTargetGuideline skips nodes at scrollable boundaries (
61b271d 
flutter/flutter#124615)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
8ac94c1 MinimumTapTargetGuideline skips nodes at scrollable boundaries (
d43dade 
flutter/flutter#124615)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
8ac94c1 MinimumTapTargetGuideline skips nodes at scrollable boundaries (
90047d6 
flutter/flutter#124615)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
8ac94c1 MinimumTapTargetGuideline skips nodes at scrollable boundaries (
528c530 
flutter/flutter#124615)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
8ac94c1 MinimumTapTargetGuideline skips nodes at scrollable boundaries (
d15995a 
flutter/flutter#124615)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
8ac94c1 MinimumTapTargetGuideline skips nodes at scrollable boundaries (
507b78b 
flutter/flutter#124615)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
8ac94c1 MinimumTapTargetGuideline skips nodes at scrollable boundaries (
6558ae9 
flutter/flutter#124615)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdblasi-google pdblasi-google pdblasi-google approved these changes

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MinimumTapTargetGuideline doesn't work if items are scrolled out of the viewport and the viewport doesn't touch the edge of the screen
2 participants
@chunhtai @pdblasi-google