Skip to content

Ignore one avoid_redundant_argument_values, requires linter fix. #109049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2022
Merged

Ignore one avoid_redundant_argument_values, requires linter fix. #109049

merged 1 commit into from
Aug 5, 2022

Conversation

scheglov
Copy link
Contributor

@scheglov scheglov commented Aug 5, 2022

With https://dart-review.googlesource.com/c/sdk/+/253705 landed, dart-lang/sdk#49596 flakiness is fixed, and now the linter always reports this lint. However semantically it is not quite correct. The behavior of the analyzer itself is correct though. So, for now we should ignore the lint instance, then fix the linter, and then go over the ignores and remove where possible.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. labels Aug 5, 2022
@iskakaushik iskakaushik mentioned this pull request Aug 5, 2022
Closed
iskakaushik
iskakaushik approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iskakaushik iskakaushik added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2022
goderbauer
goderbauer approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit auto-submit bot merged commit 508be6f into flutter:master Aug 5, 2022
@scheglov scheglov deleted the ignore-one-avoid_redundant_argument_values branch August 5, 2022 19:56
This was referenced Aug 6, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2022
@engine-flutter-autoroll
508be6f Ignore one avoid_redundant_argument_values, requires linter f…
c575924 
…ix. (flutter/flutter#109049)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 6, 2022
@engine-flutter-autoroll
508be6f Ignore one avoid_redundant_argument_values, requires linter f…
3bc71a0 
…ix. (flutter/flutter#109049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2022
@engine-flutter-autoroll
508be6f Ignore one avoid_redundant_argument_values, requires linter f…
702e763 
…ix. (flutter/flutter#109049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2022
@engine-flutter-autoroll
508be6f Ignore one avoid_redundant_argument_values, requires linter f…
e52848b 
…ix. (flutter/flutter#109049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 7, 2022
@engine-flutter-autoroll
508be6f Ignore one avoid_redundant_argument_values, requires linter f…
62638d9 
…ix. (flutter/flutter#109049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 7, 2022
@engine-flutter-autoroll
508be6f Ignore one avoid_redundant_argument_values, requires linter f…
747a6a6 
…ix. (flutter/flutter#109049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2022
@engine-flutter-autoroll
508be6f Ignore one avoid_redundant_argument_values, requires linter f…
d60e2c6 
…ix. (flutter/flutter#109049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2022
@engine-flutter-autoroll
508be6f Ignore one avoid_redundant_argument_values, requires linter f…
8f7a3d3 
…ix. (flutter/flutter#109049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2022
@engine-flutter-autoroll
508be6f Ignore one avoid_redundant_argument_values, requires linter f…
6d7b5f1 
…ix. (flutter/flutter#109049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2022
@engine-flutter-autoroll
508be6f Ignore one avoid_redundant_argument_values, requires linter f…
e9559ac 
…ix. (flutter/flutter#109049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2022
@engine-flutter-autoroll
508be6f Ignore one avoid_redundant_argument_values, requires linter f…
c339e24 
…ix. (flutter/flutter#109049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2022
@engine-flutter-autoroll
508be6f Ignore one avoid_redundant_argument_values, requires linter f…
b2010bc 
…ix. (flutter/flutter#109049)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@scheglov @camsim99
Ignore one avoid_redundant_argument_values, requires linter fix. (flu…
b3a0097 
…tter#109049)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iskakaushik iskakaushik iskakaushik approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scheglov @iskakaushik @goderbauer