[platform_view]longer wait time for element #108907
Conversation
flutter-dashboard
bot
added
the
c: contributor-productivity
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Looks like our CI does not recognizer XCUITest as test. |
| XCUIElement *entranceButton = self.app.buttons[@"platform view focus test"]; | ||
| XCTAssertTrue([entranceButton waitForExistenceWithTimeout:1]); | ||
| XCTAssertTrue([entranceButton waitForExistenceWithTimeout:kStandardTimeOut]); |
There was a problem hiding this comment.
It looks like the button is there. How about also logging self.app on failure so it dumps the tree?
#108898 (comment)
| BOOL newPageAppeared = [self.app.textFields[@"platform_view[0]"] waitForExistenceWithTimeout:kStandardTimeOut]; | ||
| if (!newPageAppeared) { | ||
| NSLog(@"First try failed. The tree is %@", self.app.debugDescription); | ||
| [self waitForAndTapElement:self.app.buttons[@"platform view focus test"]]; |
There was a problem hiding this comment.
Retapping seems like overkill at this point since we don't know what the tree looks like. Just increase the timeout and log on failure, then we'll have more information about whether there's a real bug, or if we need workarounds like retapping.
There was a problem hiding this comment.
Sounds good. Updated
dev/integration_tests/ios_platform_view_tests/ios/PlatformViewUITests/PlatformViewUITests.m
Outdated
Show resolved
Hide resolved
…UITests/PlatformViewUITests.m Co-authored-by: Jenn Magder <magder@google.com>
hellohuanlin
added
the
autosubmit
All the flakiness linked in the issue failed at
Checking existence of "platform view focus test" Button. The other XCUITest we have uses 60 seconds instead of 1 second. So I follow this convention.Some recent failed test has a different failure that fails to even launching the app.
Let's try this solution first: #90535
List which issues are fixed by this PR. You must list at least one issue.
#108898
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.