Clean up help messages for disabling and suppressing analytics

[eliasyishak]

Clean up the flag help message for --suppress-analytics to be more clear that it will only suppress analytics for the current run while --disable-telemtry will disable analytics permanently

Current state

Global options:
-h, --help                  Print this usage information.
-v, --verbose               Noisy logging, including all shell commands executed.
                            If used with "--help", shows hidden options. If used with "flutter doctor", shows additional diagnostic information. (Use
                            "-vv" to force verbose logging in those cases.)
-d, --device-id             Target device id or name (prefixes allowed).
    --version               Reports the version of this tool.
    --suppress-analytics    Suppress analytics reporting when this command runs. ***** FIX THIS
    --disable-telemetry     Disable telemetry reporting when this command runs. *****

Look for the line above where it says FIX THIS

[eliasyishak]

Note for me: Remove the conditional check that disables telemetry within flutter_tools once the unified_analytics update lands to check legacy status

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.