Skip to content

Eliminate DisplayListCanvasRecorder from flutter::PictureRecorder #116670

Closed
flutter/engine
#38127
@flar

Description

@flar

The native PictureRecorder class creates an SkCanvas->Builder recorder by default as a vestigial reference to the early days of DisplayList integration where some of the native versions of ui.Canvas calls were expressed as calls on an SkCanvas and the ui.Paragraph code also called only SkCanvas methods.

The flutter::Canvas calls were all converted to using the DisplayListBuilder instead of the SkCanvas adapter months ago (except for 2 references which can be fixed). The ui.Paragraph code was also recently updated to express itself through DisplayListBuilder calls. At this point, there is no longer any reason for the flutter::PictureRecorder class to create a DisplayListCanvasRecorder just to extract the DisplayListBuilder out of it and only use that object. It should just create a DisplayListBuilder directly and be clean of any Skia objects.

Metadata

Metadata

Assignees

No one assigned

    Labels

    engineflutter/engine repository. See also e: labels.

    Type

    No type

    Projects

    Status

    ✅ Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions