Engine -> Framework roll blocked on dart fix test failure.

[zanderso]

dart fix tests are blocking the Engine -> Framework roll:

https://ci.chromium.org/ui/p/flutter/builders/try/Windows%20framework_tests_misc/20038/overview from #105633 that includes the Dart roll https://dart.googlesource.com/sdk.git/+log/6a7e6decee92..68fd70178cbf, and only one other unrelated change.

[zanderso]

I see changes to dart fix in the commit log from @pq

[pq]

Two of my changes could potentially be the root of this: dart-lang/sdk@3290d7a or dart-lang/sdk@467a1b0. My guess is the former but will look a bit closer.

[pq]

Curiously, the flutter-engine try bot runs were clean for both changes...

https://dart-review.googlesource.com/c/sdk/+/246160 and https://dart-review.googlesource.com/c/sdk/+/246663

[zanderso]

This can be downgraded when the roll here lands: #105650

[jason-simmons]

The affected test works on my Windows setup if I revert the other dart fix patch (https://dart-review.googlesource.com/c/sdk/+/246160)

[pq]

Oh! OK, that surprises me. I'll go ahead and revert that. Apologies! And thanks for the catch @jason-simmons!

[jason-simmons]

It works on Windows with https://dart-review.googlesource.com/c/sdk/+/246160 if I patch _getTarget to use the directory path normalization from before that PR:

  io.FileSystemEntity _getTarget(List<String> arguments) {
    var argumentCount = arguments.length;
    if (argumentCount > 1) {
      usageException('Only one file or directory is expected.');
    }
    io.Directory dir =
        argumentCount == 0 ? io.Directory.current : io.Directory(arguments[0]);
    var normalizedPath = path.canonicalize(path.normalize(dir.absolute.path));
    return io.FileSystemEntity.isDirectorySync(normalizedPath)
        ? io.Directory(normalizedPath)
        : io.File(normalizedPath);
  }

(The failing test is running dart fix --compare-to-golden in flutter\packages\flutter\test_fixes, i.e. the argumentCount == 0 case above)

[pq]

Ah! Funny. I'd expect that to have been caught on our windows bots... Will have to dig in. Thanks!

[pq]

Thanks a million @jason-simmons! I'm building w/ your fix locally now. (I'll take a look at adding some more tests too...)

[pq]

New patch: https://dart-review.googlesource.com/c/sdk/+/247608. 🦅