Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cc13cd1f1191
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b5847d364a26
Choose a head ref
  • 12 commits
  • 90 files changed
  • 7 contributors

Commits on Aug 13, 2024

  1. Roll Flutter Engine from 73c3135cc3be to 4246f1536c5d (2 revisions) (#… 

    …153377)

flutter/engine@73c3135...4246f15

2024-08-13 zanderso@users.noreply.github.com Revert "Reland: Partial repaint platform views" (flutter/engine#54537)
2024-08-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 9a6ec6cc9627 to 44635f897535 (2 revisions) (flutter/engine#54536)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    aba0094 View commit details
    Browse the repository at this point in the history

  2. Roll pub packages (#153380) 

    This PR was generated by `flutter update-packages --force-upgrade`.
    @flutter-pub-roller-bot
    flutter-pub-roller-bot authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    5f99d57 View commit details
    Browse the repository at this point in the history

  3. Roll Packages from d9a6de8 to e4f2247 (4 revisions) (#153383) 

    flutter/packages@d9a6de8...e4f2247

2024-08-13 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7386)
2024-08-13 engine-flutter-autoroll@skia.org Manual roll Flutter from 814e49b to 2afc452 (12 revisions) (flutter/packages#7399)
2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/image_picker/image_picker_android/android (flutter/packages#7390)
2024-08-12 engine-flutter-autoroll@skia.org Roll Flutter from 9b84701 to 814e49b (3 revisions) (flutter/packages#7396)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    b32eaf6 View commit details
    Browse the repository at this point in the history

  4. Bump github/codeql-action from 3.26.0 to 3.26.1 (#153395) 

    Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.0 to 3.26.1.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/29d86d22a34ea372b1bbf3b2dced2e25ca6b3384"><code>29d86d2</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2422">#2422</a> from github/update-v3.26.1-0d5982aa3</li>
<li><a href="https://github.com/github/codeql-action/commit/5b15b9edebe00db5747d988e9a8ffe6835a3ba1c"><code>5b15b9e</code></a> Revert &quot;Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2417">#2417</a> from github/update-bundle/codeql-bundle-v2.1...</li>
<li><a href="https://github.com/github/codeql-action/commit/18ac79e766760e675ee0af0bf3ae0e92e6262899"><code>18ac79e</code></a> Update changelog for v3.26.1</li>
<li><a href="https://github.com/github/codeql-action/commit/0d5982aa33b304cca5a9269bccaa65962f580015"><code>0d5982a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2416">#2416</a> from github/henrymercer/ghes-3.14-compat-info</li>
<li><a href="https://github.com/github/codeql-action/commit/da9ecb0f4039749056c2604b249a081b10b67605"><code>da9ecb0</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2421">#2421</a> from github/henrymercer/log-job-run-uuid</li>
<li><a href="https://github.com/github/codeql-action/commit/c4c3c4421f30858dc2e509489f5f6f3b86940613"><code>c4c3c44</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2417">#2417</a> from github/update-bundle/codeql-bundle-v2.18.2</li>
<li><a href="https://github.com/github/codeql-action/commit/41833c77c62b312076de9fdfbb37bcd2750ed7d3"><code>41833c7</code></a> Log job run UUID</li>
<li><a href="https://github.com/github/codeql-action/commit/d620faa0b4e283b6884bb77fbe9f3ad4183b44a3"><code>d620faa</code></a> Bump the npm group with 4 updates (<a href="https://redirect.github.com/github/codeql-action/issues/2419">#2419</a>)</li>
<li><a href="https://github.com/github/codeql-action/commit/25ad3c8e4067d58361177f34122cf9ae8abb4bd0"><code>25ad3c8</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2418">#2418</a> from github/henrymercer/extraction-time-telemetry</li>
<li><a href="https://github.com/github/codeql-action/commit/44ecae48963229763960cf097fd45a1e37563335"><code>44ecae4</code></a> Fix matrixing of &quot;submit SARIF after failure&quot; check</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/eb055d739abdc2e8de2e5f4ba1a8b246daa779aa...29d86d22a34ea372b1bbf3b2dced2e25ca6b3384">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.26.0&new-version=3.26.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
    @dependabot
    dependabot[bot] authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    87abed2 View commit details
    Browse the repository at this point in the history

  5. fix(flutter/a11y assessments): h1 missing a11y from each page on the … 

    …web app (#152198)

Adds Semantic Widget to wrap the contents of each page's AppBar title attribute and adds header: true and headingLevel: 1 as Semantic attributes so the content of the title is compiled as an h1 tag to meet accessibility guidelines that each page must have a h1 tag present. Also updates the test cases for the home page and each use case page to check for its respective h1.

[Before Screenshot - Accessibility Assessments Home Page](https://screenshot.googleplex.com/4i9LuiGwvLnEcZ8)
[Before Screenshot - Checkbox List Title -- note: each use case page is missing an h1](https://screenshot.googleplex.com/3qQjfqvAMTehRsm)
[After Screenshot - Accessibility Assessments Home Page](https://screenshot.googleplex.com/APSJJXBmwNBP35m)
[After Screenshot - Checkbox List Title-- note: change is similar across each Accessibility use case page](https://screenshot.googleplex.com/6EGgZnTusEgeN5L)

Fixes b/338035526
    @essjay05
    essjay05 authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    85b3d97 View commit details
    Browse the repository at this point in the history

  6. Roll Flutter Engine from 4246f1536c5d to 019f9e3f0744 (2 revisions) (#… 

    …153394)

flutter/engine@4246f15...019f9e3

2024-08-13 jonahwilliams@google.com [Impeller] fix drawPoints scaling factors. (flutter/engine#54368)
2024-08-13 zanderso@users.noreply.github.com Move API level 34 scenario app tests back to prod (flutter/engine#54539)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    fb35123 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Move @_debugOnly documentation in framework.dart to be more visib… 

    …le to IDE. (#153134)

Change the location of the documentation of `@_debugOnly` following the style of `@override` so it is visible to IDE where the annotation is used.
    @PurplePolyhedron
    PurplePolyhedron authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    5937291 View commit details
    Browse the repository at this point in the history

  2. Manual roll Flutter Engine from 019f9e3f0744 to 5909666fdedb (12 revi… 

    …sions) (#153413)

Manual roll requested by zra@google.com

flutter/engine@019f9e3...5909666

2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (#54541)" (flutter/engine#54552)
2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: Clean up create_ios_framework.py (#54543)" (flutter/engine#54550)
2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: refactor create_macos_framework.py (#54546)" (flutter/engine#54549)
2024-08-14 chris@bracken.jp macOS: refactor create_macos_framework.py (flutter/engine#54546)
2024-08-13 flar@google.com [DisplayList] Allow random access to ops through indexing (flutter/engine#54484)
2024-08-13 mit@google.com Update dartdoc for gpu.dart (flutter/engine#54529)
2024-08-13 chris@bracken.jp macOS: Clean up create_ios_framework.py (flutter/engine#54543)
2024-08-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (flutter/engine#54541)
2024-08-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 2LTVy4Gv76DcMpz4V... to MeV5i7xXXFPHF5sBK... (flutter/engine#54542)
2024-08-13 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Add animation detection for GIFs (flutter/engine#54483)
2024-08-13 matej.knopp@gmail.com Preserve background frame damage (flutter/engine#54540)
2024-08-13 6844906+zijiehe-google-com@users.noreply.github.com [fuchsia] Use BundledTestRunner from test-scripts (flutter/engine#54404)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 2LTVy4Gv76Dc to MeV5i7xXXFPH

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    92c98e8 View commit details
    Browse the repository at this point in the history

  3. [web] Pass --no-source-maps instead of `--extra-compiler-option=--n… 

    …o-source-maps` to `dart compile wasm` (#153417)
    @mkustermann
    mkustermann authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    354902f View commit details
    Browse the repository at this point in the history

  4. Roll Flutter Engine from 5909666fdedb to 328c4df8329f (1 revision) (#… 

    …153436)

flutter/engine@5909666...328c4df

2024-08-14 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from Kq699Ii76C_pozQ9Y... to J1EXQ2ozMIQEa6F7H... (flutter/engine#54551)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    0e6c1d1 View commit details
    Browse the repository at this point in the history

  5. Update cherry pick issue template's PR field (#153381) 

    Make it even more obvious which PR should be linked for folks that have difficulties reading ð��
    @loic-sharma
    loic-sharma authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    6ef1156 View commit details
    Browse the repository at this point in the history

  6. Delay DropdownMenu filtering until text input (#152368) 

    fixes #152055

Disabling filtering in `DropdownMenu` at start and after a selection has been made, and re-enable it (if `widget.enableFilter` is true) after text input.
This way it doesn't hide all other options when there is an existing selection.

Note: currently this may crush due to issue #151878 . Which is not directly related to this PR
    @PurplePolyhedron
    PurplePolyhedron authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    b5847d3 View commit details
    Browse the repository at this point in the history
Loading