-
Notifications
You must be signed in to change notification settings - Fork 28.9k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: 4d12197ca68d
head repository: flutter/flutter
compare: f817e51a3a34
- 7 commits
- 6 files changed
- 4 contributors
Commits on Jul 26, 2024
-
Add button semantics in list tile (#151599)
fixes: #111960 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Configuration menu - View commit details
-
Copy full SHA for 37dff27 - Browse repository at this point
Copy the full SHA 37dff27View commit details
Commits on Jul 27, 2024
-
Roll Flutter Engine from e28f8755e25b to 0c5504e15e15 (5 revisions) (#…
…152414) flutter/engine@e28f875...0c5504e 2024-07-26 30870216+gaaclarke@users.noreply.github.com [impeller] adds test for catching shimmer in gaussian blur (flutter/engine#54116) 2024-07-26 30870216+gaaclarke@users.noreply.github.com Revert "[Impeller] Use downsample shader for blur instead of mip levels. (#53760)" (flutter/engine#54148) 2024-07-26 skia-flutter-autoroll@skia.org Roll Skia from 61ac357e8e33 to 4a97d01dfedd (2 revisions) (flutter/engine#54146) 2024-07-26 skia-flutter-autoroll@skia.org Roll Dart SDK from 1b29ac31628f to de1925e18998 (1 revision) (flutter/engine#54145) 2024-07-26 matanlurey@users.noreply.github.com Pub workspace-ify most of `testing/` and parts of `tools/` (flutter/engine#54124) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 8ac0fe5 - Browse repository at this point
Copy the full SHA 8ac0fe5View commit details -
Roll Flutter Engine from 0c5504e15e15 to 739ae15e8bf2 (4 revisions) (#…
…152417) flutter/engine@0c5504e...739ae15 2024-07-26 zanderso@users.noreply.github.com Split up mac_host_engine builds (flutter/engine#53571) 2024-07-26 chinmaygarde@google.com [Impeller] Fix the operator used to build the condition to check for OpenGLES. (flutter/engine#54155) 2024-07-26 skia-flutter-autoroll@skia.org Roll Skia from 4a97d01dfedd to 9632ef8f18c1 (7 revisions) (flutter/engine#54154) 2024-07-26 skia-flutter-autoroll@skia.org Roll Dart SDK from de1925e18998 to 65bb9e8275bc (1 revision) (flutter/engine#54153) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 4d40e7e - Browse repository at this point
Copy the full SHA 4d40e7eView commit details -
Document that
flutter drive --test-arguments
can opt-in to `dart te……st` (#152410) Closes #51135. Closes #145499. Making this the _default_, or better discoverable, is tracked in #152409. You'll notice I also removed `-rexpanded`; @jonahwilliams believes that was accidentally copied over from else-where, and never did anything (someone I guess could have parsed it in `void main(...)`, but given #51135 & #145499 that seems unlikely.
Configuration menu - View commit details
-
Copy full SHA for 40d9fcf - Browse repository at this point
Copy the full SHA 40d9fcfView commit details -
Roll Flutter Engine from 739ae15e8bf2 to 38fddb289f18 (2 revisions) (#…
…152424) flutter/engine@739ae15...38fddb2 2024-07-27 skia-flutter-autoroll@skia.org Roll Skia from 9632ef8f18c1 to f478e89036d2 (1 revision) (flutter/engine#54158) 2024-07-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 65bb9e8275bc to ad35a6027648 (1 revision) (flutter/engine#54159) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 1794136 - Browse repository at this point
Copy the full SHA 1794136View commit details -
Reverts "Add button semantics in list tile (#151599)" (#152425)
Configuration menu - View commit details
-
Copy full SHA for e8d4c98 - Browse repository at this point
Copy the full SHA e8d4c98View commit details -
Roll Flutter Engine from 38fddb289f18 to add1b784b80a (3 revisions) (#…
…152436) flutter/engine@38fddb2...add1b78 2024-07-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from iuUKz0zFWsn54yP69... to UJOkCKt967UoXQxZS... (flutter/engine#54163) 2024-07-27 aam@google.com Remove obsolete dependency (flutter/engine#54161) 2024-07-27 skia-flutter-autoroll@skia.org Roll Skia from f478e89036d2 to 78de03720755 (1 revision) (flutter/engine#54160) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from iuUKz0zFWsn5 to UJOkCKt967Uo If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for f817e51 - Browse repository at this point
Copy the full SHA f817e51View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 4d12197ca68d...f817e51a3a34